Dynamic\Foxy\Discounts\Extension\PageControllerExtension

Complexity

Total Complexity

4

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getDiscountFieldValue()	0	7	2
A	updateAddToCartForm()	0	11	2

<?php

namespace Dynamic\Foxy\Discounts\Extension;

use Dynamic\Foxy\Form\AddToCartForm;
use Dynamic\Foxy\Model\FoxyHelper;
use SilverStripe\Core\Extension;
use SilverStripe\Forms\HiddenField;

class PageControllerExtension extends Extension
{
    /**
     * @param $form
     */
    public function updateAddToCartForm(&$form)
    {
        if ($this->owner->data()->getActiveDiscount()) {
            $code = $this->owner->data()->Code;
            $fields = $form->Fields();
            $fields->push(
                HiddenField::create(AddToCartForm::getGeneratedValue(
                    $code,
                    'discount_quantity_percentage',
                    $this->getDiscountFieldValue()
                ))->setValue($this->getDiscountFieldValue())
            );
        }
    }

    /**
     * @return string
     */
    public function getDiscountFieldValue()
    {
        if ($discount = $this->owner->data()->getActiveDiscount()) {
            $string = "|{$discount->Quantity}-{$discount->Percentage}";
            return "{$discount->Title}{allunits{$string}}";
        }
        return false;

The expression return false returns the type false which is incompatible with the documented return type string.

    }
}