View GitHub Repository dynamic-blocks

Schedule Inspection
Subscribe
Completed
Pull Request — master (#62)
by Jason
15:39
created
Status
Category
Toggle Patches
code/blocks/AccordionBlock.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -46,7 +46,7 @@
 
 block discarded – undo
46 46 
     );
47 47
48 48 
     /**
49 
-     * @return FieldList
49 
+     * @return \SilverStripe\Forms\FieldList
50 50 
      */
51 51 
     public function getCMSFields()
52 52 
     {
Please login to merge, or discard this patch.
code/blocks/CallToActionBlock.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -30,7 +30,7 @@
 
 block discarded – undo
30 30 
     ];
31 31
32 32 
     /**
33 
-     * @return FieldList
33 
+     * @return \SilverStripe\Forms\FieldList
34 34 
      */
35 35 
     public function getCMSFields()
36 36 
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -34,7 +34,7 @@
 
 block discarded – undo
34 34 
      */
35 35 
     public function getCMSFields()
36 36 
     {
37 
-        $this->beforeUpdateCMSFields(function ($fields) {
37 
+        $this->beforeUpdateCMSFields(function($fields) {
38 38
39 39 
             /* // todo readd once Linkable is SS4 compatible
40 40 
             $fields->addFieldToTab(
Please login to merge, or discard this patch.
code/blocks/CustomerServiceBlock.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -34,7 +34,7 @@
 
 block discarded – undo
34 34 
     );
35 35
36 36 
     /**
37 
-     * @return FieldList
37 
+     * @return \SilverStripe\Forms\FieldList
38 38 
      */
39 39 
     public function getCMSFields()
40 40 
     {
Please login to merge, or discard this patch.
code/blocks/EmailSignupBlock.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -31,7 +31,7 @@
 
 block discarded – undo
31 31 
     ];
32 32
33 33 
     /**
34 
-     * @return FieldList
34 
+     * @return \SilverStripe\Forms\FieldList
35 35 
      */
36 36 
     public function getCMSFields()
37 37 
     {
Please login to merge, or discard this patch.
code/blocks/EmbedCodeBlock.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -39,7 +39,7 @@
 
 block discarded – undo
39 39 
     ];
40 40
41 41 
     /**
42 
-     * @return \FieldList
42 
+     * @return \SilverStripe\Forms\FieldList
43 43 
      */
44 44 
     public function getCMSFields()
45 45 
     {
Please login to merge, or discard this patch.
code/blocks/PromoBlock.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -44,7 +44,7 @@
 
 block discarded – undo
44 44 
     );
45 45
46 46 
     /**
47 
-     * @return FieldList
47 
+     * @return \SilverStripe\Forms\FieldList
48 48 
      */
49 49 
     public function getCMSFields()
50 50 
     {
Please login to merge, or discard this patch.
code/objects/PageSectionObject.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -70,7 +70,7 @@  discard block
 
 block discarded – undo
70 70 
     );
71 71
72 72 
     /**
73 
-     * @return FieldList
73 
+     * @return \SilverStripe\Forms\FieldList
74 74 
      */
75 75 
     public function getCMSFields()
76 76 
     {
 
@@ -102,7 +102,7 @@  discard block
 
 block discarded – undo
102 102 
     }
103 103
104 104 
     /**
105 
-     * @return ValidationResult
105 
+     * @return \SilverStripe\ORM\ValidationResult
106 106 
      */
107 107 
     public function validate()
108 108 
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -74,7 +74,7 @@
 
 block discarded – undo
74 74 
      */
75 75 
     public function getCMSFields()
76 76 
     {
77 
-        $this->beforeUpdateCMSFields(function ($fields) {
77 
+        $this->beforeUpdateCMSFields(function($fields) {
78 78
79 79 
             /*
80 80 
             $fields->addFieldToTab(
Please login to merge, or discard this patch.
code/blocks/EmbedBlock.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -32,7 +32,7 @@
 
 block discarded – undo
32 32 
     /**
33 33 
      * @return \SilverStripe\Forms\FieldList
34 34 
      */
35 
-    public function getCMSFields(){
35 
+    public function getCMSFields() {
36 36 
         $fields = parent::getCMSFields();
37 37
38 38 
         $fields->removeByName([
Please login to merge, or discard this patch.
code/objects/PromoObject.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -71,7 +71,7 @@
 
 block discarded – undo
71 71 
      */
72 72 
     public function getCMSFields()
73 73 
     {
74 
-        $this->beforeUpdateCMSFields(function ($fields) {
74 
+        $this->beforeUpdateCMSFields(function($fields) {
75 75
76 76 
             /* // todo readd once Linkable is SS4 compatible
77 77 
             $fields->addFieldToTab(
Please login to merge, or discard this patch.