dylangrech92 / seotoolbox

code/extenstions/SEOToolboxControllerExtension.php

Spacing +54 added lines, -54 removed lines

@@ -18,12 +18,12 @@ 
     private $excludeTags    = array();
     private $maxLinks       = 0;
 
-    public function index(){
+    public function index() {
         $this->addAutomatedLinks();
 
         // If we have a crawl request check the CrawlID so we're sure we didn't hit another SS site running our module
-        if( $crawl_id = $this->owner->request->getHeader('X-Crawl-Id') ){
-            return( $crawl_id == GlobalAutoLinkSettings::get_current()->CrawlID )
+        if ($crawl_id = $this->owner->request->getHeader('X-Crawl-Id')) {
+            return($crawl_id == GlobalAutoLinkSettings::get_current()->CrawlID)
                 ? $this->crawl_response()
                 : $this->owner->redirect(SEOTestSiteTreeController::getPermissionDeniedPage()->Link());
         }
@@ -31,15 +31,15 @@ 
         return array();
     }
 
-    private function crawl_response(){
+    private function crawl_response() {
         // Encoded version to detect which fields are being used
         $customize = array();
         $dbFields  = Config::inst()->get($this->owner->ClassName, 'db');
-        if(is_array($dbFields)) {
-            foreach ( $dbFields as $field => $type) {
+        if (is_array($dbFields)) {
+            foreach ($dbFields as $field => $type) {
                 if (strtolower($type) == 'htmltext') {
                     $data = ($this->owner->hasMethod($field)) ? $this->owner->$field() : $this->owner->$field;
-                    if($data){
+                    if ($data) {
                         $tmp = new HTMLText('tmp');
                         $tmp->setValue($data);
                         $data = base64_encode($tmp->forTemplate());
@@ -90,31 +90,31 @@ 
      *
      * @return void
      */
-    public function addAutomatedLinks(){
-        if( GlobalAutoLinkSettings::$enabled && $this->owner->class != 'RedirectorPage' ) {
+    public function addAutomatedLinks() {
+        if (GlobalAutoLinkSettings::$enabled && $this->owner->class != 'RedirectorPage') {
             $this->getSettings();
-            if( !$this->addLinks ) {
+            if (!$this->addLinks) {
                 return;
             }
 
-            foreach( $this->getSettings()->IncludeInFields() as $field ){
+            foreach ($this->getSettings()->IncludeInFields() as $field) {
                 // Check that the field provided by user exists in this object, is of type HTMLText and has content
-                if( AutomatedLink::isFieldParsable( $this->owner->data(), $field ) ){
+                if (AutomatedLink::isFieldParsable($this->owner->data(), $field)) {
 
                     // Create dummy object so we can parse the HTML
-                    $dummy = new HTMLText( $field );
-                    $dummy->setValue( $this->owner->$field );
+                    $dummy = new HTMLText($field);
+                    $dummy->setValue($this->owner->$field);
                     // Create DOMDocument Object
-                    $content = mb_convert_encoding( $dummy->forTemplate(), 'html-entities', GlobalAutoLinkSettings::$encoding );
+                    $content = mb_convert_encoding($dummy->forTemplate(), 'html-entities', GlobalAutoLinkSettings::$encoding);
                     $dom = AutomatedLink::constructDOMDocument($content);
 
                     // Check current link count and if it's already exceeded do nothing
-                    $this->linkCount += (int) $dom->getElementsByTagName( 'a' )->length;
-                    if( $this->linkCount >= $this->maxLinks ) {
+                    $this->linkCount += (int) $dom->getElementsByTagName('a')->length;
+                    if ($this->linkCount >= $this->maxLinks) {
                         return;
                     }
 
-                    $parsed = $this->parseField( $dom, $field );
+                    $parsed = $this->parseField($dom, $field);
                     $this->owner->data()->$field = $parsed;
                     $this->owner->$field         = $parsed;
                 }
@@ -130,19 +130,19 @@ 
      * @param array $hash_tags
      * @return array
      */
-    private function hashTags( DOMDocument $html, $hash_tags ){
+    private function hashTags(DOMDocument $html, $hash_tags) {
         $excluded = array();
-        foreach( $hash_tags as $eTag ){
-            while( $tags = $html->getElementsByTagName( $eTag ) ){
-                if( !$tags->length ) break 1;
-                $tag	= $tags->item(0);
-                $value  = $html->saveHTML( $tag );
-                $key    = (string) crc32( $value );
+        foreach ($hash_tags as $eTag) {
+            while ($tags = $html->getElementsByTagName($eTag)) {
+                if (!$tags->length) break 1;
+                $tag = $tags->item(0);
+                $value  = $html->saveHTML($tag);
+                $key    = (string) crc32($value);
 
                 // Convert back children nodes of this node if they were already hashed
-                $excluded[$key] = str_replace( array_keys( $excluded ), array_values( $excluded ), $value );
+                $excluded[$key] = str_replace(array_keys($excluded), array_values($excluded), $value);
 
-                $tag->parentNode->replaceChild( $html->createTextNode( $key ), $tag );
+                $tag->parentNode->replaceChild($html->createTextNode($key), $tag);
             }
         }
 
@@ -157,38 +157,38 @@ 
      * @param string $content
      * @return array
      */
-    public function addLinkToContent(AutomatedLink $link, &$content){
+    public function addLinkToContent(AutomatedLink $link, &$content) {
         $links  = array();
-        $max    = (int) ( $link->MaxLinksPerPage > 0 ) ? $link->MaxLinksPerPage : PHP_INT_MAX;
-        $escape = (string) preg_quote( $link->Phrase, '/' );
-        $regex  = (string) ( $link->CaseSensitive ) ? "/(\b{$escape}\b)/" : "/(\b{$escape}\b)/i";
+        $max    = (int) ($link->MaxLinksPerPage > 0) ? $link->MaxLinksPerPage : PHP_INT_MAX;
+        $escape = (string) preg_quote($link->Phrase, '/');
+        $regex  = (string) ($link->CaseSensitive) ? "/(\b{$escape}\b)/" : "/(\b{$escape}\b)/i";
 
         // Count the matches
-        preg_match_all( $regex, $content, $count );
-        $count = ( is_array( $count ) && isset( $count[0] ) ) ? count( $count[0] ) : 0;
-        if( $count < 1 ) $links;
+        preg_match_all($regex, $content, $count);
+        $count = (is_array($count) && isset($count[0])) ? count($count[0]) : 0;
+        if ($count < 1) $links;
 
-        if( isset( $this->maxLinksPerPage[ $link->ID ] ) ) {
+        if (isset($this->maxLinksPerPage[$link->ID])) {
             $max -= $this->maxLinksPerPage[$link->ID];
-        } else {
+        }else {
             $this->maxLinksPerPage[$link->ID] = 0;
         }
 
-        for( $x = 0; $x < $count; $x++ ){
+        for ($x = 0; $x < $count; $x++) {
             // Stop adding links if we reached the link or page limit
-            if( $x >= $max || $this->linkCount >= $this->maxLinks ) break;
+            if ($x >= $max || $this->linkCount >= $this->maxLinks) break;
 
             // Check if there is anything else to replace else stop
-            preg_match( $regex, $content, $match );
-            if( !is_array( $match ) || !count( $match ) ) break;
+            preg_match($regex, $content, $match);
+            if (!is_array($match) || !count($match)) break;
 
-            if( !$html = (string) $link->getHTML( $match[0] ) ) continue;
-            $key            = (string) crc32( $html );
-            $links[ $key ]  = (string) $html;
+            if (!$html = (string) $link->getHTML($match[0])) continue;
+            $key            = (string) crc32($html);
+            $links[$key]  = (string) $html;
 
-            $content = preg_replace( $regex, $key, $content, 1 );
+            $content = preg_replace($regex, $key, $content, 1);
             $this->linkCount++;
-            $this->maxLinksPerPage[ $link->ID ]++;
+            $this->maxLinksPerPage[$link->ID]++;
         }
 
         return $links;
@@ -201,24 +201,24 @@ 
      * @param String $field
      * @return string
      */
-    private function parseField( DOMDocument $html, $field ){
-        $this->owner->extend( 'beforeParseField', $html, $field );
+    private function parseField(DOMDocument $html, $field) {
+        $this->owner->extend('beforeParseField', $html, $field);
 
         // Remove Tags from Content we wown't be using
         $excluded   = $this->hashTags($html, $this->excludeTags);
-        $body       = (string)$html->saveHTML( $html->getElementsByTagName('body')->item(0) );
-        $content    = preg_replace( array( '/\<body\>/is', '/\<\/body\>/is' ), '', $body, 1 );
+        $body       = (string) $html->saveHTML($html->getElementsByTagName('body')->item(0));
+        $content    = preg_replace(array('/\<body\>/is', '/\<\/body\>/is'), '', $body, 1);
 
-        foreach( AutomatedLink::get()->sort('Priority') as $link){
-            if( $this->linkCount < $this->maxLinks && $link->canBeAdded( $this->owner, $field ) ) {
+        foreach (AutomatedLink::get()->sort('Priority') as $link) {
+            if ($this->linkCount < $this->maxLinks && $link->canBeAdded($this->owner, $field)) {
                 $links = $this->addLinkToContent($link, $content);
-                if( is_array($links) && count($links) > 0 ) {
-                    $excluded = $excluded + $links;
+                if (is_array($links) && count($links) > 0) {
+                    $excluded = $excluded+$links;
                 }
             }
         }
 
         // Re-add the excluded Tags
-        return str_replace( array_keys( $excluded ), array_values( $excluded ), $content );
+        return str_replace(array_keys($excluded), array_values($excluded), $content);
     }
 }

Braces +21 added lines, -7 removed lines

@@ -73,12 +73,16 @@ 
     private function getSettings() {
         if ($this->settings === null) {
             $this->settings = GlobalAutoLinkSettings::get_current();
-            if (!$this->settings) return $this->addLinks = false;
+            if (!$this->settings) {
+                return $this->addLinks = false;
+            }
 
             $this->excludeTags = (array) $this->settings->ExcludeTags();
             $this->maxLinks = (int) ($this->settings->MaxLinksPerPage) ? $this->settings->MaxLinksPerPage : PHP_INT_MAX;
 
-            if (!in_array($this->owner->ClassName, $this->settings->AllowedIn())) $this->addLinks = false;
+            if (!in_array($this->owner->ClassName, $this->settings->AllowedIn())) {
+                $this->addLinks = false;
+            }
         }
 
         return $this->settings;
@@ -134,7 +138,9 @@ 
         $excluded = array();
         foreach( $hash_tags as $eTag ){
             while( $tags = $html->getElementsByTagName( $eTag ) ){
-                if( !$tags->length ) break 1;
+                if( !$tags->length ) {
+                    break 1;
+                }
                 $tag	= $tags->item(0);
                 $value  = $html->saveHTML( $tag );
                 $key    = (string) crc32( $value );
@@ -166,7 +172,9 @@ 
         // Count the matches
         preg_match_all( $regex, $content, $count );
         $count = ( is_array( $count ) && isset( $count[0] ) ) ? count( $count[0] ) : 0;
-        if( $count < 1 ) $links;
+        if( $count < 1 ) {
+            $links;
+        }
 
         if( isset( $this->maxLinksPerPage[ $link->ID ] ) ) {
             $max -= $this->maxLinksPerPage[$link->ID];
@@ -176,13 +184,19 @@ 
 
         for( $x = 0; $x < $count; $x++ ){
             // Stop adding links if we reached the link or page limit
-            if( $x >= $max || $this->linkCount >= $this->maxLinks ) break;
+            if( $x >= $max || $this->linkCount >= $this->maxLinks ) {
+                break;
+            }
 
             // Check if there is anything else to replace else stop
             preg_match( $regex, $content, $match );
-            if( !is_array( $match ) || !count( $match ) ) break;
+            if( !is_array( $match ) || !count( $match ) ) {
+                break;
+            }
 
-            if( !$html = (string) $link->getHTML( $match[0] ) ) continue;
+            if( !$html = (string) $link->getHTML( $match[0] ) ) {
+                continue;
+            }
             $key            = (string) crc32( $html );
             $links[ $key ]  = (string) $html;