dukt\analytics\migrations\m170324_000003_fix_widget_options::safeUp()

Complexity

Conditions	4
Paths	2

Size

Total Lines	28
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

<?php
    public function safeUp()
    {
        $widgetResults = (new Query())
            ->select('*')
            ->from(['{{%widgets}}'])
            ->where(['type' => 'dukt\analytics\widgets\Realtime'])
            ->orWhere(['type' => 'dukt\analytics\widgets\Report'])
            ->all();

        if ($widgetResults) {

The expression $widgetResults of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($widgetResults as $result) {
                $settings = Json::decode($result['settings']);

                if (isset($settings['options']['metric'])) {
                    $settings['options'] = [
                        $settings['chart'] => $settings['options']
                    ];
                }

                // Update row

                $settings = Json::encode($settings);

                $this->update('{{%widgets}}', ['settings' => $settings], ['id' => $result['id']]);
            }
        }

        return true;
    }