dukt\analytics\migrations\m170324_000003_fix_widget_options

Complexity

Total Complexity

5

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	safeDown()	0	5	1
A	safeUp()	0	28	4

<?php

namespace dukt\analytics\migrations;

use craft\db\Migration;
use craft\db\Query;
use craft\helpers\Json;

/**
 * The class name is the UTC timestamp in the format of mYYMMDD_HHMMSS_pluginHandle_migrationName
 */
class m170324_000003_fix_widget_options extends Migration
{
    /**
     * Any migration code in here is wrapped inside of a transaction.
     *
     * @return bool
     */
    public function safeUp()
    {
        $widgetResults = (new Query())
            ->select('*')
            ->from(['{{%widgets}}'])
            ->where(['type' => 'dukt\analytics\widgets\Realtime'])
            ->orWhere(['type' => 'dukt\analytics\widgets\Report'])
            ->all();

        if ($widgetResults) {

The expression $widgetResults of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($widgetResults as $result) {
                $settings = Json::decode($result['settings']);

                if (isset($settings['options']['metric'])) {
                    $settings['options'] = [
                        $settings['chart'] => $settings['options']
                    ];
                }

                // Update row

                $settings = Json::encode($settings);

                $this->update('{{%widgets}}', ['settings' => $settings], ['id' => $result['id']]);
            }
        }

        return true;
    }

    /**
     * @inheritdoc
     */
    public function safeDown()
    {
        echo "m170324_000003_fix_widget_options cannot be reverted.\n";

        return false;
    }
}