Issues in DefaultRoute.php (master) - Issues in master - dspbee/pivasic - Measure and Improve Code Quality continuously with Scrutinizer

Issues (7)

Security Analysis 1 potential vulnerability

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection (1)

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Core/DefaultRoute.php (1 issue)

Labels

Security 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @license MIT
 */
namespace Pivasic\Core;

use Pivasic\Core\Exception\RouteException;

/**
 * Base routing.
 *
 * Class DefaultRoute
 * @package Pivasic\Core
 */
class DefaultRoute implements IRoute
{
    /**
     * Find and call controller, get Response object.
     *
     * @param string $packageRoot
     * @param Request $request
     * @return Response
     * @throws RouteException
     */
    public function getResponse(string &$packageRoot, Request &$request): Response
    {
        $packageRoot = rtrim($packageRoot, '/');
        $route = preg_replace('/\/\d+/u', '/D', $request->route());
        $path = $packageRoot . '/Route/' . $route . '/' . $request->method() . '.php';
        if (file_exists($path)) {
            require $path;
            $controllerClass = $request->package() . '\\Route_' . str_replace('/', '_', $route) . '\\' . $request->method();
            /**
             * @var BaseController $controller
             */
            if (class_exists($controllerClass)) {
                $controller = new $controllerClass($packageRoot, $request);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
            } else {
                throw new RouteException(sprintf('Route: the class "%s" does not exist', $controllerClass));
            }

            /**
             * Call handler.
             */
            $handler = filter_input_array(INPUT_POST)['handler'] ?? filter_input_array(INPUT_GET)['handler'] ?? 'index';
            if (method_exists($controllerClass, $handler)) {
                $controller->invoke($handler);
                return $controller->getResponse();
            } else {
                throw new RouteException(sprintf('Route: the method "%s" does not exist', $handler));
            }
        } else {
            throw new RouteException(sprintf('Route: path "%s" does not exist', $request->package() . '/Route/' . $route . '/' . $request->method() . '.php'));
        }
    }
}

1			<?php
2			/**
3			* @license MIT
4			*/
5			namespace Pivasic\Core;
6
7			use Pivasic\Core\Exception\RouteException;
8
9			/**
10			* Base routing.
11			*
12			* Class DefaultRoute
13			* @package Pivasic\Core
14			*/
15			class DefaultRoute implements IRoute
16			{
17			/**
18			* Find and call controller, get Response object.
19			*
20			* @param string $packageRoot
21			* @param Request $request
22			* @return Response
23			* @throws RouteException
24			*/
25			public function getResponse(string &$packageRoot, Request &$request): Response
26			{
27			$packageRoot = rtrim($packageRoot, '/');
28			$route = preg_replace('/\/\d+/u', '/D', $request->route());
29			$path = $packageRoot . '/Route/' . $route . '/' . $request->method() . '.php';
30			if (file_exists($path)) {
31			require $path;
32			$controllerClass = $request->package() . '\\Route_' . str_replace('/', '_', $route) . '\\' . $request->method();
33			/**
34			* @var BaseController $controller
35			*/
36			if (class_exists($controllerClass)) {
37			$controller = new $controllerClass($packageRoot, $request);
			0 ignored issues – show Security Code Execution introduced 2018-09-19 12:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$controllerClass` can contain request data and is used in code execution context(s) leading to a potential security vulnerability. 1 path for user data to reach this point `filter_input_array(INPUT_SERVER)['REQUEST_URI']` seems to return tainted data, and `$url` is assigned in src/Core/Request.php on line 25 `$url` is passed through explode(), and `$url` is assigned in src/Core/Request.php on line 33 `$url[0]` is passed through trim(), and `trim($url[0])` is passed through trim(), and `$url` is assigned in src/Core/Request.php on line 34 `$url` is passed through explode(), and `$partList` is assigned in src/Core/Request.php on line 36 `$partList` is passed through implode(), and Request::$route is assigned in src/Core/Request.php on line 60 Tainted property Request::$route is read in src/Core/Request.php on line 115 Request::route() returns tainted data, and `$request->route()` is passed through preg_replace(), and `$route` is assigned in src/Core/DefaultRoute.php on line 28 `$route` is passed through str_replace(), and `$controllerClass` is assigned in src/Core/DefaultRoute.php on line 32 General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
38			} else {
39			throw new RouteException(sprintf('Route: the class "%s" does not exist', $controllerClass));
40			}
41
42			/**
43			* Call handler.
44			*/
45			$handler = filter_input_array(INPUT_POST)['handler'] ?? filter_input_array(INPUT_GET)['handler'] ?? 'index';
46			if (method_exists($controllerClass, $handler)) {
47			$controller->invoke($handler);
48			return $controller->getResponse();
49			} else {
50			throw new RouteException(sprintf('Route: the method "%s" does not exist', $handler));
51			}
52			} else {
53			throw new RouteException(sprintf('Route: path "%s" does not exist', $request->package() . '/Route/' . $route . '/' . $request->method() . '.php'));
54			}
55			}
56			}

dspbee / pivasic

Issues (7)

Security Analysis 1 potential vulnerability

src/Core/DefaultRoute.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1 path for user data to reach this point

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like