|
1
|
|
|
<?php |
|
2
|
|
|
/** |
|
3
|
|
|
* @license MIT |
|
4
|
|
|
*/ |
|
5
|
|
|
namespace Pivasic\Core; |
|
6
|
|
|
|
|
7
|
|
|
use Pivasic\Core\Exception\RouteException; |
|
8
|
|
|
|
|
9
|
|
|
/** |
|
10
|
|
|
* Base routing. |
|
11
|
|
|
* |
|
12
|
|
|
* Class DefaultRoute |
|
13
|
|
|
* @package Pivasic\Core |
|
14
|
|
|
*/ |
|
15
|
|
|
class DefaultRoute implements IRoute |
|
16
|
|
|
{ |
|
17
|
|
|
/** |
|
18
|
|
|
* Find and call controller, get Response object. |
|
19
|
|
|
* |
|
20
|
|
|
* @param string $packageRoot |
|
21
|
|
|
* @param Request $request |
|
22
|
|
|
* @return Response |
|
23
|
|
|
* @throws RouteException |
|
24
|
|
|
*/ |
|
25
|
|
|
public function getResponse(string &$packageRoot, Request &$request): Response |
|
26
|
|
|
{ |
|
27
|
|
|
$packageRoot = rtrim($packageRoot, '/'); |
|
28
|
|
|
$route = preg_replace('/\/\d+/u', '/D', $request->route()); |
|
29
|
|
|
$path = $packageRoot . '/Route/' . $route . '/' . $request->method() . '.php'; |
|
30
|
|
|
if (file_exists($path)) { |
|
31
|
|
|
require $path; |
|
32
|
|
|
$controllerClass = $request->package() . '\\Route_' . str_replace('/', '_', $route) . '\\' . $request->method(); |
|
33
|
|
|
/** |
|
34
|
|
|
* @var BaseController $controller |
|
35
|
|
|
*/ |
|
36
|
|
|
if (class_exists($controllerClass)) { |
|
37
|
|
|
$controller = new $controllerClass($packageRoot, $request); |
|
|
|
|
|
|
38
|
|
|
} else { |
|
39
|
|
|
throw new RouteException(sprintf('Route: the class "%s" does not exist', $controllerClass)); |
|
40
|
|
|
} |
|
41
|
|
|
|
|
42
|
|
|
/** |
|
43
|
|
|
* Call handler. |
|
44
|
|
|
*/ |
|
45
|
|
|
$handler = filter_input_array(INPUT_POST)['handler'] ?? filter_input_array(INPUT_GET)['handler'] ?? 'index'; |
|
46
|
|
|
if (method_exists($controllerClass, $handler)) { |
|
47
|
|
|
$controller->invoke($handler); |
|
48
|
|
|
return $controller->getResponse(); |
|
49
|
|
|
} else { |
|
50
|
|
|
throw new RouteException(sprintf('Route: the method "%s" does not exist', $handler)); |
|
51
|
|
|
} |
|
52
|
|
|
} else { |
|
53
|
|
|
throw new RouteException(sprintf('Route: path "%s" does not exist', $request->package() . '/Route/' . $route . '/' . $request->method() . '.php')); |
|
54
|
|
|
} |
|
55
|
|
|
} |
|
56
|
|
|
} |
dspbee /
pivasic
$controllerClasscan contain request data and is used in code execution context(s) leading to a potential security vulnerability.1 path for user data to reach this point
filter_input_array(INPUT_SERVER)['REQUEST_URI']seems to return tainted data, and$urlis assignedin src/Core/Request.php on line 25
$urlis passed through explode(), and$urlis assignedin src/Core/Request.php on line 33
$url[0]is passed through trim(), andtrim($url[0])is passed through trim(), and$urlis assignedin src/Core/Request.php on line 34
$urlis passed through explode(), and$partListis assignedin src/Core/Request.php on line 36
$partListis passed through implode(), and Request::$route is assignedin src/Core/Request.php on line 60
in src/Core/Request.php on line 115
$request->route()is passed through preg_replace(), and$routeis assignedin src/Core/DefaultRoute.php on line 28
$routeis passed through str_replace(), and$controllerClassis assignedin src/Core/DefaultRoute.php on line 32
General Strategies to prevent injection
In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values:
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); }For numeric data, we recommend to explicitly cast the data: