Perfect::valid() - Code Metrics - Inspection of "Initial commit." - drupol/phpermutations - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b11566...550d6f )

by Pol

created 2017-01-02 06:27 UTC

Perfect::valid() A

↳ Parent: Perfect

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

namespace drupol\phpermutations\Iterators;

use drupol\phpermutations\Combinatorics;

/**
 * Class Perfect.
 *
 * @package drupol\phpermutations\Iterators
 */
class Perfect extends Combinatorics implements \Iterator, \Countable {

  /**
   * The maximum limit.
   *
   * @var int
   */
  protected $max;

  /**
   * The key.
   *
   * @var int
   */
  protected $key;

  /**
   * The count.
   *
   * @var int
   */
  protected $count = 1;

  /**
   * The default current value.
   *
   * @var int
   */
  protected $current = 2;

  /**
   * Perfect constructor.
   */
  public function __construct() {
    $this->setMaxLimit(PHP_INT_MAX);
  }

  /**
   * {@inheritdoc}
   */
  public function current() {
    return $this->current;
  }

  /**
   * {@inheritdoc}
   */
  public function next() {

    ++$this->key;
    for ($i = $this->key; $i < $this->getMaxLimit(); $i++) {
      if ($this->isPerfectNumber($i)) {
        $this->key = $i;
        $this->current = $i;
        $this->count++;
        break;
      }
    }
  }

  /**
   * {@inheritdoc}
   */
  public function key() {
    return $this->key;
  }

  /**
   * {@inheritdoc}
   */
  public function valid() {
    return ($this->current == $this->key());
  }

  /**
   * {@inheritdoc}
   */
  public function rewind() {
    $this->key = 2;
    $this->current = 2;
  }

  /**
   * Count elements of an object.
   *
   * @return int
   *   The number of element.
   */
  public function count() {
    return count($this->toArray());
  }

  /**
   * Convert the iterator into an array.
   *
   * @return array
   *   The elements.
   */
  public function toArray() {
    $data = array();

    for ($this->rewind(); $this->valid(); $this->next()) {
      $data[] = $this->current();
    }

    return $data;
  }

  /**
   * Test if a number is perfect or not.
   *
   * Source: http://iceyboard.no-ip.org/projects/code/php/perfect_number/
   *
   * @param int $number
   *   The number to test.
   *
   * @return bool
   *   The true if the number is perfect, false otherwise.
   */
  protected function isPerfectNumber($number) {
    $d = 0;

    $max = sqrt($number);
    for ($n = 2; $n <= $max; $n++) {
      if (!($number % $n)) {
        $d += $n;
        if ($n <> $number / $n) {
          $d += $number / $n;
        }
      }
    }

    return ++$d == $number;
  }

  /**
   * Set the maximum limit.
   *
   * @param int $max
   *   The limit.
   */
  public function setMaxLimit($max) {
    $this->max = $max;
  }

  /**
   * Get the maximum limit.
   *
   * @return int
   *   The limit.
   */
  public function getMaxLimit() {
    return intval($this->max);
  }

}


1			<?php
2
3			namespace drupol\phpermutations\Iterators;
4
5			use drupol\phpermutations\Combinatorics;
6
7			/**
8			* Class Perfect.
9			*
10			* @package drupol\phpermutations\Iterators
11			*/
12			class Perfect extends Combinatorics implements \Iterator, \Countable {
13
14			/**
15			* The maximum limit.
16			*
17			* @var int
18			*/
19			protected $max;
20
21			/**
22			* The key.
23			*
24			* @var int
25			*/
26			protected $key;
27
28			/**
29			* The count.
30			*
31			* @var int
32			*/
33			protected $count = 1;
34
35			/**
36			* The default current value.
37			*
38			* @var int
39			*/
40			protected $current = 2;
41
42			/**
43			* Perfect constructor.
44			*/
45	2		public function __construct() {
46	2		$this->setMaxLimit(PHP_INT_MAX);
47	2		}
48
49			/**
50			* {@inheritdoc}
51			*/
52	2		public function current() {
53	2		return $this->current;
54			}
55
56			/**
57			* {@inheritdoc}
58			*/
59	2	View Code Duplication	public function next() {
			0 ignored issues – show Duplication introduced 2017-01-02 06:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60	2		++$this->key;
61	2		for ($i = $this->key; $i < $this->getMaxLimit(); $i++) {
62	2		if ($this->isPerfectNumber($i)) {
63	2		$this->key = $i;
64	2		$this->current = $i;
65	2		$this->count++;
66	2		break;
67			}
68	2		}
69	2		}
70
71			/**
72			* {@inheritdoc}
73			*/
74	2		public function key() {
75	2		return $this->key;
76			}
77
78			/**
79			* {@inheritdoc}
80			*/
81	2		public function valid() {
82	2		return ($this->current == $this->key());
83			}
84
85			/**
86			* {@inheritdoc}
87			*/
88	2		public function rewind() {
89	2		$this->key = 2;
90	2		$this->current = 2;
91	2		}
92
93			/**
94			* Count elements of an object.
95			*
96			* @return int
97			* The number of element.
98			*/
99	2		public function count() {
100	2		return count($this->toArray());
101			}
102
103			/**
104			* Convert the iterator into an array.
105			*
106			* @return array
107			* The elements.
108			*/
109	2		public function toArray() {
110	2		$data = array();
111
112	2		for ($this->rewind(); $this->valid(); $this->next()) {
113	2		$data[] = $this->current();
114	2		}
115
116	2		return $data;
117			}
118
119			/**
120			* Test if a number is perfect or not.
121			*
122			* Source: http://iceyboard.no-ip.org/projects/code/php/perfect_number/
123			*
124			* @param int $number
125			* The number to test.
126			*
127			* @return bool
128			* The true if the number is perfect, false otherwise.
129			*/
130	2		protected function isPerfectNumber($number) {
131	2		$d = 0;
			0 ignored issues – show Comprehensibility introduced 2017-01-02 06:30 UTC by Report Bug Copy Issue Report Avoid variables with short names like $d. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
132	2		$max = sqrt($number);
133	2		for ($n = 2; $n <= $max; $n++) {
134	2		if (!($number % $n)) {
135	2		$d += $n;
136	2		if ($n <> $number / $n) {
137	2		$d += $number / $n;
138	2		}
139	2		}
140	2		}
141
142	2		return ++$d == $number;
143			}
144
145			/**
146			* Set the maximum limit.
147			*
148			* @param int $max
149			* The limit.
150			*/
151	2		public function setMaxLimit($max) {
152	2		$this->max = $max;
153	2		}
154
155			/**
156			* Get the maximum limit.
157			*
158			* @return int
159			* The limit.
160			*/
161	2		public function getMaxLimit() {
162	2		return intval($this->max);
163			}
164
165			}
166

drupol / phpermutations

Push — master ( b11566...550d6f )

Perfect::valid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like