drupol\phpermutations\Iterators\Perfect

Complexity

Total Complexity

17

Size/Duplication

Total Lines	154
Duplicated Lines	7.14 %

Coupling/Cohesion

Dependencies

1

Test Coverage

Coverage

100%

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	current()	0	3	1
A	next()	11	11	3
A	key()	0	3	1
A	valid()	0	3	1
A	rewind()	0	4	1
A	count()	0	3	1
A	toArray()	0	9	2
A	isPerfectNumber()	0	14	4
A	setMaxLimit()	0	3	1
A	getMaxLimit()	0	3	1

<?php

namespace drupol\phpermutations\Iterators;

use drupol\phpermutations\Combinatorics;

/**
 * Class Perfect.
 *
 * @package drupol\phpermutations\Iterators
 */
class Perfect extends Combinatorics implements \Iterator, \Countable {

  /**
   * The maximum limit.
   *
   * @var int
   */
  protected $max;

  /**
   * The key.
   *
   * @var int
   */
  protected $key;

  /**
   * The count.
   *
   * @var int
   */
  protected $count = 1;

  /**
   * The default current value.
   *
   * @var int
   */
  protected $current = 2;

  /**
   * Perfect constructor.
   */
  public function __construct() {
    $this->setMaxLimit(PHP_INT_MAX);
  }

  /**
   * {@inheritdoc}
   */
  public function current() {
    return $this->current;
  }

  /**
   * {@inheritdoc}
   */
  public function next() {

This method seems to be duplicated in your project.

    ++$this->key;
    for ($i = $this->key; $i < $this->getMaxLimit(); $i++) {
      if ($this->isPerfectNumber($i)) {
        $this->key = $i;
        $this->current = $i;
        $this->count++;
        break;
      }
    }
  }

  /**
   * {@inheritdoc}
   */
  public function key() {
    return $this->key;
  }

  /**
   * {@inheritdoc}
   */
  public function valid() {
    return ($this->current == $this->key());
  }

  /**
   * {@inheritdoc}
   */
  public function rewind() {
    $this->key = 2;
    $this->current = 2;
  }

  /**
   * Count elements of an object.
   *
   * @return int
   *   The number of element.
   */
  public function count() {
    return count($this->toArray());
  }

  /**
   * Convert the iterator into an array.
   *
   * @return array
   *   The elements.
   */
  public function toArray() {
    $data = array();

    for ($this->rewind(); $this->valid(); $this->next()) {
      $data[] = $this->current();
    }

    return $data;
  }

  /**
   * Test if a number is perfect or not.
   *
   * Source: http://iceyboard.no-ip.org/projects/code/php/perfect_number/
   *
   * @param int $number
   *   The number to test.
   *
   * @return bool
   *   The true if the number is perfect, false otherwise.
   */
  protected function isPerfectNumber($number) {
    $d = 0;

Avoid variables with short names like $d. Configured minimum length is 3.

    $max = sqrt($number);
    for ($n = 2; $n <= $max; $n++) {
      if (!($number % $n)) {
        $d += $n;
        if ($n <> $number / $n) {
          $d += $number / $n;
        }
      }
    }

    return ++$d == $number;
  }

  /**
   * Set the maximum limit.
   *
   * @param int $max
   *   The limit.
   */
  public function setMaxLimit($max) {
    $this->max = $max;
  }

  /**
   * Get the maximum limit.
   *
   * @return int
   *   The limit.
   */
  public function getMaxLimit() {
    return intval($this->max);
  }

}