drupal-media / entity_browser

src/Plugin/EntityBrowser/Display/Modal.php

Doc Comments +1 added lines, -1 removed lines

@@ -279,7 +279,7 @@
   /**
    * Helper function to return commands to return in AjaxResponse.
    *
-   * @return array
+   * @return SelectEntitiesCommand[]
    *   An array of ajax commands.
    */
   public function getAjaxCommands(FormStateInterface $form_state) {

Unused Use Statements -2 removed lines

@@ -12,7 +12,6 @@ 
 use Drupal\Core\Entity\EntityInterface;
 use Drupal\Core\Routing\RouteMatchInterface;
 use Drupal\Core\Url;
-use Drupal\entity_browser\DisplayAjaxInterface;
 use Drupal\entity_browser\DisplayBase;
 use Drupal\entity_browser\DisplayRouterInterface;
 use Drupal\entity_browser\Events\Events;
@@ -21,7 +20,6 @@ 
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Drupal\Core\Path\CurrentPathStack;
 use Drupal\Core\Ajax\AjaxResponse;
-use Drupal\Core\Ajax\CloseDialogCommand;
 use Drupal\entity_browser\Ajax\SelectEntitiesCommand;
 use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
 use Symfony\Component\HttpKernel\KernelEvents;

Indentation +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
    */
   protected $uuid = NULL;
 
- /**
+  /**
    * Current request.
    *
    * @var \Symfony\Component\HttpFoundation\Request

Spacing +8 added lines, -8 removed lines

@@ -138,13 +138,13 @@ 
     // info.
     $event_object = new RegisterJSCallbacks($this->configuration['entity_browser_id'], $uuid);
     $event_object->registerCallback('Drupal.entityBrowser.selectionCompleted');
-    $event = $this->eventDispatcher->dispatch(Events::REGISTER_JS_CALLBACKS, $event_object );
+    $event = $this->eventDispatcher->dispatch(Events::REGISTER_JS_CALLBACKS, $event_object);
     $original_path = $this->currentPath->getPath();
     return [
       '#theme_wrappers' => ['container'],
       'path' => [
         '#type' => 'hidden',
-        '#value' => Url::fromRoute('entity_browser.' . $this->configuration['entity_browser_id'], [], [
+        '#value' => Url::fromRoute('entity_browser.'.$this->configuration['entity_browser_id'], [], [
           'query' => [
             'uuid' => $uuid,
             'original_path' => $original_path,
@@ -156,7 +156,7 @@ 
         '#value' => $this->configuration['link_text'],
         '#limit_validation_errors' => [],
         '#submit' => [],
-        '#name' => 'op_' . $this->configuration['entity_browser_id'],
+        '#name' => 'op_'.$this->configuration['entity_browser_id'],
         '#ajax' => [
           'callback' => [$this, 'openModal'],
           'event' => 'click',
@@ -165,7 +165,7 @@ 
           'data-uuid' => $uuid,
         ],
         '#attached' => [
-          'library' => ['core/drupal.dialog.ajax',  'entity_browser/modal'],
+          'library' => ['core/drupal.dialog.ajax', 'entity_browser/modal'],
           'drupalSettings' => [
             'entity_browser' => [
               'modal' => [
@@ -285,7 +285,7 @@ 
    *   An array of ajax commands.
    */
   public function getAjaxCommands(FormStateInterface $form_state) {
-    $entities = array_map(function(EntityInterface $item) {return [$item->id(), $item->uuid(), $item->getEntityTypeId()];}, $form_state->get(['entity_browser', 'selected_entities']));
+    $entities = array_map(function(EntityInterface $item) {return [$item->id(), $item->uuid(), $item->getEntityTypeId()]; }, $form_state->get(['entity_browser', 'selected_entities']));
 
     $commands = array();
     $commands[] = new SelectEntitiesCommand($this->uuid, $entities);
@@ -305,13 +305,13 @@ 
   public function propagateSelection(FilterResponseEvent $event) {
     $render = [
       'labels' => [
-        '#markup' => 'Labels: ' . implode(', ', array_map(function (EntityInterface $item) {return $item->label();}, $this->entities)),
+        '#markup' => 'Labels: '.implode(', ', array_map(function(EntityInterface $item) {return $item->label(); }, $this->entities)),
         '#attached' => [
           'library' => ['entity_browser/modal_selection'],
           'drupalSettings' => [
             'entity_browser' => [
               'modal' => [
-                'entities' => array_map(function (EntityInterface $item) {return [$item->id(), $item->uuid(), $item->getEntityTypeId()];}, $this->entities),
+                'entities' => array_map(function(EntityInterface $item) {return [$item->id(), $item->uuid(), $item->getEntityTypeId()]; }, $this->entities),
                 'uuid' => $this->request->query->get('uuid'),
               ],
             ],
@@ -327,7 +327,7 @@ 
    * {@inheritdoc}
    */
   public function path() {
-    return '/entity-browser/modal/' . $this->configuration['entity_browser_id'];
+    return '/entity-browser/modal/'.$this->configuration['entity_browser_id'];
   }
 
   /**

src/Plugin/Field/FieldWidget/EntityReference.php

Doc Comments -2 removed lines

@@ -54,8 +54,6 @@
   /**
    * Constructs widget plugin.
    *
-   * @param array $configuration
-   *   A configuration array containing information about the plugin instance.
    * @param string $plugin_id
    *   The plugin_id for the plugin instance.
    * @param mixed $plugin_definition

Indentation +2 added lines, -3 removed lines

@@ -24,7 +24,6 @@ 
 
 /**
  * Plugin implementation of the 'entity_reference' widget for entity browser.
-
  * @FieldWidget(
  *   id = "entity_browser_entity_reference",
  *   label = @Translation("Entity browser"),
@@ -174,8 +173,8 @@ 
   }
 
     /**
-   * {@inheritdoc}
-   */
+     * {@inheritdoc}
+     */
   public function settingsSummary() {
     $summary = [];
     $entity_browser_id = $this->getSetting('entity_browser');

Spacing +6 added lines, -6 removed lines

@@ -128,7 +128,7 @@ 
       $displays[$id] = $definition['label'];
     }
 
-    $id = Html::getUniqueId('field-' . $this->fieldDefinition->getName() . '-display-settings-wrapper');
+    $id = Html::getUniqueId('field-'.$this->fieldDefinition->getName().'-display-settings-wrapper');
     $element['field_widget_display'] = [
       '#title' => t('Entity display plugin'),
       '#type' => 'select',
@@ -144,7 +144,7 @@ 
       '#type' => 'fieldset',
       '#title' => t('Entity display plugin configuration'),
       '#tree' => TRUE,
-      '#prefix' => '<div id="' . $id . '">',
+      '#prefix' => '<div id="'.$id.'">',
       '#suffix' => '</div>',
     ];
 
@@ -218,7 +218,7 @@ 
       }
       // Submit was triggered by one of the "Remove" buttons. We need to walk
       // few levels up to read value of "target_id" element.
-      elseif ($trigger['#type'] == 'submit' && strpos($trigger['#name'], $this->fieldDefinition->getName() . '_remove_') === 0) {
+      elseif ($trigger['#type'] == 'submit' && strpos($trigger['#name'], $this->fieldDefinition->getName().'_remove_') === 0) {
         $parents = array_merge(array_slice($trigger['#parents'], 0, -4), ['target_id']);
       }
 
@@ -241,8 +241,8 @@ 
     }
     $ids = array_filter($ids);
 
-    $hidden_id = Html::getUniqueId('edit-' . $this->fieldDefinition->getName() . '-target-id');
-    $details_id = Html::getUniqueId('edit-' . $this->fieldDefinition->getName());
+    $hidden_id = Html::getUniqueId('edit-'.$this->fieldDefinition->getName().'-target-id');
+    $details_id = Html::getUniqueId('edit-'.$this->fieldDefinition->getName());
     /** @var \Drupal\entity_browser\EntityBrowserInterface $entity_browser */
     $entity_browser = $this->entityManager->getStorage('entity_browser')->load($this->getSetting('entity_browser'));
 
@@ -307,7 +307,7 @@ 
                 'wrapper' => $details_id,
               ],
               '#submit' => [[get_class($this), 'removeItemSubmit']],
-              '#name' => $this->fieldDefinition->getName() . '_remove_' . $id,
+              '#name' => $this->fieldDefinition->getName().'_remove_'.$id,
               '#limit_validation_errors' => [array_merge($field_parents, [$this->fieldDefinition->getName()])],
               '#attributes' => ['data-entity-id' => $id],
             ]

Braces +2 added lines, -4 removed lines

@@ -183,8 +183,7 @@ 
 
     if (empty($entity_browser_id)) {
       return [t('No entity browser selected.')];
-    }
-    else {
+    } else {
       $browser = $this->entityManager->getStorage('entity_browser')
         ->load($entity_browser_id);
       $summary[] = t('Entity browser: @browser', ['@browser' => $browser->label()]);
@@ -355,8 +354,7 @@ 
     // information to return correct part of the form.
     if (!empty($trigger['#ajax']['event']) && $trigger['#ajax']['event'] == 'entity_browser_value_updated') {
       $parents = array_slice($trigger['#array_parents'], 0, -2);
-    }
-    elseif ($trigger['#type'] == 'submit' && strpos($trigger['#name'], '_remove_')) {
+    } elseif ($trigger['#type'] == 'submit' && strpos($trigger['#name'], '_remove_')) {
       $parents = array_slice($trigger['#array_parents'], 0, -4);
     }
 

Unused Use Statements -2 removed lines

@@ -16,8 +16,6 @@
 use Drupal\Core\Field\WidgetBase;
 use Drupal\Core\Form\FormStateInterface;
 use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
-use Drupal\entity_browser\Events\Events;
-use Drupal\entity_browser\Events\RegisterJSCallbacks;
 use Drupal\entity_browser\FieldWidgetDisplayManager;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;

src/Plugin/views/display/EntityBrowser.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 
 namespace Drupal\entity_browser\Plugin\views\display;
 
-use Drupal\Core\DependencyInjection\DependencySerializationTrait;
 use Drupal\views\Plugin\views\display\DisplayPluginBase;
 
 /**

Spacing +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         $form_element_row_id = $row_id;
 
         $substitutions[] = [
-          'placeholder' => '<!--form-item-entity_browser_select--' . $form_element_row_id . '-->',
+          'placeholder' => '<!--form-item-entity_browser_select--'.$form_element_row_id.'-->',
           'field_name' => 'entity_browser_select',
           'row_id' => $form_element_row_id,
         ];

src/Plugin/views/field/SelectForm.php

Doc Comments -4 removed lines

@@ -45,10 +45,6 @@
   /**
    * Form constructor for the bulk form.
    *
-   * @param array $form
-   *   An associative array containing the structure of the form.
-   * @param \Drupal\Core\Form\FormStateInterface $form_state
-   *   The current state of the form.
    */
   public function viewsForm(&$render) {
     // Only add the bulk form options and buttons if there are results.

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
    * {@inheritdoc}
    */
   public function render(ResultRow $values) {
-    return ViewsRenderPipelineMarkup::create('<!--form-item-' . $this->options['id'] . '--' . $values->index . '-->');
+    return ViewsRenderPipelineMarkup::create('<!--form-item-'.$this->options['id'].'--'.$values->index.'-->');
   }
 
   /**

src/Entity/EntityBrowser.php

Spacing +1 added lines, -1 removed lines

@@ -336,7 +336,7 @@
           '_title_callback' => 'Drupal\entity_browser\Controllers\StandalonePage::title',
           'entity_browser_id' => $this->id(),
         ],
-        ['_permission' => 'access ' . $this->id() . ' entity browser pages'],
+        ['_permission' => 'access '.$this->id().' entity browser pages'],
         ['_admin_route' => \Drupal::config('node.settings')->get('use_admin_theme')]
       );
     }

src/Form/EntityBrowserForm.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
    * {@inheritdoc}
    */
   public function getFormId() {
-    return 'entity_browser_' . $this->entity->id() . '_form';
+    return 'entity_browser_'.$this->entity->id().'_form';
   }
 
   /**

Braces +1 added lines, -2 removed lines

@@ -116,8 +116,7 @@
 
     if (!$this->isSelectionCompleted($form_state)) {
       $form_state->setRebuild();
-    }
-    else {
+    } else {
       $entity_browser->getDisplay()->selectionCompleted($this->getSelectedEntities($form_state));
     }
   }

src/Permissions.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
 
     foreach ($browsers as $browser) {
       if ($browser->route()) {
-        $permissions['access ' . $browser->id() . ' entity browser pages'] = array(
+        $permissions['access '.$browser->id().' entity browser pages'] = array(
           'title' => $this->translationManager->translate('Access @name pages', array('@name' => $browser->label())),
           'description' => $this->translationManager->translate('Access pages that %browser uses to operate.', array('%browser' => $browser->label())),
         );

src/Plugin/EntityBrowser/SelectionDisplay/View.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
     // them only once. Reason for that is how SQL and Views work and we probably
     // can't do much about it.
     if (!empty($this->selectedEntities)) {
-      $ids = array_map(function(EntityInterface $item) {return $item->id();}, $this->selectedEntities);
+      $ids = array_map(function(EntityInterface $item) {return $item->id(); }, $this->selectedEntities);
       $storage['selection_display_view']->setArguments([implode(',', $ids)]);
     }
 

src/Plugin/EntityBrowser/Widget/Upload.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     $uploaded_files = $form_state->getValue(['upload'], []);
     $trigger = $form_state->getTriggeringElement();
     // Only validate if we are uploading a file.
-    if (empty($uploaded_files)  && $trigger['#value'] == 'Upload') {
+    if (empty($uploaded_files) && $trigger['#value'] == 'Upload') {
       $form_state->setError($form['widget']['upload'], t('At least one file should be uploaded.'));
     }
   }