Completed
Pull Request — 8.x-1.x (#126)
by Janez
02:06
created
src/EntityBrowserInterface.php 2 patches
Doc Comments   -4 removed lines patch added patch discarded remove patch
@@ -59,8 +59,6 @@  discard block
 block discarded – undo
59 59
   /**
60 60
    * Sets the id of the widget selector plugin
61 61
    *
62
-   * @param string $display
63
-   *   The id of the widget selector plugin.
64 62
    *
65 63
    * @return \Drupal\entity_browser\EntityBrowserInterface
66 64
    *   The class instance this method is called on.
@@ -70,8 +68,6 @@  discard block
 block discarded – undo
70 68
   /**
71 69
    * Sets the id of the selection display plugin
72 70
    *
73
-   * @param string $display
74
-   *   The id of the selection display plugin.
75 71
    *
76 72
    * @return \Drupal\entity_browser\EntityBrowserInterface
77 73
    *   The class instance this method is called on.
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 namespace Drupal\entity_browser;
9 9
 
10 10
 use Drupal\Core\Config\Entity\ConfigEntityInterface;
11
-use Drupal\Core\Form\FormStateInterface;
12 11
 
13 12
 /**
14 13
  * Provides an interface defining an entity browser entity.
Please login to merge, or discard this patch.
src/Form/WidgetsConfig.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     $form['widget'] = [
76 76
       '#type' => 'select',
77 77
       '#title' => $this->t('Add widget plugin'),
78
-      '#options' => ['_none_' => '- ' . $this->t('Select a widget to add it') . ' -'] + $widgets,
78
+      '#options' => ['_none_' => '- '.$this->t('Select a widget to add it').' -'] + $widgets,
79 79
       '#ajax' => [
80 80
         'callback' => [get_class($this), 'addWidgetCallback'],
81 81
         'wrapper' => 'widgets',
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
       $row['remove'] = [
126 126
         '#type' => 'submit',
127 127
         '#value' => $this->t('Delete'),
128
-        '#name' => 'remove' . $uuid,
128
+        '#name' => 'remove'.$uuid,
129 129
         '#ajax' => [
130 130
           'callback' => [get_class($this), 'addWidgetCallback'],
131 131
           'wrapper' => 'widgets',
Please login to merge, or discard this patch.
src/Form/GeneralInfoConfig.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 use Drupal\entity_browser\SelectionDisplayManager;
14 14
 use Drupal\entity_browser\WidgetManager;
15 15
 use Drupal\entity_browser\WidgetSelectorManager;
16
-use Drupal\user\SharedTempStoreFactory;
17 16
 use Symfony\Component\DependencyInjection\ContainerInterface;
18 17
 
19 18
 /**
Please login to merge, or discard this patch.
src/Tests/ConfigUITest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -137,24 +137,24 @@
 block discarded – undo
137 137
     $this->assertOptionSelected('edit-widget-selector', 'tabs', 'Correct widget selector selected.');
138 138
     $this->assertOptionSelected('edit-selection-display', 'no_display', 'Correct selection display selected.');
139 139
 
140
-    $this->drupalPostForm(NULL,[], 'Next');
140
+    $this->drupalPostForm(NULL, [], 'Next');
141 141
     $this->assertUrl('/admin/config/content/entity_browser/test_entity_browser/display', ['query' => ['js' => 'nojs']]);
142 142
     $this->assertFieldById('edit-width', '100', 'Correct value for width found.');
143 143
     $this->assertFieldById('edit-height', '100', 'Correct value for height found.');
144 144
     $this->assertFieldById('edit-link-text', 'All animals are created equal', 'Correct value for link text found.');
145 145
     $this->assertFieldChecked('edit-auto-open', 'Auto open is enabled.');
146 146
 
147
-    $this->drupalPostForm(NULL,[], 'Next');
147
+    $this->drupalPostForm(NULL, [], 'Next');
148 148
     $this->assertUrl('/admin/config/content/entity_browser/test_entity_browser/widget_selector', ['query' => ['js' => 'nojs']]);
149 149
 
150
-    $this->drupalPostForm(NULL,[], 'Next');
150
+    $this->drupalPostForm(NULL, [], 'Next');
151 151
     $this->assertUrl('/admin/config/content/entity_browser/test_entity_browser/selection_display', ['query' => ['js' => 'nojs']]);
152 152
 
153
-    $this->drupalPostForm(NULL,[], 'Next');
154
-    $this->assertFieldById('edit-table-' . $uuid . '-label', 'upload', 'Correct value for widget label found.');
155
-    $this->assertFieldById('edit-table-' . $uuid . '-form-upload-location', 'public://', 'Correct value for upload location found.');
153
+    $this->drupalPostForm(NULL, [], 'Next');
154
+    $this->assertFieldById('edit-table-'.$uuid.'-label', 'upload', 'Correct value for widget label found.');
155
+    $this->assertFieldById('edit-table-'.$uuid.'-form-upload-location', 'public://', 'Correct value for upload location found.');
156 156
 
157
-    $this->drupalPostForm(NULL,[], 'Finish');
157
+    $this->drupalPostForm(NULL, [], 'Finish');
158 158
 
159 159
     $this->drupalLogout();
160 160
     $this->drupalGet('/admin/config/content/entity_browser/test_entity_browser/general');
Please login to merge, or discard this patch.