Completed
Push — 8.x-1.x ( 729d7d...e0281d )
by Janez
02:47
created
src/WidgetBase.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -276,7 +276,7 @@
 block discarded – undo
276 276
   /**
277 277
    * Run widget validators.
278 278
    *
279
-   * @param array $entities
279
+   * @param \Drupal\Core\Entity\EntityInterface[] $entities
280 280
    *   Array of entity ids to validate.
281 281
    * @param array $validators
282 282
    *   Array of widget validator ids.
Please login to merge, or discard this patch.
src/Tests/ConfigUITest.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -139,9 +139,9 @@  discard block
 block discarded – undo
139 139
     $xpath = new \DOMXPath($dom);
140 140
     foreach ($commands as $command) {
141 141
       if ($command['command'] == 'insert' && $command['method'] == 'replaceWith') {
142
-        $wrapperNode = $xpath->query('//*[@id="' . ltrim($command['selector'], '#') . '"]')->item(0);
142
+        $wrapperNode = $xpath->query('//*[@id="'.ltrim($command['selector'], '#').'"]')->item(0);
143 143
         $newDom = new \DOMDocument();
144
-        @$newDom->loadHTML('<div>' . $command['data'] . '</div>');
144
+        @$newDom->loadHTML('<div>'.$command['data'].'</div>');
145 145
         $newNode = @$dom->importNode($newDom->documentElement->firstChild->firstChild, TRUE);
146 146
         $wrapperNode->parentNode->replaceChild($newNode, $wrapperNode);
147 147
         $content = $dom->saveHTML();
@@ -232,14 +232,14 @@  discard block
 block discarded – undo
232 232
     $this->assertUrl('/admin/config/content/entity_browser/test_entity_browser/selection_display', ['query' => ['js' => 'nojs']]);
233 233
 
234 234
     $this->drupalPostForm(NULL, [], 'Next');
235
-    $this->assertFieldById('edit-table-' . $first_uuid . '-label', 'upload', 'Correct value for widget label found.');
236
-    $this->assertFieldById('edit-table-' . $first_uuid . '-form-upload-location', 'public://', 'Correct value for upload location found.');
237
-    $this->assertFieldByXPath("//input[@data-drupal-selector='edit-table-" . $first_uuid . "-form-submit-text']", 'Select files', 'Correct value for submit text found.');
238
-    $this->assertFieldById('edit-table-' . $second_uuid . '-label', 'entity_form', 'Correct value for widget label found.');
239
-    $this->assertOptionSelectedWithDrupalSelector('edit-table-' . $second_uuid . '-form-entity-type', 'user', 'Correct value for entity type found.');
240
-    $this->assertOptionSelectedWithDrupalSelector('edit-table-' . $second_uuid . '-form-bundle-select', 'user', 'Correct value for bundle found.');
241
-    $this->assertOptionSelectedWithDrupalSelector('edit-table-' . $second_uuid . '-form-form-mode-form-select', 'register', 'Correct value for form modes found.');
242
-    $this->assertFieldByXPath("//input[@data-drupal-selector='edit-table-" . $second_uuid . "-form-submit-text']", 'But some are more equal than others', 'Correct value for submit text found.');
235
+    $this->assertFieldById('edit-table-'.$first_uuid.'-label', 'upload', 'Correct value for widget label found.');
236
+    $this->assertFieldById('edit-table-'.$first_uuid.'-form-upload-location', 'public://', 'Correct value for upload location found.');
237
+    $this->assertFieldByXPath("//input[@data-drupal-selector='edit-table-".$first_uuid."-form-submit-text']", 'Select files', 'Correct value for submit text found.');
238
+    $this->assertFieldById('edit-table-'.$second_uuid.'-label', 'entity_form', 'Correct value for widget label found.');
239
+    $this->assertOptionSelectedWithDrupalSelector('edit-table-'.$second_uuid.'-form-entity-type', 'user', 'Correct value for entity type found.');
240
+    $this->assertOptionSelectedWithDrupalSelector('edit-table-'.$second_uuid.'-form-bundle-select', 'user', 'Correct value for bundle found.');
241
+    $this->assertOptionSelectedWithDrupalSelector('edit-table-'.$second_uuid.'-form-form-mode-form-select', 'register', 'Correct value for form modes found.');
242
+    $this->assertFieldByXPath("//input[@data-drupal-selector='edit-table-".$second_uuid."-form-submit-text']", 'But some are more equal than others', 'Correct value for submit text found.');
243 243
 
244 244
     $this->drupalPostForm(NULL, [], 'Finish');
245 245
 
Please login to merge, or discard this patch.
src/Tests/EntityBrowserUpdateHookTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@  discard block
 block discarded – undo
16 16
    */
17 17
   protected function setDatabaseDumpFiles() {
18 18
     $this->databaseDumpFiles = [
19
-      DRUPAL_ROOT . '/core/modules/system/tests/fixtures/update/drupal-8.bare.standard.php.gz',
20
-      __DIR__ . '/../../tests/fixtures/update/entity_browser.update-hook-test.php',
19
+      DRUPAL_ROOT.'/core/modules/system/tests/fixtures/update/drupal-8.bare.standard.php.gz',
20
+      __DIR__.'/../../tests/fixtures/update/entity_browser.update-hook-test.php',
21 21
     ];
22 22
   }
23 23
 
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
       ->get('entity_browser.browser.test_update');
53 53
 
54 54
     $this->assertNull($browser->get('submit_text'), 'Old submit text is gone');
55
-    $this->assertEqual($browser->get('widgets.a4ad947c-9669-497c-9988-24351955a02f.settings.submit_text'), 'All animals are created equal','New submit text appears on the widget.');
55
+    $this->assertEqual($browser->get('widgets.a4ad947c-9669-497c-9988-24351955a02f.settings.submit_text'), 'All animals are created equal', 'New submit text appears on the widget.');
56 56
   }
57 57
 
58 58
 }
Please login to merge, or discard this patch.