Inspection of "Обработка ошибок AmoCRM в теле ответа" - dotzero/amocrm-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#72)

unknown

created 2018-11-09 13:14 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -99,7 +99,7 @@
 block discarded – undo
         $response = $this->postRequest('/private/api/v2/json/pipelines/set', $parameters);
 
         if (isset($response['pipelines']['add']['pipelines'])) {
-            $result = array_map(function ($item) {
+            $result = array_map(function($item) {
                 return $item['id'];
             }, $response['pipelines']['add']['pipelines']);
         } else {

Please login to merge, or discard this patch.

src/Models/CustomersPeriods.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -75,7 +75,7 @@
 block discarded – undo
         $response = $this->postRequest('/private/api/v2/json/customers_periods/set', $parameters);
 
         if (isset($response['customers_periods']['set'])) {
-            $result = array_map(function ($item) {
+            $result = array_map(function($item) {
                 return $item['id'];
             }, $response['customers_periods']['set']);
         } else {

Please login to merge, or discard this patch.

src/Models/Company.php 3 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -86,12 +86,12 @@
 block discarded – undo
 
         if (isset($response['contacts']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+                if(!empty($item['id']))
+                    return $item['id'];
+                elseif(!empty($item['error']))
+                    throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+                else
+                    return [];
             }, $response['contacts']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -86,10 +86,10 @@
 block discarded – undo
 
         if (isset($response['contacts']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
+				if (!empty($item['id']))
 					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				elseif (!empty($item['error']))
+					throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
 				else
 					return [];
             }, $response['contacts']['add']);

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -86,12 +86,13 @@
 block discarded – undo
 
         if (isset($response['contacts']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['contacts']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Task.php 3 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -112,12 +112,12 @@
 block discarded – undo
 
         if (isset($response['tasks']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+                if(!empty($item['id']))
+                    return $item['id'];
+                elseif(!empty($item['error']))
+                    throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+                else
+                    return [];
             }, $response['tasks']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -112,10 +112,10 @@
 block discarded – undo
 
         if (isset($response['tasks']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
+				if (!empty($item['id']))
 					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				elseif (!empty($item['error']))
+					throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
 				else
 					return [];
             }, $response['tasks']['add']);

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -112,12 +112,13 @@
 block discarded – undo
 
         if (isset($response['tasks']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['tasks']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Customer.php 3 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -81,12 +81,12 @@
 block discarded – undo
 
         if (isset($response['customers']['add'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+                if(!empty($item['id']))
+                    return $item['id'];
+                elseif(!empty($item['error']))
+                    throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+                else
+                    return [];
             }, $response['customers']['add']['customers']);
         } else {
             return [];

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -80,11 +80,11 @@
 block discarded – undo
         $response = $this->postRequest('/private/api/v2/json/customers/set', $parameters);
 
         if (isset($response['customers']['add'])) {
-            $result = array_map(function ($item) {
-				if(!empty($item['id']))
+            $result = array_map(function($item) {
+				if (!empty($item['id']))
 					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				elseif (!empty($item['error']))
+					throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
 				else
 					return [];
             }, $response['customers']['add']['customers']);

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -81,12 +81,13 @@
 block discarded – undo
 
         if (isset($response['customers']['add'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['customers']['add']['customers']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Catalog.php 3 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -76,12 +76,12 @@
 block discarded – undo
 
         if (isset($response['catalogs']['add']['catalogs'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+                if(!empty($item['id']))
+                    return $item['id'];
+                elseif(!empty($item['error']))
+                    throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+                else
+                    return [];
             }, $response['catalogs']['add']['catalogs']);
         } else {
             return [];

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -75,11 +75,11 @@
 block discarded – undo
         $response = $this->postRequest('/private/api/v2/json/catalogs/set', $parameters);
 
         if (isset($response['catalogs']['add']['catalogs'])) {
-            $result = array_map(function ($item) {
-				if(!empty($item['id']))
+            $result = array_map(function($item) {
+				if (!empty($item['id']))
 					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				elseif (!empty($item['error']))
+					throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
 				else
 					return [];
             }, $response['catalogs']['add']['catalogs']);

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -76,12 +76,13 @@
 block discarded – undo
 
         if (isset($response['catalogs']['add']['catalogs'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['catalogs']['add']['catalogs']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Note.php 3 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -141,12 +141,12 @@
 block discarded – undo
 
         if (isset($response['notes']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+                if(!empty($item['id']))
+                    return $item['id'];
+                elseif(!empty($item['error']))
+                    throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+                else
+                    return [];
             }, $response['notes']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -141,10 +141,10 @@
 block discarded – undo
 
         if (isset($response['notes']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
+				if (!empty($item['id']))
 					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				elseif (!empty($item['error']))
+					throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
 				else
 					return [];
             }, $response['notes']['add']);

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -141,12 +141,13 @@
 block discarded – undo
 
         if (isset($response['notes']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['notes']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Transaction.php 3 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -80,12 +80,12 @@
 block discarded – undo
 
         if (isset($response['transactions']['add']['transactions'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+                if(!empty($item['id']))
+                    return $item['id'];
+                elseif(!empty($item['error']))
+                    throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+                else
+                    return [];
             }, $response['transactions']['add']['transactions']);
         } else {
             return [];

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -79,11 +79,11 @@
 block discarded – undo
         $response = $this->postRequest('/private/api/v2/json/transactions/set', $parameters);
 
         if (isset($response['transactions']['add']['transactions'])) {
-            $result = array_map(function ($item) {
-				if(!empty($item['id']))
+            $result = array_map(function($item) {
+				if (!empty($item['id']))
 					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				elseif (!empty($item['error']))
+					throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
 				else
 					return [];
             }, $response['transactions']['add']['transactions']);

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -80,12 +80,13 @@
 block discarded – undo
 
         if (isset($response['transactions']['add']['transactions'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['transactions']['add']['transactions']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/CatalogElement.php 3 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -72,12 +72,12 @@
 block discarded – undo
 
         if (isset($response['catalog_elements']['add']['catalog_elements'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+                if(!empty($item['id']))
+                    return $item['id'];
+                elseif(!empty($item['error']))
+                    throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+                else
+                    return [];
             }, $response['catalog_elements']['add']['catalog_elements']);
         } else {
             return [];

Please login to merge, or discard this patch.

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -71,11 +71,11 @@  discard block
 block discarded – undo
         $response = $this->postRequest('/private/api/v2/json/catalog_elements/set', $parameters);
 
         if (isset($response['catalog_elements']['add']['catalog_elements'])) {
-            $result = array_map(function ($item) {
-				if(!empty($item['id']))
+            $result = array_map(function($item) {
+				if (!empty($item['id']))
 					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				elseif (!empty($item['error']))
+					throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
 				else
 					return [];
             }, $response['catalog_elements']['add']['catalog_elements']);
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
      */
     public function apiDeleteBatch(array $ids)
     {
-        array_walk($ids, function($id){
+        array_walk($ids, function($id) {
             $this->checkId($id);
         });
 

Please login to merge, or discard this patch.

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -72,12 +72,13 @@
 block discarded – undo
 
         if (isset($response['catalog_elements']['add']['catalog_elements'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['catalog_elements']['add']['catalog_elements']);
         } else {
             return [];

Please login to merge, or discard this patch.

		@@ -99,7 +99,7 @@
		block discarded – undo
99	99	$response = $this->postRequest('/private/api/v2/json/pipelines/set', $parameters);
100	100
101	101	if (isset($response['pipelines']['add']['pipelines'])) {
102		- $result = array_map(function ($item) {
	102	+ $result = array_map(function($item) {
103	103	return $item['id'];
104	104	}, $response['pipelines']['add']['pipelines']);
105	105	} else {

		@@ -86,12 +86,12 @@
		block discarded – undo
86	86
87	87	if (isset($response['contacts']['add'])) {
88	88	$result = array_map(function($item) {
89		- if(!empty($item['id']))
90		- return $item['id'];
91		- elseif(!empty($item['error']))
92		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
93		- else
94		- return [];
	89	+ if(!empty($item['id']))
	90	+ return $item['id'];
	91	+ elseif(!empty($item['error']))
	92	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	93	+ else
	94	+ return [];
95	95	}, $response['contacts']['add']);
96	96	} else {
97	97	return [];

		@@ -86,10 +86,10 @@
		block discarded – undo
86	86
87	87	if (isset($response['contacts']['add'])) {
88	88	$result = array_map(function($item) {
89		- if(!empty($item['id']))
	89	+ if (!empty($item['id']))
90	90	return $item['id'];
91		- elseif(!empty($item['error']))
92		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	91	+ elseif (!empty($item['error']))
	92	+ throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
93	93	else
94	94	return [];
95	95	}, $response['contacts']['add']);

		@@ -86,12 +86,13 @@
		block discarded – undo
86	86
87	87	if (isset($response['contacts']['add'])) {
88	88	$result = array_map(function($item) {
89		- if(!empty($item['id']))
90		- return $item['id'];
91		- elseif(!empty($item['error']))
92		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
93		- else
94		- return [];
	89	+ if(!empty($item['id'])) {
	90	+ return $item['id'];
	91	+ } elseif(!empty($item['error'])) {
	92	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	93	+ } else {
	94	+ return [];
	95	+ }
95	96	}, $response['contacts']['add']);
96	97	} else {
97	98	return [];

		@@ -112,12 +112,12 @@
		block discarded – undo
112	112
113	113	if (isset($response['tasks']['add'])) {
114	114	$result = array_map(function($item) {
115		- if(!empty($item['id']))
116		- return $item['id'];
117		- elseif(!empty($item['error']))
118		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
119		- else
120		- return [];
	115	+ if(!empty($item['id']))
	116	+ return $item['id'];
	117	+ elseif(!empty($item['error']))
	118	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	119	+ else
	120	+ return [];
121	121	}, $response['tasks']['add']);
122	122	} else {
123	123	return [];

		@@ -75,7 +75,7 @@
		block discarded – undo
75	75	$response = $this->postRequest('/private/api/v2/json/customers_periods/set', $parameters);
76	76
77	77	if (isset($response['customers_periods']['set'])) {
78		- $result = array_map(function ($item) {
	78	+ $result = array_map(function($item) {
79	79	return $item['id'];
80	80	}, $response['customers_periods']['set']);
81	81	} else {

		@@ -112,10 +112,10 @@
		block discarded – undo
112	112
113	113	if (isset($response['tasks']['add'])) {
114	114	$result = array_map(function($item) {
115		- if(!empty($item['id']))
	115	+ if (!empty($item['id']))
116	116	return $item['id'];
117		- elseif(!empty($item['error']))
118		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	117	+ elseif (!empty($item['error']))
	118	+ throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
119	119	else
120	120	return [];
121	121	}, $response['tasks']['add']);

		@@ -112,12 +112,13 @@
		block discarded – undo
112	112
113	113	if (isset($response['tasks']['add'])) {
114	114	$result = array_map(function($item) {
115		- if(!empty($item['id']))
116		- return $item['id'];
117		- elseif(!empty($item['error']))
118		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
119		- else
120		- return [];
	115	+ if(!empty($item['id'])) {
	116	+ return $item['id'];
	117	+ } elseif(!empty($item['error'])) {
	118	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	119	+ } else {
	120	+ return [];
	121	+ }
121	122	}, $response['tasks']['add']);
122	123	} else {
123	124	return [];

		@@ -81,12 +81,12 @@
		block discarded – undo
81	81
82	82	if (isset($response['customers']['add'])) {
83	83	$result = array_map(function ($item) {
84		- if(!empty($item['id']))
85		- return $item['id'];
86		- elseif(!empty($item['error']))
87		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
88		- else
89		- return [];
	84	+ if(!empty($item['id']))
	85	+ return $item['id'];
	86	+ elseif(!empty($item['error']))
	87	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	88	+ else
	89	+ return [];
90	90	}, $response['customers']['add']['customers']);
91	91	} else {
92	92	return [];

		@@ -80,11 +80,11 @@
		block discarded – undo
80	80	$response = $this->postRequest('/private/api/v2/json/customers/set', $parameters);
81	81
82	82	if (isset($response['customers']['add'])) {
83		- $result = array_map(function ($item) {
84		- if(!empty($item['id']))
	83	+ $result = array_map(function($item) {
	84	+ if (!empty($item['id']))
85	85	return $item['id'];
86		- elseif(!empty($item['error']))
87		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	86	+ elseif (!empty($item['error']))
	87	+ throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
88	88	else
89	89	return [];
90	90	}, $response['customers']['add']['customers']);

		@@ -81,12 +81,13 @@
		block discarded – undo
81	81
82	82	if (isset($response['customers']['add'])) {
83	83	$result = array_map(function ($item) {
84		- if(!empty($item['id']))
85		- return $item['id'];
86		- elseif(!empty($item['error']))
87		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
88		- else
89		- return [];
	84	+ if(!empty($item['id'])) {
	85	+ return $item['id'];
	86	+ } elseif(!empty($item['error'])) {
	87	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	88	+ } else {
	89	+ return [];
	90	+ }
90	91	}, $response['customers']['add']['customers']);
91	92	} else {
92	93	return [];

		@@ -76,12 +76,12 @@
		block discarded – undo
76	76
77	77	if (isset($response['catalogs']['add']['catalogs'])) {
78	78	$result = array_map(function ($item) {
79		- if(!empty($item['id']))
80		- return $item['id'];
81		- elseif(!empty($item['error']))
82		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
83		- else
84		- return [];
	79	+ if(!empty($item['id']))
	80	+ return $item['id'];
	81	+ elseif(!empty($item['error']))
	82	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	83	+ else
	84	+ return [];
85	85	}, $response['catalogs']['add']['catalogs']);
86	86	} else {
87	87	return [];

		@@ -75,11 +75,11 @@
		block discarded – undo
75	75	$response = $this->postRequest('/private/api/v2/json/catalogs/set', $parameters);
76	76
77	77	if (isset($response['catalogs']['add']['catalogs'])) {
78		- $result = array_map(function ($item) {
79		- if(!empty($item['id']))
	78	+ $result = array_map(function($item) {
	79	+ if (!empty($item['id']))
80	80	return $item['id'];
81		- elseif(!empty($item['error']))
82		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	81	+ elseif (!empty($item['error']))
	82	+ throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
83	83	else
84	84	return [];
85	85	}, $response['catalogs']['add']['catalogs']);

		@@ -76,12 +76,13 @@
		block discarded – undo
76	76
77	77	if (isset($response['catalogs']['add']['catalogs'])) {
78	78	$result = array_map(function ($item) {
79		- if(!empty($item['id']))
80		- return $item['id'];
81		- elseif(!empty($item['error']))
82		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
83		- else
84		- return [];
	79	+ if(!empty($item['id'])) {
	80	+ return $item['id'];
	81	+ } elseif(!empty($item['error'])) {
	82	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	83	+ } else {
	84	+ return [];
	85	+ }
85	86	}, $response['catalogs']['add']['catalogs']);
86	87	} else {
87	88	return [];

		@@ -141,12 +141,12 @@
		block discarded – undo
141	141
142	142	if (isset($response['notes']['add'])) {
143	143	$result = array_map(function($item) {
144		- if(!empty($item['id']))
145		- return $item['id'];
146		- elseif(!empty($item['error']))
147		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
148		- else
149		- return [];
	144	+ if(!empty($item['id']))
	145	+ return $item['id'];
	146	+ elseif(!empty($item['error']))
	147	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	148	+ else
	149	+ return [];
150	150	}, $response['notes']['add']);
151	151	} else {
152	152	return [];

		@@ -141,10 +141,10 @@
		block discarded – undo
141	141
142	142	if (isset($response['notes']['add'])) {
143	143	$result = array_map(function($item) {
144		- if(!empty($item['id']))
	144	+ if (!empty($item['id']))
145	145	return $item['id'];
146		- elseif(!empty($item['error']))
147		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	146	+ elseif (!empty($item['error']))
	147	+ throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
148	148	else
149	149	return [];
150	150	}, $response['notes']['add']);

		@@ -141,12 +141,13 @@
		block discarded – undo
141	141
142	142	if (isset($response['notes']['add'])) {
143	143	$result = array_map(function($item) {
144		- if(!empty($item['id']))
145		- return $item['id'];
146		- elseif(!empty($item['error']))
147		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
148		- else
149		- return [];
	144	+ if(!empty($item['id'])) {
	145	+ return $item['id'];
	146	+ } elseif(!empty($item['error'])) {
	147	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	148	+ } else {
	149	+ return [];
	150	+ }
150	151	}, $response['notes']['add']);
151	152	} else {
152	153	return [];

		@@ -80,12 +80,12 @@
		block discarded – undo
80	80
81	81	if (isset($response['transactions']['add']['transactions'])) {
82	82	$result = array_map(function ($item) {
83		- if(!empty($item['id']))
84		- return $item['id'];
85		- elseif(!empty($item['error']))
86		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
87		- else
88		- return [];
	83	+ if(!empty($item['id']))
	84	+ return $item['id'];
	85	+ elseif(!empty($item['error']))
	86	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	87	+ else
	88	+ return [];
89	89	}, $response['transactions']['add']['transactions']);
90	90	} else {
91	91	return [];

		@@ -79,11 +79,11 @@
		block discarded – undo
79	79	$response = $this->postRequest('/private/api/v2/json/transactions/set', $parameters);
80	80
81	81	if (isset($response['transactions']['add']['transactions'])) {
82		- $result = array_map(function ($item) {
83		- if(!empty($item['id']))
	82	+ $result = array_map(function($item) {
	83	+ if (!empty($item['id']))
84	84	return $item['id'];
85		- elseif(!empty($item['error']))
86		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	85	+ elseif (!empty($item['error']))
	86	+ throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
87	87	else
88	88	return [];
89	89	}, $response['transactions']['add']['transactions']);

		@@ -80,12 +80,13 @@
		block discarded – undo
80	80
81	81	if (isset($response['transactions']['add']['transactions'])) {
82	82	$result = array_map(function ($item) {
83		- if(!empty($item['id']))
84		- return $item['id'];
85		- elseif(!empty($item['error']))
86		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
87		- else
88		- return [];
	83	+ if(!empty($item['id'])) {
	84	+ return $item['id'];
	85	+ } elseif(!empty($item['error'])) {
	86	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	87	+ } else {
	88	+ return [];
	89	+ }
89	90	}, $response['transactions']['add']['transactions']);
90	91	} else {
91	92	return [];

		@@ -72,12 +72,12 @@
		block discarded – undo
72	72
73	73	if (isset($response['catalog_elements']['add']['catalog_elements'])) {
74	74	$result = array_map(function ($item) {
75		- if(!empty($item['id']))
76		- return $item['id'];
77		- elseif(!empty($item['error']))
78		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
79		- else
80		- return [];
	75	+ if(!empty($item['id']))
	76	+ return $item['id'];
	77	+ elseif(!empty($item['error']))
	78	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	79	+ else
	80	+ return [];
81	81	}, $response['catalog_elements']['add']['catalog_elements']);
82	82	} else {
83	83	return [];

		@@ -71,11 +71,11 @@ discard block
		block discarded – undo
71	71	$response = $this->postRequest('/private/api/v2/json/catalog_elements/set', $parameters);
72	72
73	73	if (isset($response['catalog_elements']['add']['catalog_elements'])) {
74		- $result = array_map(function ($item) {
75		- if(!empty($item['id']))
	74	+ $result = array_map(function($item) {
	75	+ if (!empty($item['id']))
76	76	return $item['id'];
77		- elseif(!empty($item['error']))
78		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	77	+ elseif (!empty($item['error']))
	78	+ throw new Exception($item['error'], filter_var(mb_strstr($item['error'], ".", true), FILTER_SANITIZE_NUMBER_INT));
79	79	else
80	80	return [];
81	81	}, $response['catalog_elements']['add']['catalog_elements']);
		@@ -161,7 +161,7 @@ discard block
		block discarded – undo
161	161	*/
162	162	public function apiDeleteBatch(array $ids)
163	163	{
164		- array_walk($ids, function($id){
	164	+ array_walk($ids, function($id) {
165	165	$this->checkId($id);
166	166	});
167	167

		@@ -72,12 +72,13 @@
		block discarded – undo
72	72
73	73	if (isset($response['catalog_elements']['add']['catalog_elements'])) {
74	74	$result = array_map(function ($item) {
75		- if(!empty($item['id']))
76		- return $item['id'];
77		- elseif(!empty($item['error']))
78		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
79		- else
80		- return [];
	75	+ if(!empty($item['id'])) {
	76	+ return $item['id'];
	77	+ } elseif(!empty($item['error'])) {
	78	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	79	+ } else {
	80	+ return [];
	81	+ }
81	82	}, $response['catalog_elements']['add']['catalog_elements']);
82	83	} else {
83	84	return [];

dotzero / amocrm-php

Pull Request — master (#72)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch