Inspection of "Обработка ошибок AmoCRM в теле ответа" - dotzero/amocrm-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#72)

unknown

created 2018-11-09 13:14 UTC

Status

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -86,12 +86,13 @@
 block discarded – undo
 
         if (isset($response['contacts']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['contacts']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Task.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -112,12 +112,13 @@
 block discarded – undo
 
         if (isset($response['tasks']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['tasks']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Customer.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -81,12 +81,13 @@
 block discarded – undo
 
         if (isset($response['customers']['add'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['customers']['add']['customers']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Catalog.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -76,12 +76,13 @@
 block discarded – undo
 
         if (isset($response['catalogs']['add']['catalogs'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['catalogs']['add']['catalogs']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Note.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -141,12 +141,13 @@
 block discarded – undo
 
         if (isset($response['notes']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['notes']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Transaction.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -80,12 +80,13 @@
 block discarded – undo
 
         if (isset($response['transactions']['add']['transactions'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['transactions']['add']['transactions']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/CatalogElement.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -72,12 +72,13 @@
 block discarded – undo
 
         if (isset($response['catalog_elements']['add']['catalog_elements'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['catalog_elements']['add']['catalog_elements']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Lead.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -91,12 +91,13 @@
 block discarded – undo
 
         if (isset($response['leads']['add'])) {
             $result = array_map(function($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['leads']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

src/Models/Contact.php 1 patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

@@ -90,12 +90,13 @@
 block discarded – undo
 
         if (isset($response['contacts']['add'])) {
             $result = array_map(function ($item) {
-				if(!empty($item['id']))
-					return $item['id'];
-				elseif(!empty($item['error']))
-					throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
-				else
-					return [];
+				if(!empty($item['id'])) {
+									return $item['id'];
+				} elseif(!empty($item['error'])) {
+									throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
+				} else {
+									return [];
+				}
             }, $response['contacts']['add']);
         } else {
             return [];

Please login to merge, or discard this patch.

		@@ -112,12 +112,13 @@
		block discarded – undo
112	112
113	113	if (isset($response['tasks']['add'])) {
114	114	$result = array_map(function($item) {
115		- if(!empty($item['id']))
116		- return $item['id'];
117		- elseif(!empty($item['error']))
118		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
119		- else
120		- return [];
	115	+ if(!empty($item['id'])) {
	116	+ return $item['id'];
	117	+ } elseif(!empty($item['error'])) {
	118	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	119	+ } else {
	120	+ return [];
	121	+ }
121	122	}, $response['tasks']['add']);
122	123	} else {
123	124	return [];

		@@ -141,12 +141,13 @@
		block discarded – undo
141	141
142	142	if (isset($response['notes']['add'])) {
143	143	$result = array_map(function($item) {
144		- if(!empty($item['id']))
145		- return $item['id'];
146		- elseif(!empty($item['error']))
147		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
148		- else
149		- return [];
	144	+ if(!empty($item['id'])) {
	145	+ return $item['id'];
	146	+ } elseif(!empty($item['error'])) {
	147	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	148	+ } else {
	149	+ return [];
	150	+ }
150	151	}, $response['notes']['add']);
151	152	} else {
152	153	return [];

		@@ -91,12 +91,13 @@
		block discarded – undo
91	91
92	92	if (isset($response['leads']['add'])) {
93	93	$result = array_map(function($item) {
94		- if(!empty($item['id']))
95		- return $item['id'];
96		- elseif(!empty($item['error']))
97		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
98		- else
99		- return [];
	94	+ if(!empty($item['id'])) {
	95	+ return $item['id'];
	96	+ } elseif(!empty($item['error'])) {
	97	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	98	+ } else {
	99	+ return [];
	100	+ }
100	101	}, $response['leads']['add']);
101	102	} else {
102	103	return [];

		@@ -86,12 +86,13 @@
		block discarded – undo
86	86
87	87	if (isset($response['contacts']['add'])) {
88	88	$result = array_map(function($item) {
89		- if(!empty($item['id']))
90		- return $item['id'];
91		- elseif(!empty($item['error']))
92		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
93		- else
94		- return [];
	89	+ if(!empty($item['id'])) {
	90	+ return $item['id'];
	91	+ } elseif(!empty($item['error'])) {
	92	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	93	+ } else {
	94	+ return [];
	95	+ }
95	96	}, $response['contacts']['add']);
96	97	} else {
97	98	return [];

		@@ -81,12 +81,13 @@
		block discarded – undo
81	81
82	82	if (isset($response['customers']['add'])) {
83	83	$result = array_map(function ($item) {
84		- if(!empty($item['id']))
85		- return $item['id'];
86		- elseif(!empty($item['error']))
87		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
88		- else
89		- return [];
	84	+ if(!empty($item['id'])) {
	85	+ return $item['id'];
	86	+ } elseif(!empty($item['error'])) {
	87	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	88	+ } else {
	89	+ return [];
	90	+ }
90	91	}, $response['customers']['add']['customers']);
91	92	} else {
92	93	return [];

		@@ -76,12 +76,13 @@
		block discarded – undo
76	76
77	77	if (isset($response['catalogs']['add']['catalogs'])) {
78	78	$result = array_map(function ($item) {
79		- if(!empty($item['id']))
80		- return $item['id'];
81		- elseif(!empty($item['error']))
82		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
83		- else
84		- return [];
	79	+ if(!empty($item['id'])) {
	80	+ return $item['id'];
	81	+ } elseif(!empty($item['error'])) {
	82	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	83	+ } else {
	84	+ return [];
	85	+ }
85	86	}, $response['catalogs']['add']['catalogs']);
86	87	} else {
87	88	return [];

		@@ -80,12 +80,13 @@
		block discarded – undo
80	80
81	81	if (isset($response['transactions']['add']['transactions'])) {
82	82	$result = array_map(function ($item) {
83		- if(!empty($item['id']))
84		- return $item['id'];
85		- elseif(!empty($item['error']))
86		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
87		- else
88		- return [];
	83	+ if(!empty($item['id'])) {
	84	+ return $item['id'];
	85	+ } elseif(!empty($item['error'])) {
	86	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	87	+ } else {
	88	+ return [];
	89	+ }
89	90	}, $response['transactions']['add']['transactions']);
90	91	} else {
91	92	return [];

		@@ -72,12 +72,13 @@
		block discarded – undo
72	72
73	73	if (isset($response['catalog_elements']['add']['catalog_elements'])) {
74	74	$result = array_map(function ($item) {
75		- if(!empty($item['id']))
76		- return $item['id'];
77		- elseif(!empty($item['error']))
78		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
79		- else
80		- return [];
	75	+ if(!empty($item['id'])) {
	76	+ return $item['id'];
	77	+ } elseif(!empty($item['error'])) {
	78	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	79	+ } else {
	80	+ return [];
	81	+ }
81	82	}, $response['catalog_elements']['add']['catalog_elements']);
82	83	} else {
83	84	return [];

		@@ -90,12 +90,13 @@
		block discarded – undo
90	90
91	91	if (isset($response['contacts']['add'])) {
92	92	$result = array_map(function ($item) {
93		- if(!empty($item['id']))
94		- return $item['id'];
95		- elseif(!empty($item['error']))
96		- throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
97		- else
98		- return [];
	93	+ if(!empty($item['id'])) {
	94	+ return $item['id'];
	95	+ } elseif(!empty($item['error'])) {
	96	+ throw new Exception($item['error'],filter_var(mb_strstr($item['error'],".",true), FILTER_SANITIZE_NUMBER_INT));
	97	+ } else {
	98	+ return [];
	99	+ }
99	100	}, $response['contacts']['add']);
100	101	} else {
101	102	return [];

dotzero / amocrm-php

Pull Request — master (#72)

Status

Category

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch

Braces +7 added lines, -6 removed lines patch added patch discarded remove patch