Completed
Branch master (aa15f3)
by Dorel
15:05
created
src/AppBundle/Controller/DefaultController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
     /**
52 52
      * Get feed from a specific provider
53 53
      *
54
-     * @param $provider
54
+     * @param string $provider
55 55
      *
56 56
      * @return \AppBundle\Model\FeedInterface
57 57
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
             return $this->render('default/index.html.twig', [
44 44
                 'feedItems' => $items,
45 45
             ]);
46
-        } catch(\Exception $e) {
46
+        } catch (\Exception $e) {
47 47
             throw $this->createNotFoundException(sprintf('Feed named %s is not configured.', $feed));
48 48
         }
49 49
     }
Please login to merge, or discard this patch.
var/SymfonyRequirements.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
      * Adds a mandatory requirement in form of a php.ini configuration.
224 224
      *
225 225
      * @param string        $cfgName           The configuration name used for ini_get()
226
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
226
+     * @param boolean|string $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
227 227
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
228 228
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
229 229
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
      * Adds an optional recommendation in form of a php.ini configuration.
242 242
      *
243 243
      * @param string        $cfgName           The configuration name used for ini_get()
244
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
244
+     * @param string|false $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
245 245
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
246 246
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
247 247
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -417,13 +417,13 @@  discard block
 block discarded – undo
417 417
         );
418 418
 
419 419
         $this->addRequirement(
420
-            is_dir(__DIR__.'/../vendor/composer'),
420
+            is_dir(__DIR__ . '/../vendor/composer'),
421 421
             'Vendor libraries must be installed',
422
-            'Vendor libraries are missing. Install composer following instructions from <a href="http://getcomposer.org/">http://getcomposer.org/</a>. '.
422
+            'Vendor libraries are missing. Install composer following instructions from <a href="http://getcomposer.org/">http://getcomposer.org/</a>. ' .
423 423
                 'Then run "<strong>php composer.phar install</strong>" to install them.'
424 424
         );
425 425
 
426
-        $cacheDir = is_dir(__DIR__.'/../var/cache') ? __DIR__.'/../var/cache' : __DIR__.'/cache';
426
+        $cacheDir = is_dir(__DIR__ . '/../var/cache') ? __DIR__ . '/../var/cache' : __DIR__ . '/cache';
427 427
 
428 428
         $this->addRequirement(
429 429
             is_writable($cacheDir),
@@ -431,7 +431,7 @@  discard block
 block discarded – undo
431 431
             'Change the permissions of either "<strong>app/cache/</strong>" or  "<strong>var/cache/</strong>" directory so that the web server can write into it.'
432 432
         );
433 433
 
434
-        $logsDir = is_dir(__DIR__.'/../var/logs') ? __DIR__.'/../var/logs' : __DIR__.'/logs';
434
+        $logsDir = is_dir(__DIR__ . '/../var/logs') ? __DIR__ . '/../var/logs' : __DIR__ . '/logs';
435 435
 
436 436
         $this->addRequirement(
437 437
             is_writable($logsDir),
@@ -564,13 +564,13 @@  discard block
 block discarded – undo
564 564
 
565 565
         /* optional recommendations follow */
566 566
 
567
-        if (file_exists(__DIR__.'/../vendor/composer')) {
568
-            require_once __DIR__.'/../vendor/autoload.php';
567
+        if (file_exists(__DIR__ . '/../vendor/composer')) {
568
+            require_once __DIR__ . '/../vendor/autoload.php';
569 569
 
570 570
             try {
571 571
                 $r = new ReflectionClass('Sensio\Bundle\DistributionBundle\SensioDistributionBundle');
572 572
 
573
-                $contents = file_get_contents(dirname($r->getFileName()).'/Resources/skeleton/app/SymfonyRequirements.php');
573
+                $contents = file_get_contents(dirname($r->getFileName()) . '/Resources/skeleton/app/SymfonyRequirements.php');
574 574
             } catch (ReflectionException $e) {
575 575
                 $contents = '';
576 576
             }
@@ -800,7 +800,7 @@  discard block
 block discarded – undo
800 800
      */
801 801
     protected function getPhpRequiredVersion()
802 802
     {
803
-        if (!file_exists($path = __DIR__.'/../composer.lock')) {
803
+        if (!file_exists($path = __DIR__ . '/../composer.lock')) {
804 804
             return false;
805 805
         }
806 806
 
Please login to merge, or discard this patch.
web/app.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,8 +3,8 @@
 block discarded – undo
3 3
 use Symfony\Component\HttpFoundation\Request;
4 4
 
5 5
 /** @var \Composer\Autoload\ClassLoader $loader */
6
-$loader = require __DIR__.'/../app/autoload.php';
7
-include_once __DIR__.'/../var/bootstrap.php.cache';
6
+$loader = require __DIR__ . '/../app/autoload.php';
7
+include_once __DIR__ . '/../var/bootstrap.php.cache';
8 8
 
9 9
 $kernel = new AppKernel('prod', false);
10 10
 $kernel->loadClassCache();
Please login to merge, or discard this patch.
web/config.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
     exit('This script is only accessible from localhost.');
23 23
 }
24 24
 
25
-require_once dirname(__FILE__).'/../var/SymfonyRequirements.php';
25
+require_once dirname(__FILE__) . '/../var/SymfonyRequirements.php';
26 26
 
27 27
 $symfonyRequirements = new SymfonyRequirements();
28 28
 
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -382,7 +382,10 @@  discard block
 block discarded – undo
382 382
                         <?php if ($hasMinorProblems): ?>
383 383
                             <h2>Recommendations</h2>
384 384
                             <p>
385
-                                <?php if ($hasMajorProblems): ?>Additionally, to<?php else: ?>To<?php endif; ?> enhance your Symfony experience,
385
+                                <?php if ($hasMajorProblems): ?>Additionally, to<?php else {
386
+    : ?>To<?php endif;
387
+}
388
+?> enhance your Symfony experience,
386 389
                                 it’s recommended that you fix the following:
387 390
                             </p>
388 391
                             <ol>
@@ -398,9 +401,12 @@  discard block
 block discarded – undo
398 401
                             <p id="phpini">*
399 402
                                 <?php if ($symfonyRequirements->getPhpIniConfigPath()): ?>
400 403
                                     Changes to the <strong>php.ini</strong> file must be done in "<strong><?php echo $symfonyRequirements->getPhpIniConfigPath() ?></strong>".
401
-                                <?php else: ?>
404
+                                <?php else {
405
+    : ?>
402 406
                                     To change settings, create a "<strong>php.ini</strong>".
403
-                                <?php endif; ?>
407
+                                <?php endif;
408
+}
409
+?>
404 410
                             </p>
405 411
                         <?php endif; ?>
406 412
 
Please login to merge, or discard this patch.