DefaultController::loginAction() - Code Metrics - dontdrinkandroot/gitki.php - Measure and Improve Code Quality continuously with Scrutinizer

DefaultController::loginAction() B
last analyzed 2021-06-05 14:26 UTC

↳ Parent: DefaultController

Complexity

Conditions	8
Paths	6

Size

Total Lines

Duplication

Lines	21
Ratio	77.78 %

Importance

Changes

Metric	Value
dl	21
loc	27
rs	8.4444
c	0
b	0
f	0
cc	8
nc	6
nop	1

<?php

namespace App\Controller;

use Dontdrinkandroot\GitkiBundle\Controller\BaseController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Exception\AuthenticationException;

class DefaultController extends BaseController
{
    public function indexAction()
    {
        return $this->redirect($this->generateUrl('ddr_gitki_directory', ['path' => '/', 'action' => 'index']));
    }

    public function loginAction(Request $request)
    {
        if (!$this->isGranted('ROLE_USER')) {


            /* Save targetpath if user was not logged in yet before redirecting to login page */
            if ($request->hasSession() && $request->isMethodSafe(false)) {

                $referer = $request->headers->get('referer');
                if (null !== $referer) {
                    $request->getSession()->set('ddr.gitki.manuallogin.targetpath', $referer);
                }
            }

            throw new AuthenticationException();
        }

        if ($request->hasSession() && $request->isMethodSafe(false)) {


            /* Restore target path after login */
            $targetPath = $request->getSession()->get('ddr.gitki.manuallogin.targetpath');
            $request->getSession()->remove('ddr.gitki.manuallogin.targetpath');
            if (null !== $targetPath) {
                return $this->redirect($targetPath);
            }
        }

        return $this->redirect($this->generateUrl('ddr_gitki_directory', ['path' => '/', 'action' => 'index']));
    }

    /**
     * @return Response
     */
    public function loggedoutAction()
    {
        return $this->render('Default/loggedout.html.twig');
    }
}


1		<?php
2
3		namespace App\Controller;
4
5		use Dontdrinkandroot\GitkiBundle\Controller\BaseController;
6		use Symfony\Component\HttpFoundation\Request;
7		use Symfony\Component\HttpFoundation\Response;
8		use Symfony\Component\Security\Core\Exception\AuthenticationException;
9
10		class DefaultController extends BaseController
11		{
12		public function indexAction()
13		{
14		return $this->redirect($this->generateUrl('ddr_gitki_directory', ['path' => '/', 'action' => 'index']));
15		}
16
17		public function loginAction(Request $request)
18		{
19	View Code Duplication	if (!$this->isGranted('ROLE_USER')) {
		0 ignored issues – show Duplication introduced 2016-02-21 20:40 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20
21		/* Save targetpath if user was not logged in yet before redirecting to login page */
22		if ($request->hasSession() && $request->isMethodSafe(false)) {
		0 ignored issues – show Unused Code introduced 2020-08-12 22:06 UTC by Report Bug Copy Issue Report The call to `Request::isMethodSafe()` has too many arguments starting with `false`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
23		$referer = $request->headers->get('referer');
24		if (null !== $referer) {
25		$request->getSession()->set('ddr.gitki.manuallogin.targetpath', $referer);
26		}
27		}
28
29		throw new AuthenticationException();
30		}
31
32	View Code Duplication	if ($request->hasSession() && $request->isMethodSafe(false)) {
		0 ignored issues – show Duplication introduced 2016-02-21 20:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Unused Code introduced 2020-08-12 22:06 UTC by Report Bug Copy Issue Report The call to `Request::isMethodSafe()` has too many arguments starting with `false`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
33
34		/* Restore target path after login */
35		$targetPath = $request->getSession()->get('ddr.gitki.manuallogin.targetpath');
36		$request->getSession()->remove('ddr.gitki.manuallogin.targetpath');
37		if (null !== $targetPath) {
38		return $this->redirect($targetPath);
39		}
40		}
41
42		return $this->redirect($this->generateUrl('ddr_gitki_directory', ['path' => '/', 'action' => 'index']));
43		}
44
45		/**
46		* @return Response
47		*/
48		public function loggedoutAction()
49		{
50		return $this->render('Default/loggedout.html.twig');
51		}
52		}
53

dontdrinkandroot / gitki.php

DefaultController::loginAction() B last analyzed 2021-06-05 14:26 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DefaultController::loginAction() B
last analyzed 2021-06-05 14:26 UTC