App\Controller\DefaultController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	43
Duplicated Lines	48.84 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	indexAction()	0	4	1
B	loginAction()	21	27	8
A	loggedoutAction()	0	4	1

<?php

namespace App\Controller;

use Dontdrinkandroot\GitkiBundle\Controller\BaseController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Exception\AuthenticationException;

class DefaultController extends BaseController
{
    public function indexAction()
    {
        return $this->redirect($this->generateUrl('ddr_gitki_directory', ['path' => '/', 'action' => 'index']));
    }

    public function loginAction(Request $request)
    {
        if (!$this->isGranted('ROLE_USER')) {

This code seems to be duplicated across your project.

            /* Save targetpath if user was not logged in yet before redirecting to login page */
            if ($request->hasSession() && $request->isMethodSafe(false)) {

The call to Request::isMethodSafe() has too many arguments starting with false.

                $referer = $request->headers->get('referer');
                if (null !== $referer) {
                    $request->getSession()->set('ddr.gitki.manuallogin.targetpath', $referer);
                }
            }

            throw new AuthenticationException();
        }

        if ($request->hasSession() && $request->isMethodSafe(false)) {

This code seems to be duplicated across your project.

The call to Request::isMethodSafe() has too many arguments starting with false.

            /* Restore target path after login */
            $targetPath = $request->getSession()->get('ddr.gitki.manuallogin.targetpath');
            $request->getSession()->remove('ddr.gitki.manuallogin.targetpath');
            if (null !== $targetPath) {
                return $this->redirect($targetPath);
            }
        }

        return $this->redirect($this->generateUrl('ddr_gitki_directory', ['path' => '/', 'action' => 'index']));
    }

    /**
     * @return Response
     */
    public function loggedoutAction()
    {
        return $this->render('Default/loggedout.html.twig');
    }
}