UserController::crudEditRole() - Code Metrics - dominikzogg/energycalculator - Measure and Improve Code Quality continuously with Scrutinizer

UserController::crudEditRole() A
last analyzed 2016-06-08 19:45 UTC

↳ Parent: UserController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	4
c	1
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Dominikzogg\EnergyCalculator\Controller;

use Doctrine\Common\Persistence\ManagerRegistry;
use Dominikzogg\EnergyCalculator\Entity\User;
use Dominikzogg\EnergyCalculator\Form\UserType;
use Knp\Component\Pager\Paginator;
use Saxulum\Crud\Listing\ListingFactory;
use Saxulum\RouteController\Annotation\DI;
use Saxulum\RouteController\Annotation\Route;
use Saxulum\UserProvider\Manager\UserManager;
use Symfony\Component\Form\FormFactory;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Form\FormTypeInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;

/**
 * @Route("/{_locale}/user", asserts={"_locale"="([a-z]{2}|[a-z]{2}_[A-Z]{2})"})
 * @DI(serviceIds={
 *      "security.authorization_checker",
 *      "security.token_storage",
 *      "saxulum.crud.listing.factory",
 *      "doctrine",
 *      "form.factory",
 *      "knp_paginator",
 *      "url_generator",
 *      "twig",
 *      "saxulum.userprovider.manager"
 * })
 */
class UserController extends AbstractCRUDController
{
    /**
     * @var UserManager
     */
    protected $userManager;

    /**
     * @param AuthorizationCheckerInterface $authorizationChecker
     * @param TokenStorageInterface $tokenStorage
     * @param ListingFactory $listingFactory
     * @param ManagerRegistry          $doctrine
     * @param FormFactory              $formFactory
     * @param Paginator                $paginator
     * @param UrlGeneratorInterface    $urlGenerator
     * @param \Twig_Environment        $twig
     * @param UserManager              $userManager
     */
    public function __construct(

        AuthorizationCheckerInterface $authorizationChecker,
        TokenStorageInterface $tokenStorage,
        ListingFactory $listingFactory,
        ManagerRegistry $doctrine,
        FormFactory $formFactory,
        Paginator $paginator,
        UrlGeneratorInterface $urlGenerator,
        \Twig_Environment $twig,
        UserManager $userManager
    ) {
        $this->authorizationChecker = $authorizationChecker;
        $this->tokenStorage = $tokenStorage;
        $this->listingFactory = $listingFactory;
        $this->doctrine = $doctrine;
        $this->formFactory = $formFactory;
        $this->paginator = $paginator;
        $this->urlGenerator = $urlGenerator;
        $this->twig = $twig;
        $this->userManager = $userManager;
    }

    /**
     * @Route("/", bind="user_list", method="GET")
     * @param  Request  $request
     * @return Response
     */
    public function listAction(Request $request)
    {
        return parent::crudListObjects($request);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @Route("/create", bind="user_create")
     * @param  Request                   $request
     * @return Response|RedirectResponse
     */
    public function createAction(Request $request)
    {
        return self::crudCreateObject($request);
    }

    /**
     * @Route("/edit/{id}", bind="user_edit", asserts={"id"="[0-9a-f]{1,24}"})
     * @param  Request                   $request
     * @param $id
     * @return Response|RedirectResponse
     */
    public function editAction(Request $request, $id)
    {
        return self::crudEditObject($request, $id);
    }

    /**
     * @Route("/view/{id}", bind="user_view", asserts={"id"="[0-9a-f]{1,24}"})
     * @param  Request                   $request
     * @param $id
     * @return Response|RedirectResponse
     */
    public function viewAction(Request $request, $id)
    {
        return self::crudViewObject($request, $id);
    }

    /**
     * @Route("/delete/{id}", bind="user_delete", asserts={"id"="[0-9a-f]{1,24}"}, method="GET")
     * @param  Request          $request
     * @param $id
     * @return RedirectResponse
     */
    public function deleteAction(Request $request, $id)
    {
        return parent::crudDeleteObject($request, $id);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @return string
     */
    protected function crudListRole()
    {
        return strtoupper('role_admin');
    }

    /**
     * @return string
     */
    protected function crudCreateRole()
    {
        return strtoupper('role_admin');
    }

    /**
     * @param Request $request
     * @param object $object
     *
     * @return FormTypeInterface
     */
    protected function crudCreateFormType(Request $request, $object)
    {
        return new UserType($this->crudObjectClass());
    }

    /**
     * @param  User          $object
     * @param  FormInterface $form
     * @param  Request       $request
     * @return void
     */
    protected function crudCreatePrePersist($object, FormInterface $form, Request $request)
    {
        $this->userManager->update($object);
    }

    /**
     * @return string
     */
    protected function crudEditRole()
    {
        return strtoupper('role_admin');
    }

    /**
     * @param Request $request
     * @param object $object
     *
     * @return FormTypeInterface
     */
    protected function crudEditFormType(Request $request, $object)
    {
        return new UserType($this->crudObjectClass());
    }

    /**
     * @param  User          $object
     * @param  FormInterface $form
     * @param  Request       $request
     * @return void
     */
    protected function crudEditPrePersist($object, FormInterface $form, Request $request)
    {
        $this->userManager->update($object);
    }

    /**
     * @return string
     */
    protected function crudViewRole()
    {
        return strtoupper('role_admin');
    }

    /**
     * @return string
     */
    protected function crudDeleteRole()
    {
        return strtoupper('role_admin');
    }

    /**
     * @return string
     */
    protected function crudName()
    {
        return 'user';
    }

    /**
     * @return string
     */
    protected function crudObjectClass()
    {
        return User::class;
    }
}


1		<?php
2
3		namespace Dominikzogg\EnergyCalculator\Controller;
4
5		use Doctrine\Common\Persistence\ManagerRegistry;
6		use Dominikzogg\EnergyCalculator\Entity\User;
7		use Dominikzogg\EnergyCalculator\Form\UserType;
8		use Knp\Component\Pager\Paginator;
9		use Saxulum\Crud\Listing\ListingFactory;
10		use Saxulum\RouteController\Annotation\DI;
11		use Saxulum\RouteController\Annotation\Route;
12		use Saxulum\UserProvider\Manager\UserManager;
13		use Symfony\Component\Form\FormFactory;
14		use Symfony\Component\Form\FormInterface;
15		use Symfony\Component\Form\FormTypeInterface;
16		use Symfony\Component\HttpFoundation\RedirectResponse;
17		use Symfony\Component\HttpFoundation\Request;
18		use Symfony\Component\HttpFoundation\Response;
19		use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
20		use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
21		use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
22
23		/**
24		* @Route("/{_locale}/user", asserts={"_locale"="([a-z]{2}\|[a-z]{2}_[A-Z]{2})"})
25		* @DI(serviceIds={
26		* "security.authorization_checker",
27		* "security.token_storage",
28		* "saxulum.crud.listing.factory",
29		* "doctrine",
30		* "form.factory",
31		* "knp_paginator",
32		* "url_generator",
33		* "twig",
34		* "saxulum.userprovider.manager"
35		* })
36		*/
37		class UserController extends AbstractCRUDController
38		{
39		/**
40		* @var UserManager
41		*/
42		protected $userManager;
43
44		/**
45		* @param AuthorizationCheckerInterface $authorizationChecker
46		* @param TokenStorageInterface $tokenStorage
47		* @param ListingFactory $listingFactory
48		* @param ManagerRegistry $doctrine
49		* @param FormFactory $formFactory
50		* @param Paginator $paginator
51		* @param UrlGeneratorInterface $urlGenerator
52		* @param \Twig_Environment $twig
53		* @param UserManager $userManager
54		*/
55	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2015-11-29 21:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		AuthorizationCheckerInterface $authorizationChecker,
57		TokenStorageInterface $tokenStorage,
58		ListingFactory $listingFactory,
59		ManagerRegistry $doctrine,
60		FormFactory $formFactory,
61		Paginator $paginator,
62		UrlGeneratorInterface $urlGenerator,
63		\Twig_Environment $twig,
64		UserManager $userManager
65		) {
66		$this->authorizationChecker = $authorizationChecker;
67		$this->tokenStorage = $tokenStorage;
68		$this->listingFactory = $listingFactory;
69		$this->doctrine = $doctrine;
70		$this->formFactory = $formFactory;
71		$this->paginator = $paginator;
72		$this->urlGenerator = $urlGenerator;
73		$this->twig = $twig;
74		$this->userManager = $userManager;
75		}
76
77		/**
78		* @Route("/", bind="user_list", method="GET")
79		* @param Request $request
80		* @return Response
81		*/
82		public function listAction(Request $request)
83		{
84		return parent::crudListObjects($request);
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-29 21:20 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`crudListObjects()` instead of `listAction()`). Are you sure this is correct? If so, you might want to change this to `$this->crudListObjects()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
85		}
86
87		/**
88		* @Route("/create", bind="user_create")
89		* @param Request $request
90		* @return Response\|RedirectResponse
91		*/
92		public function createAction(Request $request)
93		{
94		return self::crudCreateObject($request);
95		}
96
97		/**
98		* @Route("/edit/{id}", bind="user_edit", asserts={"id"="[0-9a-f]{1,24}"})
99		* @param Request $request
100		* @param $id
101		* @return Response\|RedirectResponse
102		*/
103		public function editAction(Request $request, $id)
104		{
105		return self::crudEditObject($request, $id);
106		}
107
108		/**
109		* @Route("/view/{id}", bind="user_view", asserts={"id"="[0-9a-f]{1,24}"})
110		* @param Request $request
111		* @param $id
112		* @return Response\|RedirectResponse
113		*/
114		public function viewAction(Request $request, $id)
115		{
116		return self::crudViewObject($request, $id);
117		}
118
119		/**
120		* @Route("/delete/{id}", bind="user_delete", asserts={"id"="[0-9a-f]{1,24}"}, method="GET")
121		* @param Request $request
122		* @param $id
123		* @return RedirectResponse
124		*/
125		public function deleteAction(Request $request, $id)
126		{
127		return parent::crudDeleteObject($request, $id);
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-29 21:20 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`crudDeleteObject()` instead of `deleteAction()`). Are you sure this is correct? If so, you might want to change this to `$this->crudDeleteObject()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
128		}
129
130		/**
131		* @return string
132		*/
133		protected function crudListRole()
134		{
135		return strtoupper('role_admin');
136		}
137
138		/**
139		* @return string
140		*/
141		protected function crudCreateRole()
142		{
143		return strtoupper('role_admin');
144		}
145
146		/**
147		* @param Request $request
148		* @param object $object
149		*
150		* @return FormTypeInterface
151		*/
152		protected function crudCreateFormType(Request $request, $object)
153		{
154		return new UserType($this->crudObjectClass());
155		}
156
157		/**
158		* @param User $object
159		* @param FormInterface $form
160		* @param Request $request
161		* @return void
162		*/
163		protected function crudCreatePrePersist($object, FormInterface $form, Request $request)
164		{
165		$this->userManager->update($object);
166		}
167
168		/**
169		* @return string
170		*/
171		protected function crudEditRole()
172		{
173		return strtoupper('role_admin');
174		}
175
176		/**
177		* @param Request $request
178		* @param object $object
179		*
180		* @return FormTypeInterface
181		*/
182		protected function crudEditFormType(Request $request, $object)
183		{
184		return new UserType($this->crudObjectClass());
185		}
186
187		/**
188		* @param User $object
189		* @param FormInterface $form
190		* @param Request $request
191		* @return void
192		*/
193		protected function crudEditPrePersist($object, FormInterface $form, Request $request)
194		{
195		$this->userManager->update($object);
196		}
197
198		/**
199		* @return string
200		*/
201		protected function crudViewRole()
202		{
203		return strtoupper('role_admin');
204		}
205
206		/**
207		* @return string
208		*/
209		protected function crudDeleteRole()
210		{
211		return strtoupper('role_admin');
212		}
213
214		/**
215		* @return string
216		*/
217		protected function crudName()
218		{
219		return 'user';
220		}
221
222		/**
223		* @return string
224		*/
225		protected function crudObjectClass()
226		{
227		return User::class;
228		}
229		}
230

dominikzogg / energycalculator

UserController::crudEditRole() A last analyzed 2016-06-08 19:45 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

UserController::crudEditRole() A
last analyzed 2016-06-08 19:45 UTC