Dominikzogg\EnergyCalculator\Controller\UserController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	193
Duplicated Lines	10.88 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	13
Bugs	2	Features	1

17 Methods

Rating	Name	Duplication	Size	Complexity
A	listAction()	0	4	1
A	createAction()	0	4	1
A	editAction()	0	4	1
A	viewAction()	0	4	1
A	deleteAction()	0	4	1
A	crudListRole()	0	4	1
A	crudCreateRole()	0	4	1
A	crudCreateFormType()	0	4	1
A	crudCreatePrePersist()	0	4	1
A	crudEditRole()	0	4	1
A	crudEditFormType()	0	4	1
A	crudEditPrePersist()	0	4	1
A	crudViewRole()	0	4	1
A	crudDeleteRole()	0	4	1
A	crudName()	0	4	1
A	crudObjectClass()	0	4	1
A	__construct()	21	21	1

<?php

namespace Dominikzogg\EnergyCalculator\Controller;

use Doctrine\Common\Persistence\ManagerRegistry;
use Dominikzogg\EnergyCalculator\Entity\User;
use Dominikzogg\EnergyCalculator\Form\UserType;
use Knp\Component\Pager\Paginator;
use Saxulum\Crud\Listing\ListingFactory;
use Saxulum\RouteController\Annotation\DI;
use Saxulum\RouteController\Annotation\Route;
use Saxulum\UserProvider\Manager\UserManager;
use Symfony\Component\Form\FormFactory;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Form\FormTypeInterface;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;

/**
 * @Route("/{_locale}/user", asserts={"_locale"="([a-z]{2}|[a-z]{2}_[A-Z]{2})"})
 * @DI(serviceIds={
 *      "security.authorization_checker",
 *      "security.token_storage",
 *      "saxulum.crud.listing.factory",
 *      "doctrine",
 *      "form.factory",
 *      "knp_paginator",
 *      "url_generator",
 *      "twig",
 *      "saxulum.userprovider.manager"
 * })
 */
class UserController extends AbstractCRUDController
{
    /**
     * @var UserManager
     */
    protected $userManager;

    /**
     * @param AuthorizationCheckerInterface $authorizationChecker
     * @param TokenStorageInterface $tokenStorage
     * @param ListingFactory $listingFactory
     * @param ManagerRegistry          $doctrine
     * @param FormFactory              $formFactory
     * @param Paginator                $paginator
     * @param UrlGeneratorInterface    $urlGenerator
     * @param \Twig_Environment        $twig
     * @param UserManager              $userManager
     */
    public function __construct(

This method seems to be duplicated in your project.

        AuthorizationCheckerInterface $authorizationChecker,
        TokenStorageInterface $tokenStorage,
        ListingFactory $listingFactory,
        ManagerRegistry $doctrine,
        FormFactory $formFactory,
        Paginator $paginator,
        UrlGeneratorInterface $urlGenerator,
        \Twig_Environment $twig,
        UserManager $userManager
    ) {
        $this->authorizationChecker = $authorizationChecker;
        $this->tokenStorage = $tokenStorage;
        $this->listingFactory = $listingFactory;
        $this->doctrine = $doctrine;
        $this->formFactory = $formFactory;
        $this->paginator = $paginator;
        $this->urlGenerator = $urlGenerator;
        $this->twig = $twig;
        $this->userManager = $userManager;
    }

    /**
     * @Route("/", bind="user_list", method="GET")
     * @param  Request  $request
     * @return Response
     */
    public function listAction(Request $request)
    {
        return parent::crudListObjects($request);

It seems like you call parent on a different method (crudListObjects() instead of listAction()). Are you sure this is correct? If so, you might want to change this to $this->crudListObjects().

    }

    /**
     * @Route("/create", bind="user_create")
     * @param  Request                   $request
     * @return Response|RedirectResponse
     */
    public function createAction(Request $request)
    {
        return self::crudCreateObject($request);
    }

    /**
     * @Route("/edit/{id}", bind="user_edit", asserts={"id"="[0-9a-f]{1,24}"})
     * @param  Request                   $request
     * @param $id
     * @return Response|RedirectResponse
     */
    public function editAction(Request $request, $id)
    {
        return self::crudEditObject($request, $id);
    }

    /**
     * @Route("/view/{id}", bind="user_view", asserts={"id"="[0-9a-f]{1,24}"})
     * @param  Request                   $request
     * @param $id
     * @return Response|RedirectResponse
     */
    public function viewAction(Request $request, $id)
    {
        return self::crudViewObject($request, $id);
    }

    /**
     * @Route("/delete/{id}", bind="user_delete", asserts={"id"="[0-9a-f]{1,24}"}, method="GET")
     * @param  Request          $request
     * @param $id
     * @return RedirectResponse
     */
    public function deleteAction(Request $request, $id)
    {
        return parent::crudDeleteObject($request, $id);

It seems like you call parent on a different method (crudDeleteObject() instead of deleteAction()). Are you sure this is correct? If so, you might want to change this to $this->crudDeleteObject().

    }

    /**
     * @return string
     */
    protected function crudListRole()
    {
        return strtoupper('role_admin');
    }

    /**
     * @return string
     */
    protected function crudCreateRole()
    {
        return strtoupper('role_admin');
    }

    /**
     * @param Request $request
     * @param object $object
     *
     * @return FormTypeInterface
     */
    protected function crudCreateFormType(Request $request, $object)
    {
        return new UserType($this->crudObjectClass());
    }

    /**
     * @param  User          $object
     * @param  FormInterface $form
     * @param  Request       $request
     * @return void
     */
    protected function crudCreatePrePersist($object, FormInterface $form, Request $request)
    {
        $this->userManager->update($object);
    }

    /**
     * @return string
     */
    protected function crudEditRole()
    {
        return strtoupper('role_admin');
    }

    /**
     * @param Request $request
     * @param object $object
     *
     * @return FormTypeInterface
     */
    protected function crudEditFormType(Request $request, $object)
    {
        return new UserType($this->crudObjectClass());
    }

    /**
     * @param  User          $object
     * @param  FormInterface $form
     * @param  Request       $request
     * @return void
     */
    protected function crudEditPrePersist($object, FormInterface $form, Request $request)
    {
        $this->userManager->update($object);
    }

    /**
     * @return string
     */
    protected function crudViewRole()
    {
        return strtoupper('role_admin');
    }

    /**
     * @return string
     */
    protected function crudDeleteRole()
    {
        return strtoupper('role_admin');
    }

    /**
     * @return string
     */
    protected function crudName()
    {
        return 'user';
    }

    /**
     * @return string
     */
    protected function crudObjectClass()
    {
        return User::class;
    }
}