doesangueorg / doesangue-core

app/Http/Controllers/API/V1/CampaignController.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use DoeSangue\Http\Requests\CreateCampaignRequest;
 use DoeSangue\Http\Controllers\Controller;
 use Illuminate\Support\Facades\Mail;
-use DoeSangue\Models\Donor;
 use DoeSangue\Models\Campaign;
 use Carbon\Carbon;
 use Tymon\JWTAuth\Facades\JWTAuth;

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 
         $campaign = new Campaign();
         $campaign->title = $request[ 'title' ];
-        $campaign->description = $request['description'];
+        $campaign->description = $request[ 'description' ];
       /*   $imageName = sprintf('%s.%s', hash_file('sha256', $request->file->getPathname()), $request->file->getExtension());
          if ($request->has('image') && $filesystem->has("uploads/{$imageName}")) {
              $image->storePubliclyAs($imageName, 'uploads/');

app/Http/Controllers/API/V1/DonorsController.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace DoeSangue\Http\Controllers\API\V1;
 
-use Illuminate\Http\Request;
 use DoeSangue\Http\Controllers\Controller;
 use DoeSangue\Models\Donor;
 

app/Http/Controllers/API/V1/UsersController.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace DoeSangue\Http\Controllers\API\V1;
 
-use Illuminate\Http\Request;
 use DoeSangue\Http\Controllers\Controller;
 use DoeSangue\Repositories\Users;
 

app/Models/User.php

Doc Comments +2 added lines, -2 removed lines

@@ -69,7 +69,7 @@ 
     /**
      * Returns the campaigns created by the user.
      *
-     * @return array relationship
+     * @return \Illuminate\Database\Eloquent\Relations\HasMany relationship
      * @var    array
      */
     public function campaigns()
@@ -85,7 +85,7 @@ 
     /**
      * Returns the comments created by the user.
      *
-     * @return array relationship
+     * @return \Illuminate\Database\Eloquent\Relations\HasMany relationship
      * @var    array
      */
     public function comments()

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
      */
     public function getFullNameAttribute($value)
     {
-        return ucfirst($this->first_name) . ' ' . ucfirst($this->last_name);
+        return ucfirst($this->first_name).' '.ucfirst($this->last_name);
     }
 
     /**
@@ -95,6 +95,6 @@ 
 
     public function getIsActiveAttribute()
     {
-        return $this->attributes['active'] == true;
+        return $this->attributes[ 'active' ] == true;
     }
 }

app/Repositories/Users.php

Doc Comments +3 added lines

@@ -16,6 +16,9 @@
         return User::whereUsername($username)->get();
     }
 
+    /**
+     * @return string
+     */
     public function filterActive()
     {
         //

app/Exceptions/Handler.php

Spacing +5 added lines, -5 removed lines

@@ -47,24 +47,24 @@ 
     public function render($request, Exception $exception)
     {
         // Validate 404 exceptions.
-        if($exception instanceof NotFoundHttpException) {
+        if ($exception instanceof NotFoundHttpException) {
             return response()->json(
                 [
                 'error' => [
                     'description' => 'Invalid URI',
-                    'messages' => []
+                    'messages' => [ ]
                 ]
                 ], 404
             );
         }
 
         // Method not allowed exception handler
-        if($exception instanceof MethodNotAllowedHttpException) {
+        if ($exception instanceof MethodNotAllowedHttpException) {
             return response()->json(
                 [
                 'error' => [
                     'description' => 'Method Not Allowed',
-                    'messages' => []
+                    'messages' => [ ]
                 ]
                 ], 405
             );
@@ -84,7 +84,7 @@ 
     protected function unauthenticated($request, AuthenticationException $exception)
     {
         if ($request->expectsJson()) {
-            return response()->json(['error' => 'Unauthenticated.'], 401);
+            return response()->json([ 'error' => 'Unauthenticated.' ], 401);
         }
 
         return redirect()->guest('login');

app/Providers/AppServiceProvider.php

Spacing +2 added lines, -2 removed lines

@@ -19,8 +19,8 @@
         // Extend the Validator class.
         // To check the user age (minimum: 16)
         Validator::extend(
-            'olderThan', function ($attributes, $value, $parameters) {
-                $minAge = ( ! empty($parameters)) ? (int) $parameters[0] : 16;
+            'olderThan', function($attributes, $value, $parameters) {
+                $minAge = (!empty($parameters)) ? (int) $parameters[ 0 ] : 16;
                 return \Carbon\Carbon::now()->diff(new \Carbon\Carbon($value))->y >= $minAge;
             }
         );

app/Http/Controllers/Auth/AuthenticateController.php

Spacing +2 added lines, -2 removed lines

@@ -94,8 +94,8 @@
         $user = JWTAuth::parseToken()->authenticate();
 
         // If the token is invalid
-        if (! $user) {
-            return response()->json(['invalid_user'], 401);
+        if (!$user) {
+            return response()->json([ 'invalid_user' ], 401);
         }
 
         return response()->json(

app/Http/Controllers/API/V1/CommentsController.php

Indentation +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
             );
         }
 
-         // Notify error in not found
+          // Notify error in not found
         if (!$comment) {
             return response()->json(
                 [

Spacing +3 added lines, -3 removed lines

@@ -32,7 +32,7 @@ 
         $camp = Campaign::find($campaign);
         $comment = new Comment();
         $comment->id = str_random();
-        $comment->comment = $request['comment'];
+        $comment->comment = $request[ 'comment' ];
         $comment->user_id = $user->id;
         $comment->campaign_id = $camp->id;
         // $comment->created_at = Carbon::now();
@@ -63,9 +63,9 @@ 
             );
         }
 
-        $comment->comment = $request['comment'];
+        $comment->comment = $request[ 'comment' ];
 
-        if (! $comment) {
+        if (!$comment) {
             return response()->json(
                 [
                     'error_code' => 404,