Summary - Inspection of "More optimizations and preparation for ClassMetada..." - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — develop ( 082d66...6f26e1 )

by Guilherme

created 2017-08-05 18:41 UTC

Changes

5 failure conditions met `issues.label("coding-style").new.exists` File Path Number of issues lib/Doctrine/ORM/Query/ResultSetMappingBuilder.php 2 `issues.severity(>= MAJOR).new.exists` File Path Number of issues lib/Doctrine/ORM/Query/ResultSetMappingBuilder.php 2 lib/Doctrine/ORM/Cache/DefaultCache.php 1 lib/Doctrine/ORM/Mapping/ClassMetadata.php 8 ORM/Mapping/Factory/ClassMetadataGenerator.php 1 lib/Doctrine/ORM/Mapping/TableMetadata.php 1 ORM/Persisters/Collection/ManyToManyPersister.php 2 ORM/Persisters/Collection/OneToManyPersister.php 2 ORM/Persisters/Entity/BasicEntityPersister.php 4 ORM/Persisters/Entity/JoinedSubclassPersister.php 4 ORM/Persisters/Entity/SingleTablePersister.php 1 ORM/Query/Exec/MultiTableDeleteExecutor.php 2 ORM/Query/Exec/MultiTableUpdateExecutor.php 2 lib/Doctrine/ORM/Query/SqlWalker.php 3 Tools/Console/Command/MappingDescribeCommand.php 2 lib/Doctrine/ORM/Tools/DebugUnitOfWorkListener.php 1 lib/Doctrine/ORM/Tools/EntityGenerator.php 6 Doctrine/ORM/Tools/Export/Driver/PhpExporter.php 1 Doctrine/ORM/Tools/Export/Driver/XmlExporter.php 4 lib/Doctrine/ORM/Tools/SchemaTool.php 2 lib/Doctrine/ORM/Tools/SchemaValidator.php 2 lib/Doctrine/ORM/UnitOfWork.php 10 Tests/ORM/Functional/DatabaseDriverTestCase.php 1 Tests/ORM/Functional/Ticket/DDC599Test.php 1 Tests/ORM/Mapping/ClassMetadataFactoryTest.php 2 Doctrine/Tests/ORM/Mapping/ClassMetadataTest.php 1 more... `patches.label("Doc Comments").new.exists` View Patches File Path Number of issues ORM/Mapping/ReflectionEmbeddedProperty.php 1 ORM/Persisters/Entity/SingleTablePersister.php 1 Doctrine/ORM/Tools/Export/Driver/XmlExporter.php 1 `patches.label("Unused Use Statements").new.exists` View Patches File Path Number of issues ORM/Mapping/ReflectionEmbeddedProperty.php 1 ORM/Persisters/Entity/SingleTablePersister.php 2 Doctrine/ORM/Tools/Export/Driver/XmlExporter.php 1 lib/Doctrine/ORM/Mapping/FieldMetadata.php 1 ORM/Persisters/Collection/ManyToManyPersister.php 1 ORM/Persisters/Entity/JoinedSubclassPersister.php 1 lib/Doctrine/ORM/UnitOfWork.php 1 `elements.rating(<= C).new.exists` Name AbstractClassMetadataFactory::loadMetadata() ClassMetadata::getIdentifierColumns() ClassMetadata::addProperty() ClassMetadata::addInheritedProperty() ClassMetadataFactory::buildValueGenerationPlan() ResultSetMappingBuilder::addAllClassFields() MappingDescribeCommand::formatParentClasses()
	149 issues (64 major, 64 minor, 21 informational) were introduced. 208 issues were fixed.
	51 new patches (Spacing, Unused Use Statements, Doc Comments, Indentation) are available.
	17 added classes/operations
		C	MappingDescribeCommand::formatParentClasses() added
		B	ComponentMetadata::getColumnsIterator() added
		A	ClassMetadataBuildingContext added
		A	OnClassMetadataNotFoundEventArgs::getClassMetadataBuildingContext() added
		A	ClassMetadata::getColumnsIterator() added
		A	ClassMetadata::getAncestorsIterator() added
		A	ClassMetadataBuildingContext::__construct() added
		A	ClassMetadataBuildingContext::getClassMetadataFactory() added
		A	ClassMetadataBuildingContext::getNamingStrategy() added
		A	ClassMetadataBuildingContext::addSecondPass() added
B	↘	D	ClassMetadata::addInheritedProperty() got worse
B	↘	C	AbstractClassMetadataFactory::loadMetadata() got worse
B	↘	C	ClassMetadata::getIdentifierColumns() got worse
D	↘	F	EntityGeneratorTest got worse
A	↘	B	OnClassMetadataNotFoundEventArgsTest::testEventArgsMutability() got worse
A	↘	B	ClassMetadataTest::testOneToOneUnderscoreNamingStrategyDefaults() got worse
A	↘	B	ProxyFactoryTest::setUp() got worse
B	↘	C	ClassMetadata::addProperty() got worse
B	↘	C	ClassMetadataFactory::buildValueGenerationPlan() got worse
A	↘	B	ManyToManyPersister::delete() got worse
view all

6.94

▼ -0.03

Test Coverage

88%

▶ ±0%

Head	Guilherme Blanco 2017-07-31 23:57 GMT-0400 More optimizations and preparation for ClassMetadataFactory replacement. Integration with ComponentMetadata started.
Base	Marco Pivetta 2017-08-05 07:15 UTC Merge pull request #6599 from Majkl578/dev/typehint-EntityManagerInterface

doctrine / orm

Push — develop ( 082d66...6f26e1 )

Changes

5 failure conditions met