Failed Conditions
Push — 2.6 ( c83094...6a827d )
by Luís
63:56 queued 58:10
created
lib/Doctrine/ORM/PersistentCollection.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
      */
401 401
     public function containsKey($key)
402 402
     {
403
-        if (! $this->initialized && $this->association['fetch'] === ClassMetadata::FETCH_EXTRA_LAZY
403
+        if ( ! $this->initialized && $this->association['fetch'] === ClassMetadata::FETCH_EXTRA_LAZY
404 404
             && isset($this->association['indexBy'])) {
405 405
             $persister = $this->em->getUnitOfWork()->getCollectionPersister($this->association);
406 406
 
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
             && $this->association['fetch'] === ClassMetadata::FETCH_EXTRA_LAZY
434 434
             && isset($this->association['indexBy'])
435 435
         ) {
436
-            if (!$this->typeClass->isIdentifierComposite && $this->typeClass->isIdentifier($this->association['indexBy'])) {
436
+            if ( ! $this->typeClass->isIdentifierComposite && $this->typeClass->isIdentifier($this->association['indexBy'])) {
437 437
                 return $this->em->find($this->typeClass->name, $key);
438 438
             }
439 439
 
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
      */
449 449
     public function count()
450 450
     {
451
-        if (! $this->initialized && $this->association !== null && $this->association['fetch'] === ClassMetadata::FETCH_EXTRA_LAZY) {
451
+        if ( ! $this->initialized && $this->association !== null && $this->association['fetch'] === ClassMetadata::FETCH_EXTRA_LAZY) {
452 452
             $persister = $this->em->getUnitOfWork()->getCollectionPersister($this->association);
453 453
 
454 454
             return $persister->count($this) + ($this->isDirty ? $this->collection->count() : 0);
Please login to merge, or discard this patch.
lib/Doctrine/ORM/UnitOfWork.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
         try {
382 382
             // Collection deletions (deletions of complete collections)
383 383
             foreach ($this->collectionDeletions as $collectionToDelete) {
384
-                if (! $collectionToDelete instanceof PersistentCollection) {
384
+                if ( ! $collectionToDelete instanceof PersistentCollection) {
385 385
                     $this->getCollectionPersister($collectionToDelete->getMapping())->delete($collectionToDelete);
386 386
 
387 387
                     continue;
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
         $state = $this->getEntityState($entity);
514 514
 
515 515
         if ($state !== self::STATE_MANAGED && $state !== self::STATE_REMOVED) {
516
-            throw new \InvalidArgumentException("Entity has to be managed or scheduled for removal for single computation " . self::objToStr($entity));
516
+            throw new \InvalidArgumentException("Entity has to be managed or scheduled for removal for single computation ".self::objToStr($entity));
517 517
         }
518 518
 
519 519
         $class = $this->em->getClassMetadata(get_class($entity));
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
         $oid  = spl_object_hash($entity);
570 570
         $data = [];
571 571
 
572
-        if (!isset($this->entityChangeSets[$oid])) {
572
+        if ( ! isset($this->entityChangeSets[$oid])) {
573 573
             return $data;
574 574
         }
575 575
 
@@ -732,7 +732,7 @@  discard block
 block discarded – undo
732 732
                     if ($owner === null) { // cloned
733 733
                         $actualValue->setOwner($entity, $assoc);
734 734
                     } else if ($owner !== $entity) { // no clone, we have to fix
735
-                        if (!$actualValue->isInitialized()) {
735
+                        if ( ! $actualValue->isInitialized()) {
736 736
                             $actualValue->initialize(); // we have to do this otherwise the cols share state
737 737
                         }
738 738
                         $newValue = clone $actualValue;
@@ -878,7 +878,7 @@  discard block
 block discarded – undo
878 878
         $targetClass    = $this->em->getClassMetadata($assoc['targetEntity']);
879 879
 
880 880
         foreach ($unwrappedValue as $key => $entry) {
881
-            if (! ($entry instanceof $targetClass->name)) {
881
+            if ( ! ($entry instanceof $targetClass->name)) {
882 882
                 throw ORMInvalidArgumentException::invalidAssociation($targetClass, $assoc, $entry);
883 883
             }
884 884
 
@@ -956,7 +956,7 @@  discard block
 block discarded – undo
956 956
 
957 957
             // Some identifiers may be foreign keys to new entities.
958 958
             // In this case, we don't have the value yet and should treat it as if we have a post-insert generator
959
-            if (! $this->hasMissingIdsWhichAreForeignKeys($class, $idValue)) {
959
+            if ( ! $this->hasMissingIdsWhichAreForeignKeys($class, $idValue)) {
960 960
                 $this->entityIdentifiers[$oid] = $idValue;
961 961
             }
962 962
         }
@@ -1105,7 +1105,7 @@  discard block
 block discarded – undo
1105 1105
             }
1106 1106
         } else {
1107 1107
             foreach ($insertionsForClass as $oid => $entity) {
1108
-                if (! isset($this->entityIdentifiers[$oid])) {
1108
+                if ( ! isset($this->entityIdentifiers[$oid])) {
1109 1109
                     //entity was not added to identity map because some identifiers are foreign keys to new entities.
1110 1110
                     //add it now
1111 1111
                     $this->addToEntityIdentifiersAndEntityMap($class, $oid, $entity);
@@ -1270,7 +1270,7 @@  discard block
 block discarded – undo
1270 1270
 
1271 1271
                 $joinColumns = reset($assoc['joinColumns']);
1272 1272
 
1273
-                $calc->addDependency($targetClass->name, $class->name, (int)empty($joinColumns['nullable']));
1273
+                $calc->addDependency($targetClass->name, $class->name, (int) empty($joinColumns['nullable']));
1274 1274
 
1275 1275
                 // If the target class has mapped subclasses, these share the same dependency.
1276 1276
                 if ( ! $targetClass->subClasses) {
@@ -1793,7 +1793,7 @@  discard block
 block discarded – undo
1793 1793
                 throw ORMInvalidArgumentException::detachedEntityCannot($entity, "persisted");
1794 1794
 
1795 1795
             default:
1796
-                throw new UnexpectedValueException("Unexpected entity state: $entityState." . self::objToStr($entity));
1796
+                throw new UnexpectedValueException("Unexpected entity state: $entityState.".self::objToStr($entity));
1797 1797
         }
1798 1798
 
1799 1799
         $this->cascadePersist($entity, $visited);
@@ -1863,7 +1863,7 @@  discard block
 block discarded – undo
1863 1863
             case self::STATE_DETACHED:
1864 1864
                 throw ORMInvalidArgumentException::detachedEntityCannot($entity, "removed");
1865 1865
             default:
1866
-                throw new UnexpectedValueException("Unexpected entity state: $entityState." . self::objToStr($entity));
1866
+                throw new UnexpectedValueException("Unexpected entity state: $entityState.".self::objToStr($entity));
1867 1867
         }
1868 1868
 
1869 1869
     }
@@ -2002,7 +2002,7 @@  discard block
 block discarded – undo
2002 2002
      */
2003 2003
     private function ensureVersionMatch(ClassMetadata $class, $entity, $managedCopy)
2004 2004
     {
2005
-        if (! ($class->isVersioned && $this->isLoaded($managedCopy) && $this->isLoaded($entity))) {
2005
+        if ( ! ($class->isVersioned && $this->isLoaded($managedCopy) && $this->isLoaded($entity))) {
2006 2006
             return;
2007 2007
         }
2008 2008
 
@@ -2027,7 +2027,7 @@  discard block
 block discarded – undo
2027 2027
      */
2028 2028
     private function isLoaded($entity)
2029 2029
     {
2030
-        return !($entity instanceof Proxy) || $entity->__isInitialized();
2030
+        return ! ($entity instanceof Proxy) || $entity->__isInitialized();
2031 2031
     }
2032 2032
 
2033 2033
     /**
@@ -2185,7 +2185,7 @@  discard block
 block discarded – undo
2185 2185
 
2186 2186
         $associationMappings = array_filter(
2187 2187
             $class->associationMappings,
2188
-            function ($assoc) { return $assoc['isCascadeRefresh']; }
2188
+            function($assoc) { return $assoc['isCascadeRefresh']; }
2189 2189
         );
2190 2190
 
2191 2191
         foreach ($associationMappings as $assoc) {
@@ -2228,7 +2228,7 @@  discard block
 block discarded – undo
2228 2228
 
2229 2229
         $associationMappings = array_filter(
2230 2230
             $class->associationMappings,
2231
-            function ($assoc) { return $assoc['isCascadeDetach']; }
2231
+            function($assoc) { return $assoc['isCascadeDetach']; }
2232 2232
         );
2233 2233
 
2234 2234
         foreach ($associationMappings as $assoc) {
@@ -2272,7 +2272,7 @@  discard block
 block discarded – undo
2272 2272
 
2273 2273
         $associationMappings = array_filter(
2274 2274
             $class->associationMappings,
2275
-            function ($assoc) { return $assoc['isCascadeMerge']; }
2275
+            function($assoc) { return $assoc['isCascadeMerge']; }
2276 2276
         );
2277 2277
 
2278 2278
         foreach ($associationMappings as $assoc) {
@@ -2311,7 +2311,7 @@  discard block
 block discarded – undo
2311 2311
 
2312 2312
         $associationMappings = array_filter(
2313 2313
             $class->associationMappings,
2314
-            function ($assoc) { return $assoc['isCascadePersist']; }
2314
+            function($assoc) { return $assoc['isCascadePersist']; }
2315 2315
         );
2316 2316
 
2317 2317
         foreach ($associationMappings as $assoc) {
@@ -2340,7 +2340,7 @@  discard block
 block discarded – undo
2340 2340
                     break;
2341 2341
 
2342 2342
                 case ($relatedEntities !== null):
2343
-                    if (! $relatedEntities instanceof $assoc['targetEntity']) {
2343
+                    if ( ! $relatedEntities instanceof $assoc['targetEntity']) {
2344 2344
                         throw ORMInvalidArgumentException::invalidAssociation(
2345 2345
                             $this->em->getClassMetadata($assoc['targetEntity']),
2346 2346
                             $assoc,
@@ -2371,13 +2371,13 @@  discard block
 block discarded – undo
2371 2371
 
2372 2372
         $associationMappings = array_filter(
2373 2373
             $class->associationMappings,
2374
-            function ($assoc) { return $assoc['isCascadeRemove']; }
2374
+            function($assoc) { return $assoc['isCascadeRemove']; }
2375 2375
         );
2376 2376
 
2377 2377
         $entitiesToCascade = [];
2378 2378
 
2379 2379
         foreach ($associationMappings as $assoc) {
2380
-            if ($entity instanceof Proxy && !$entity->__isInitialized__) {
2380
+            if ($entity instanceof Proxy && ! $entity->__isInitialized__) {
2381 2381
                 $entity->__load();
2382 2382
             }
2383 2383
 
@@ -2441,7 +2441,7 @@  discard block
 block discarded – undo
2441 2441
                     return;
2442 2442
                 }
2443 2443
 
2444
-                if ($entity instanceof Proxy && !$entity->__isInitialized__) {
2444
+                if ($entity instanceof Proxy && ! $entity->__isInitialized__) {
2445 2445
                     $entity->__load();
2446 2446
                 }
2447 2447
 
@@ -2456,7 +2456,7 @@  discard block
 block discarded – undo
2456 2456
             case LockMode::NONE === $lockMode:
2457 2457
             case LockMode::PESSIMISTIC_READ === $lockMode:
2458 2458
             case LockMode::PESSIMISTIC_WRITE === $lockMode:
2459
-                if (!$this->em->getConnection()->isTransactionActive()) {
2459
+                if ( ! $this->em->getConnection()->isTransactionActive()) {
2460 2460
                     throw TransactionRequiredException::transactionRequired();
2461 2461
                 }
2462 2462
 
@@ -2781,7 +2781,7 @@  discard block
 block discarded – undo
2781 2781
                             // then we can append this entity for eager loading!
2782 2782
                             if ($hints['fetchMode'][$class->name][$field] == ClassMetadata::FETCH_EAGER &&
2783 2783
                                 isset($hints[self::HINT_DEFEREAGERLOAD]) &&
2784
-                                !$targetClass->isIdentifierComposite &&
2784
+                                ! $targetClass->isIdentifierComposite &&
2785 2785
                                 $newValue instanceof Proxy &&
2786 2786
                                 $newValue->__isInitialized__ === false) {
2787 2787
 
@@ -3146,7 +3146,7 @@  discard block
 block discarded – undo
3146 3146
     public function getCollectionPersister(array $association)
3147 3147
     {
3148 3148
         $role = isset($association['cache'])
3149
-            ? $association['sourceEntity'] . '::' . $association['fieldName']
3149
+            ? $association['sourceEntity'].'::'.$association['fieldName']
3150 3150
             : $association['type'];
3151 3151
 
3152 3152
         if (isset($this->collectionPersisters[$role])) {
@@ -3364,7 +3364,7 @@  discard block
 block discarded – undo
3364 3364
      */
3365 3365
     private function afterTransactionComplete()
3366 3366
     {
3367
-        $this->performCallbackOnCachedPersister(function (CachedPersister $persister) {
3367
+        $this->performCallbackOnCachedPersister(function(CachedPersister $persister) {
3368 3368
             $persister->afterTransactionComplete();
3369 3369
         });
3370 3370
     }
@@ -3374,7 +3374,7 @@  discard block
 block discarded – undo
3374 3374
      */
3375 3375
     private function afterTransactionRolledBack()
3376 3376
     {
3377
-        $this->performCallbackOnCachedPersister(function (CachedPersister $persister) {
3377
+        $this->performCallbackOnCachedPersister(function(CachedPersister $persister) {
3378 3378
             $persister->afterTransactionRolledBack();
3379 3379
         });
3380 3380
     }
@@ -3470,11 +3470,11 @@  discard block
 block discarded – undo
3470 3470
      */
3471 3471
     private function mergeEntityStateIntoManagedCopy($entity, $managedCopy)
3472 3472
     {
3473
-        if (! $this->isLoaded($entity)) {
3473
+        if ( ! $this->isLoaded($entity)) {
3474 3474
             return;
3475 3475
         }
3476 3476
 
3477
-        if (! $this->isLoaded($managedCopy)) {
3477
+        if ( ! $this->isLoaded($managedCopy)) {
3478 3478
             $managedCopy->__load();
3479 3479
         }
3480 3480
 
@@ -3497,7 +3497,7 @@  discard block
 block discarded – undo
3497 3497
                     if ($other === null) {
3498 3498
                         $prop->setValue($managedCopy, null);
3499 3499
                     } else {
3500
-                        if ($other instanceof Proxy && !$other->__isInitialized()) {
3500
+                        if ($other instanceof Proxy && ! $other->__isInitialized()) {
3501 3501
                             // do not merge fields marked lazy that have not been fetched.
3502 3502
                             continue;
3503 3503
                         }
@@ -3584,7 +3584,7 @@  discard block
 block discarded – undo
3584 3584
      */
3585 3585
     private function clearIdentityMapForEntityName($entityName)
3586 3586
     {
3587
-        if (! isset($this->identityMap[$entityName])) {
3587
+        if ( ! isset($this->identityMap[$entityName])) {
3588 3588
             return;
3589 3589
         }
3590 3590
 
Please login to merge, or discard this patch.