Failed Conditions
Pull Request — 2.8.x (#8073)
by
unknown
63:26
created
lib/Doctrine/ORM/Tools/Pagination/RemoveUselessLeftJoinsWalker.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -23,13 +23,13 @@  discard block
 block discarded – undo
23 23
         $from = $AST->fromClause->identificationVariableDeclarations;
24 24
         $fromRoot = reset($from);
25 25
 
26
-        if (!isset($AST->whereClause) || !isset($AST->whereClause->conditionalExpression)) {
26
+        if ( ! isset($AST->whereClause) || ! isset($AST->whereClause->conditionalExpression)) {
27 27
             return;
28 28
         }
29 29
 
30 30
         $expr = $AST->whereClause->conditionalExpression->simpleConditionalExpression;
31 31
 
32
-        if (!isset($expr->subselect)) {
32
+        if ( ! isset($expr->subselect)) {
33 33
             return;
34 34
         }
35 35
 
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
         $unused = [];
50 50
 
51 51
         foreach ($joins as $join) {
52
-            if (Query\AST\Join::JOIN_TYPE_LEFT === $join->joinType && !in_array($join->joinAssociationDeclaration->aliasIdentificationVariable, $names)) {
52
+            if (Query\AST\Join::JOIN_TYPE_LEFT === $join->joinType && ! in_array($join->joinAssociationDeclaration->aliasIdentificationVariable, $names)) {
53 53
                 $unused[] = $join;
54 54
             }
55 55
         }
@@ -59,8 +59,8 @@  discard block
 block discarded – undo
59 59
 
60 60
     private function filterJoins($joins, $toRemove)
61 61
     {
62
-        return array_filter($joins, function (Query\AST\Join $join) use ($toRemove) {
63
-            return !in_array($join, $toRemove);
62
+        return array_filter($joins, function(Query\AST\Join $join) use ($toRemove) {
63
+            return ! in_array($join, $toRemove);
64 64
         });
65 65
     }
66 66
 
Please login to merge, or discard this patch.