doctrine / migrations

lib/Doctrine/DBAL/Migrations/Configuration/Configuration.php

Doc Comments +6 added lines, -4 removed lines

@@ -419,7 +419,7 @@ 
      * the value is the migration class name.
      *
      *
-     * @param array $migrations
+     * @param string[] $migrations
      *
      * @return Version[]
      */
@@ -587,6 +587,8 @@ 
     /**
      * Returns the version with the specified offset to the specified version.
      *
+     * @param string $version
+     * @param integer $delta
      * @return string|null A version string, or null if the specified version
      *                     is unknown or the specified delta is not within the
      *                     list of available versions.
@@ -763,7 +765,7 @@ 
      * Find all the migrations in a given directory.
      *
      * @param   string $path the directory to search.
-     * @return  array
+     * @return  string[]
      */
     protected function findMigrations($path)
     {
@@ -813,9 +815,9 @@ 
      * @param string  $direction The direction we are migrating.
      * @param Version $version   The Version instance to check.
      * @param string  $to        The version we are migrating to.
-     * @param array   $migrated  Migrated versions array.
+     * @param Version[]   $migrated  Migrated versions array.
      *
-     * @return boolean
+     * @return boolean|null
      */
     private function shouldExecuteMigration($direction, Version $version, $to, $migrated)
     {

lib/Doctrine/DBAL/Migrations/Version.php

Doc Comments +12 added lines, -2 removed lines

@@ -102,6 +102,10 @@ 
     /** @var SchemaDiffProviderInterface */
     private $schemaProvider;
 
+    /**
+     * @param string $version
+     * @param string $class
+     */
     public function __construct(Configuration $configuration, $version, $class, SchemaDiffProviderInterface $schemaProvider=null)
     {
         $this->configuration = $configuration;
@@ -156,6 +160,9 @@ 
         $this->markVersion('up');
     }
 
+    /**
+     * @param string $direction
+     */
     private function markVersion($direction)
     {
         $action = $direction === 'up' ? 'insert' : 'delete';
@@ -214,7 +221,7 @@ 
      * @param string $path      The path to write the migration SQL file.
      * @param string $direction The direction to execute.
      *
-     * @return boolean $written
+     * @return integer $written
      */
     public function writeSqlFile($path, $direction = self::DIRECTION_UP)
     {
@@ -371,6 +378,9 @@ 
         }
     }
 
+    /**
+     * @param double $queryStart
+     */
     private function outputQueryTime($queryStart, $timeAllQueries = false)
     {
         if ($timeAllQueries !== false) {
@@ -384,7 +394,7 @@ 
     /**
      * Returns the time this migration version took to execute
      *
-     * @return integer $time The time this migration version took to execute
+     * @return double $time The time this migration version took to execute
      */
     public function getTime()
     {

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 use Doctrine\DBAL\Migrations\Provider\LazySchemaDiffProvider;
 use Doctrine\DBAL\Migrations\Provider\SchemaDiffProvider;
 use Doctrine\DBAL\Migrations\Provider\SchemaDiffProviderInterface;
-use ProxyManager\Factory\LazyLoadingValueHolderFactory;
 
 /**
  * Class which wraps a migration version and allows execution of the

Spacing +6 added lines, -6 removed lines

@@ -102,7 +102,7 @@ 
     /** @var SchemaDiffProviderInterface */
     private $schemaProvider;
 
-    public function __construct(Configuration $configuration, $version, $class, SchemaDiffProviderInterface $schemaProvider=null)
+    public function __construct(Configuration $configuration, $version, $class, SchemaDiffProviderInterface $schemaProvider = null)
     {
         $this->configuration = $configuration;
         $this->outputWriter = $configuration->getOutputWriter();
@@ -114,7 +114,7 @@ 
         if ($schemaProvider !== null) {
             $this->schemaProvider = $schemaProvider;
         }
-        if($schemaProvider === null) {
+        if ($schemaProvider === null) {
             $schemaProvider = new SchemaDiffProvider($this->connection->getSchemaManager(),
                 $this->connection->getDatabasePlatform());
             $this->schemaProvider = LazySchemaDiffProvider::fromDefaultProxyFacyoryConfiguration($schemaProvider);
@@ -296,7 +296,7 @@ 
             $this->state = self::STATE_POST;
             $this->migration->{'post' . ucfirst($direction)}($toSchema);
 
-            if (! $dryRun) {
+            if (!$dryRun) {
                 if ($direction === self::DIRECTION_UP) {
                     $this->markMigrated();
                 } else {
@@ -335,7 +335,7 @@ 
                 }
             }
 
-            $this->outputWriter->write(sprintf("\n  <info>SS</info> skipped (Reason: %s)",  $e->getMessage()));
+            $this->outputWriter->write(sprintf("\n  <info>SS</info> skipped (Reason: %s)", $e->getMessage()));
 
             $this->state = self::STATE_NONE;
 
@@ -398,12 +398,12 @@ 
 
     private function executeRegisteredSql($dryRun = false, $timeAllQueries = false)
     {
-        if (! $dryRun) {
+        if (!$dryRun) {
             if (!empty($this->sql)) {
                 foreach ($this->sql as $key => $query) {
                     $queryStart = microtime(true);
 
-                    if ( ! isset($this->params[$key])) {
+                    if (!isset($this->params[$key])) {
                         $this->outputWriter->write('     <comment>-></comment> ' . $query);
                         $this->connection->executeQuery($query);
                     } else {

lib/Doctrine/DBAL/Migrations/Tools/Console/Command/VersionCommand.php

Spacing +6 added lines, -6 removed lines

@@ -92,7 +92,7 @@ 
     {
         $this->configuration = $this->getMigrationConfiguration($input, $output);
 
-        if ( ! $input->getOption('add') && ! $input->getOption('delete')) {
+        if (!$input->getOption('add') && !$input->getOption('delete')) {
             throw new \InvalidArgumentException('You must specify whether you want to --add or --delete the specified version.');
         }
 
@@ -149,26 +149,26 @@ 
 
     private function mark($version, $all = false)
     {
-        if ( ! $this->configuration->hasVersion($version)) {
+        if (!$this->configuration->hasVersion($version)) {
             throw MigrationException::unknownMigrationVersion($version);
         }
 
         $version = $this->configuration->getVersion($version);
         if ($this->markMigrated && $this->configuration->hasVersionMigrated($version)) {
-            if (! $all) {
+            if (!$all) {
                 throw new \InvalidArgumentException(sprintf('The version "%s" already exists in the version table.', $version));
             }
             $marked = true;
         }
 
-        if ( ! $this->markMigrated && ! $this->configuration->hasVersionMigrated($version)) {
-            if (! $all) {
+        if (!$this->markMigrated && !$this->configuration->hasVersionMigrated($version)) {
+            if (!$all) {
                 throw new \InvalidArgumentException(sprintf('The version "%s" does not exists in the version table.', $version));
             }
             $marked = false;
         }
 
-        if ( ! isset($marked)) {
+        if (!isset($marked)) {
             if ($this->markMigrated) {
                 $version->markMigrated();
             } else {