Passed
Pull Request — master (#327)
by
unknown
04:02
created
lib/Doctrine/Common/Annotations/AnnotationReader.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
         'Required' => true,
43 43
         'Target' => true,
44 44
         // Widely used tags (but not existent in phpdoc)
45
-        'fix' => true , 'fixme' => true,
45
+        'fix' => true, 'fixme' => true,
46 46
         'override' => true,
47 47
         // PHPDocumentor 1 tags
48 48
         'abstract'=> true, 'access'=> true,
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
         $this->parser->setIgnoredAnnotationNames($this->getIgnoredAnnotationNames($class));
191 191
         $this->parser->setIgnoredAnnotationNamespaces(self::$globalIgnoredNamespaces);
192 192
 
193
-        return $this->parser->parse($class->getDocComment(), 'class ' . $class->getName());
193
+        return $this->parser->parse($class->getDocComment(), 'class '.$class->getName());
194 194
     }
195 195
 
196 196
     /**
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
     public function getPropertyAnnotations(ReflectionProperty $property)
216 216
     {
217 217
         $class   = $property->getDeclaringClass();
218
-        $context = 'property ' . $class->getName() . "::\$" . $property->getName();
218
+        $context = 'property '.$class->getName()."::\$".$property->getName();
219 219
 
220 220
         $this->parser->setTarget(Target::TARGET_PROPERTY);
221 221
         $this->parser->setImports($this->getPropertyImports($property));
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
     public function getMethodAnnotations(ReflectionMethod $method)
248 248
     {
249 249
         $class   = $method->getDeclaringClass();
250
-        $context = 'method ' . $class->getName() . '::' . $method->getName() . '()';
250
+        $context = 'method '.$class->getName().'::'.$method->getName().'()';
251 251
 
252 252
         $this->parser->setTarget(Target::TARGET_METHOD);
253 253
         $this->parser->setImports($this->getMethodImports($method));
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
     private function collectParsingMetadata(ReflectionClass $class)
368 368
     {
369 369
         $ignoredAnnotationNames = self::$globalIgnoredNames;
370
-        $annotations            = $this->preParser->parse($class->getDocComment(), 'class ' . $class->name);
370
+        $annotations            = $this->preParser->parse($class->getDocComment(), 'class '.$class->name);
371 371
 
372 372
         foreach ($annotations as $annotation) {
373 373
             if ($annotation instanceof IgnoreAnnotation) {
Please login to merge, or discard this patch.
lib/Doctrine/Common/Annotations/DocParser.php 1 patch
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
      */
391 391
     private function match($token)
392 392
     {
393
-        if ( ! $this->lexer->isNextToken($token) ) {
393
+        if (!$this->lexer->isNextToken($token)) {
394 394
             $this->syntaxError($this->lexer->getLiteral($token));
395 395
         }
396 396
 
@@ -409,7 +409,7 @@  discard block
 block discarded – undo
409 409
      */
410 410
     private function matchAny(array $tokens)
411 411
     {
412
-        if ( ! $this->lexer->isNextTokenAny($tokens)) {
412
+        if (!$this->lexer->isNextTokenAny($tokens)) {
413 413
             $this->syntaxError(implode(' or ', array_map([$this->lexer, 'getLiteral'], $tokens)));
414 414
         }
415 415
 
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
             : sprintf("'%s' at position %s", $token['value'], $token['position']);
439 439
 
440 440
         if (strlen($this->context)) {
441
-            $message .= ' in ' . $this->context;
441
+            $message .= ' in '.$this->context;
442 442
         }
443 443
 
444 444
         $message .= '.';
@@ -516,7 +516,7 @@  discard block
 block discarded – undo
516 516
         if ($metadata['is_annotation']) {
517 517
             self::$metadataParser->setTarget(Target::TARGET_CLASS);
518 518
 
519
-            foreach (self::$metadataParser->parse($docComment, 'class @' . $name) as $annotation) {
519
+            foreach (self::$metadataParser->parse($docComment, 'class @'.$name) as $annotation) {
520 520
                 if ($annotation instanceof Target) {
521 521
                     $metadata['targets']         = $annotation->targets;
522 522
                     $metadata['targets_literal'] = $annotation->literal;
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
 
546 546
                     $attribute->required = (false !== strpos($propertyComment, '@Required'));
547 547
                     $attribute->name     = $property->name;
548
-                    $attribute->type     = (false !== strpos($propertyComment, '@var') && preg_match('/@var\s+([^\s]+)/',$propertyComment, $matches))
548
+                    $attribute->type     = (false !== strpos($propertyComment, '@var') && preg_match('/@var\s+([^\s]+)/', $propertyComment, $matches))
549 549
                         ? $matches[1]
550 550
                         : 'mixed';
551 551
 
@@ -553,17 +553,17 @@  discard block
 block discarded – undo
553 553
 
554 554
                     // checks if the property has @Enum
555 555
                     if (false !== strpos($propertyComment, '@Enum')) {
556
-                        $context = 'property ' . $class->name . "::\$" . $property->name;
556
+                        $context = 'property '.$class->name."::\$".$property->name;
557 557
 
558 558
                         self::$metadataParser->setTarget(Target::TARGET_PROPERTY);
559 559
 
560 560
                         foreach (self::$metadataParser->parse($propertyComment, $context) as $annotation) {
561
-                            if ( ! $annotation instanceof Enum) {
561
+                            if (!$annotation instanceof Enum) {
562 562
                                 continue;
563 563
                             }
564 564
 
565 565
                             $metadata['enum'][$property->name]['value']   = $annotation->value;
566
-                            $metadata['enum'][$property->name]['literal'] = ( ! empty($annotation->literal))
566
+                            $metadata['enum'][$property->name]['literal'] = (!empty($annotation->literal))
567 567
                                 ? $annotation->literal
568 568
                                 : $annotation->value;
569 569
                         }
@@ -698,7 +698,7 @@  discard block
 block discarded – undo
698 698
 
699 699
         if ('\\' !== $name[0]) {
700 700
             $pos = strpos($name, '\\');
701
-            $alias = (false === $pos)? $name : substr($name, 0, $pos);
701
+            $alias = (false === $pos) ? $name : substr($name, 0, $pos);
702 702
             $found = false;
703 703
             $loweredAlias = strtolower($alias);
704 704
 
@@ -713,20 +713,20 @@  discard block
 block discarded – undo
713 713
             } elseif (isset($this->imports[$loweredAlias])) {
714 714
                 $namespace = ltrim($this->imports[$loweredAlias], '\\');
715 715
                 $name = (false !== $pos)
716
-                    ? $namespace . substr($name, $pos)
716
+                    ? $namespace.substr($name, $pos)
717 717
                     : $namespace;
718 718
                 $found = $this->classExists($name);
719
-            } elseif ( ! isset($this->ignoredAnnotationNames[$name])
719
+            } elseif (!isset($this->ignoredAnnotationNames[$name])
720 720
                 && isset($this->imports['__NAMESPACE__'])
721
-                && $this->classExists($this->imports['__NAMESPACE__'] . '\\' . $name)
721
+                && $this->classExists($this->imports['__NAMESPACE__'].'\\'.$name)
722 722
             ) {
723 723
                 $name  = $this->imports['__NAMESPACE__'].'\\'.$name;
724 724
                 $found = true;
725
-            } elseif (! isset($this->ignoredAnnotationNames[$name]) && $this->classExists($name)) {
725
+            } elseif (!isset($this->ignoredAnnotationNames[$name]) && $this->classExists($name)) {
726 726
                 $found = true;
727 727
             }
728 728
 
729
-            if ( ! $found) {
729
+            if (!$found) {
730 730
                 if ($this->isIgnoredAnnotation($name)) {
731 731
                     return false;
732 732
                 }
@@ -735,9 +735,9 @@  discard block
 block discarded – undo
735 735
             }
736 736
         }
737 737
 
738
-        $name = ltrim($name,'\\');
738
+        $name = ltrim($name, '\\');
739 739
 
740
-        if ( ! $this->classExists($name)) {
740
+        if (!$this->classExists($name)) {
741 741
             throw AnnotationException::semanticalError(sprintf('The annotation "@%s" in %s does not exist, or could not be auto-loaded.', $name, $this->context));
742 742
         }
743 743
 
@@ -747,7 +747,7 @@  discard block
 block discarded – undo
747 747
 
748 748
 
749 749
         // collects the metadata annotation only if there is not yet
750
-        if ( ! isset(self::$annotationMetadata[$name])) {
750
+        if (!isset(self::$annotationMetadata[$name])) {
751 751
             $this->collectAnnotationMetadata($name);
752 752
         }
753 753
 
@@ -780,7 +780,7 @@  discard block
 block discarded – undo
780 780
             // checks all declared attributes
781 781
             foreach (self::$annotationMetadata[$name]['enum'] as $property => $enum) {
782 782
                 // checks if the attribute is a valid enumerator
783
-                if (isset($values[$property]) && ! in_array($values[$property], $enum['value'])) {
783
+                if (isset($values[$property]) && !in_array($values[$property], $enum['value'])) {
784 784
                     throw AnnotationException::enumeratorError($property, $name, $this->context, $enum['literal'], $values[$property]);
785 785
                 }
786 786
             }
@@ -804,7 +804,7 @@  discard block
 block discarded – undo
804 804
 
805 805
             if ($type['type'] === 'array') {
806 806
                 // handle the case of a single value
807
-                if ( ! is_array($values[$property])) {
807
+                if (!is_array($values[$property])) {
808 808
                     $values[$property] = [$values[$property]];
809 809
                 }
810 810
 
@@ -836,7 +836,7 @@  discard block
 block discarded – undo
836 836
                 }
837 837
 
838 838
                 // handle the case if the property has no annotations
839
-                if ( ! $property = self::$annotationMetadata[$name]['default_property']) {
839
+                if (!$property = self::$annotationMetadata[$name]['default_property']) {
840 840
                     throw AnnotationException::creationError(sprintf('The annotation @%s declared on %s does not accept any values, but got %s.', $originalName, $this->context, json_encode($values)));
841 841
                 }
842 842
             }
@@ -856,13 +856,13 @@  discard block
 block discarded – undo
856 856
     {
857 857
         $values = [];
858 858
 
859
-        if ( ! $this->lexer->isNextToken(DocLexer::T_OPEN_PARENTHESIS)) {
859
+        if (!$this->lexer->isNextToken(DocLexer::T_OPEN_PARENTHESIS)) {
860 860
             return $values;
861 861
         }
862 862
 
863 863
         $this->match(DocLexer::T_OPEN_PARENTHESIS);
864 864
 
865
-        if ( ! $this->lexer->isNextToken(DocLexer::T_CLOSE_PARENTHESIS)) {
865
+        if (!$this->lexer->isNextToken(DocLexer::T_CLOSE_PARENTHESIS)) {
866 866
             $values = $this->Values();
867 867
         }
868 868
 
@@ -890,7 +890,7 @@  discard block
 block discarded – undo
890 890
             $token = $this->lexer->lookahead;
891 891
             $value = $this->Value();
892 892
 
893
-            if ( ! is_object($value) && ! is_array($value)) {
893
+            if (!is_object($value) && !is_array($value)) {
894 894
                 $this->syntaxError('Value', $token);
895 895
             }
896 896
 
@@ -900,10 +900,10 @@  discard block
 block discarded – undo
900 900
         foreach ($values as $k => $value) {
901 901
             if (is_object($value) && $value instanceof \stdClass) {
902 902
                 $values[$value->name] = $value->value;
903
-            } else if ( ! isset($values['value'])){
903
+            } else if (!isset($values['value'])) {
904 904
                 $values['value'] = $value;
905 905
             } else {
906
-                if ( ! is_array($values['value'])) {
906
+                if (!is_array($values['value'])) {
907 907
                     $values['value'] = [$values['value']];
908 908
                 }
909 909
 
@@ -927,7 +927,7 @@  discard block
 block discarded – undo
927 927
     {
928 928
         $identifier = $this->Identifier();
929 929
 
930
-        if ( ! defined($identifier) && false !== strpos($identifier, '::') && '\\' !== $identifier[0]) {
930
+        if (!defined($identifier) && false !== strpos($identifier, '::') && '\\' !== $identifier[0]) {
931 931
             list($className, $const) = explode('::', $identifier);
932 932
 
933 933
             $pos = strpos($className, '\\');
@@ -949,12 +949,12 @@  discard block
 block discarded – undo
949 949
                 case isset($this->imports[$loweredAlias]):
950 950
                     $found     = true;
951 951
                     $className = (false !== $pos)
952
-                        ? $this->imports[$loweredAlias] . substr($className, $pos)
952
+                        ? $this->imports[$loweredAlias].substr($className, $pos)
953 953
                         : $this->imports[$loweredAlias];
954 954
                     break;
955 955
 
956 956
                 default:
957
-                    if(isset($this->imports['__NAMESPACE__'])) {
957
+                    if (isset($this->imports['__NAMESPACE__'])) {
958 958
                         $ns = $this->imports['__NAMESPACE__'];
959 959
 
960 960
                         if (class_exists($ns.'\\'.$className) || interface_exists($ns.'\\'.$className)) {
@@ -966,14 +966,14 @@  discard block
 block discarded – undo
966 966
             }
967 967
 
968 968
             if ($found) {
969
-                 $identifier = $className . '::' . $const;
969
+                 $identifier = $className.'::'.$const;
970 970
             }
971 971
         }
972 972
 
973 973
         /**
974 974
          * Checks if identifier ends with ::class and remove the leading backslash if it exists.
975 975
          */
976
-        if ($this->identifierEndsWithClassConstant($identifier) && ! $this->identifierStartsWithBackslash($identifier)) {
976
+        if ($this->identifierEndsWithClassConstant($identifier) && !$this->identifierStartsWithBackslash($identifier)) {
977 977
             return substr($identifier, 0, $this->getClassConstantPositionInIdentifier($identifier));
978 978
         }
979 979
         if ($this->identifierEndsWithClassConstant($identifier) && $this->identifierStartsWithBackslash($identifier)) {
@@ -1013,7 +1013,7 @@  discard block
 block discarded – undo
1013 1013
     private function Identifier()
1014 1014
     {
1015 1015
         // check if we have an annotation
1016
-        if ( ! $this->lexer->isNextTokenAny(self::$classIdentifiers)) {
1016
+        if (!$this->lexer->isNextTokenAny(self::$classIdentifiers)) {
1017 1017
             $this->syntaxError('namespace separator or identifier');
1018 1018
         }
1019 1019
 
@@ -1029,7 +1029,7 @@  discard block
 block discarded – undo
1029 1029
             $this->match(DocLexer::T_NAMESPACE_SEPARATOR);
1030 1030
             $this->matchAny(self::$classIdentifiers);
1031 1031
 
1032
-            $className .= '\\' . $this->lexer->token['value'];
1032
+            $className .= '\\'.$this->lexer->token['value'];
1033 1033
         }
1034 1034
 
1035 1035
         return $className;
@@ -1077,11 +1077,11 @@  discard block
 block discarded – undo
1077 1077
 
1078 1078
             case DocLexer::T_INTEGER:
1079 1079
                 $this->match(DocLexer::T_INTEGER);
1080
-                return (int)$this->lexer->token['value'];
1080
+                return (int) $this->lexer->token['value'];
1081 1081
 
1082 1082
             case DocLexer::T_FLOAT:
1083 1083
                 $this->match(DocLexer::T_FLOAT);
1084
-                return (float)$this->lexer->token['value'];
1084
+                return (float) $this->lexer->token['value'];
1085 1085
 
1086 1086
             case DocLexer::T_TRUE:
1087 1087
                 $this->match(DocLexer::T_TRUE);
@@ -1209,9 +1209,9 @@  discard block
 block discarded – undo
1209 1209
         }
1210 1210
 
1211 1211
         foreach (array_keys($this->ignoredAnnotationNamespaces) as $ignoredAnnotationNamespace) {
1212
-            $ignoredAnnotationNamespace = rtrim($ignoredAnnotationNamespace, '\\') . '\\';
1212
+            $ignoredAnnotationNamespace = rtrim($ignoredAnnotationNamespace, '\\').'\\';
1213 1213
 
1214
-            if (0 === stripos(rtrim($name, '\\') . '\\', $ignoredAnnotationNamespace)) {
1214
+            if (0 === stripos(rtrim($name, '\\').'\\', $ignoredAnnotationNamespace)) {
1215 1215
                 return true;
1216 1216
             }
1217 1217
         }
Please login to merge, or discard this patch.