Completed
Pull Request — master (#758)
by Alexander
02:55
created
DependencyInjection/Compiler/DoctrineOrmMappingsPass.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      * You should not directly instantiate this class but use one of the
31 31
      * factory methods.
32 32
      *
33
-     * @param Definition|Reference $driver            Driver DI definition or reference.
33
+     * @param Definition $driver            Driver DI definition or reference.
34 34
      * @param array                $namespaces        List of namespaces handled by $driver.
35 35
      * @param string[]             $managerParameters Ordered list of container parameters that
36 36
      *                                                could hold the manager name.
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
      * @param string|false         $enabledParameter  If specified, the compiler pass only executes
40 40
      *                                                if this parameter is defined in the service
41 41
      *                                                container.
42
-     * @param array                $aliasMap          Map of alias to namespace.
42
+     * @param string[]                $aliasMap          Map of alias to namespace.
43 43
      */
44 44
     public function __construct($driver, array $namespaces, array $managerParameters, $enabledParameter = false, array $aliasMap = array())
45 45
     {
Please login to merge, or discard this patch.
DependencyInjection/DoctrineExtension.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -730,6 +730,7 @@
 block discarded – undo
730 730
 
731 731
     /**
732 732
      * {@inheritDoc}
733
+     * @param string $driverName
733 734
      */
734 735
     protected function loadCacheDriver($driverName, $entityManagerName, array $driverMap, ContainerBuilder $container)
735 736
     {
Please login to merge, or discard this patch.
Tests/DependencyInjection/AbstractDoctrineExtensionTest.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -799,6 +799,9 @@  discard block
 block discarded – undo
799 799
         $this->assertDICDefinitionMethodCallOnce($definition, 'setRepositoryFactory', array('repository_factory'));
800 800
     }
801 801
 
802
+    /**
803
+     * @param string $fixture
804
+     */
802 805
     private function loadContainer($fixture, array $bundles = array('YamlBundle'), CompilerPassInterface $compilerPass = null)
803 806
     {
804 807
         $container = $this->getContainer($bundles);
@@ -849,6 +852,10 @@  discard block
 block discarded – undo
849 852
         $this->assertEquals($args, $definition->getArguments(), "Expected and actual DIC Service constructor arguments of definition '".$definition->getClass()."' don't match.");
850 853
     }
851 854
 
855
+    /**
856
+     * @param integer $pos
857
+     * @param string $methodName
858
+     */
852 859
     private function assertDICDefinitionMethodCallAt($pos, Definition $definition, $methodName, array $params = null)
853 860
     {
854 861
         $calls = $definition->getMethodCalls();
@@ -889,6 +896,9 @@  discard block
 block discarded – undo
889 896
         }
890 897
     }
891 898
 
899
+    /**
900
+     * @param string $methodName
901
+     */
892 902
     private function assertDICDefinitionMethodCallCount(Definition $definition, $methodName, array $params = array(), $nbCalls = 1)
893 903
     {
894 904
         $calls = $definition->getMethodCalls();
Please login to merge, or discard this patch.
Twig/DoctrineExtension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
     /**
92 92
      * Shrink the values of parameters from a combination
93 93
      *
94
-     * @param array $parameters
94
+     * @param string[] $parameters
95 95
      * @param array $combination
96 96
      *
97 97
      * @return string
Please login to merge, or discard this patch.
Mapping/EntityListenerServiceResolver.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -9,6 +9,7 @@
 block discarded – undo
9 9
     /**
10 10
      * @param string $className
11 11
      * @param string $serviceId
12
+     * @return void
12 13
      */
13 14
     public function registerService($className, $serviceId);
14 15
 }
Please login to merge, or discard this patch.
Tests/Twig/DoctrineExtensionTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -103,6 +103,9 @@
 block discarded – undo
103 103
 {
104 104
     protected $str;
105 105
 
106
+    /**
107
+     * @param string $str
108
+     */
106 109
     public function __construct($str)
107 110
     {
108 111
         $this->str = $str;
Please login to merge, or discard this patch.
Tests/DependencyInjection/DoctrineExtensionTest.php 2 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -684,6 +684,9 @@  discard block
 block discarded – undo
684 684
         $this->assertFalse($container->hasDefinition('doctrine.dbal.bar_shard_manager'));
685 685
     }
686 686
 
687
+    /**
688
+     * @param string $vendor
689
+     */
687 690
     private function getContainer($bundles = 'YamlBundle', $vendor = null)
688 691
     {
689 692
         $bundles = (array) $bundles;
@@ -709,6 +712,10 @@  discard block
 block discarded – undo
709 712
         $this->assertEquals($args, $definition->getArguments(), "Expected and actual DIC Service constructor arguments of definition '".$definition->getClass()."' don't match.");
710 713
     }
711 714
 
715
+    /**
716
+     * @param integer $pos
717
+     * @param string $methodName
718
+     */
712 719
     private function assertDICDefinitionMethodCallAt($pos, Definition $definition, $methodName, array $params = null)
713 720
     {
714 721
         $calls = $definition->getMethodCalls();
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -16,8 +16,6 @@
 block discarded – undo
16 16
 
17 17
 use Doctrine\Bundle\DoctrineBundle\DependencyInjection\DoctrineExtension;
18 18
 use Doctrine\Bundle\DoctrineBundle\Tests\Builder\BundleConfigurationBuilder;
19
-use Doctrine\Common\Persistence\ManagerRegistry;
20
-use Doctrine\Common\Persistence\ObjectManager;
21 19
 use Doctrine\Common\Proxy\AbstractProxyFactory;
22 20
 use Doctrine\DBAL\Connection;
23 21
 use Doctrine\DBAL\Driver\Connection as DriverConnection;
Please login to merge, or discard this patch.
DataCollector/DoctrineDataCollector.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -233,6 +233,9 @@
 block discarded – undo
233 233
         return $groupedQueries;
234 234
     }
235 235
 
236
+    /**
237
+     * @param integer $totalExecutionTimeMS
238
+     */
236 239
     private function executionTimePercentage($executionTimeMS, $totalExecutionTimeMS)
237 240
     {
238 241
         if ($totalExecutionTimeMS === 0.0 || $totalExecutionTimeMS === 0) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
 use Symfony\Bridge\Doctrine\DataCollector\DoctrineDataCollector as BaseCollector;
21 21
 use Symfony\Component\HttpFoundation\Request;
22 22
 use Symfony\Component\HttpFoundation\Response;
23
-use Symfony\Component\VarDumper\Cloner\Data;
24 23
 
25 24
 /**
26 25
  * DoctrineDataCollector.
Please login to merge, or discard this patch.
ConnectionFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
      * @param array         $params
48 48
      * @param Configuration $config
49 49
      * @param EventManager  $eventManager
50
-     * @param array         $mappingTypes
50
+     * @param integer[]         $mappingTypes
51 51
      *
52 52
      * @return \Doctrine\DBAL\Connection
53 53
      */
Please login to merge, or discard this patch.