ElementalAreaController::elementForm() - Code Metrics - Inspection of "NEW Adding controller to expose form schema endpoi..." - dnadesign/silverstripe-elemental - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#355)

unknown

created 2018-08-27 05:29 UTC

ElementalAreaController::elementForm() A

↳ Parent: ElementalAreaController

Complexity

Conditions	4
Paths	3

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	8
nc	3
nop	1
dl	0
loc	13
rs	10
c	0
b	0
f	0

<?php
namespace DNADesign\Elemental\Controllers;

use DNADesign\Elemental\Models\BaseElement;
use SilverStripe\Admin\LeftAndMain;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Forms\DefaultFormFactory;
use SilverStripe\Forms\Form;

/**
 * Controller for "ElementalArea" - handles loading and saving of in-line edit forms in an elemental area in admin
 */
class ElementalAreaController extends LeftAndMain
{
    private static $url_segment = 'element-area';


    private static $ignore_menuitem = true;


    private static $allowed_actions = array(

        'elementForm',
        'schema',
    );

    /**
     * @param HTTPRequest|null $request
     * @return Form
     * @throws \SilverStripe\Control\HTTPResponse_Exception
     */
    public function elementForm(HTTPRequest $request = null)
    {
        // Get ID either from posted back value, or url parameter
        if (!$request) {
            $this->jsonError(400);
            return null;
        }
        $id = $request->param('ID');
        if (!$id) {
            $this->jsonError(400);
            return null;
        }
        return $this->getElementForm($id) ?: $this->jsonError(404);
        return $this->getElementForm(/** @scrutinizer ignore-type */ $id) ?: $this->jsonError(404);
    }

    /**
     * @param int $elementID
     * @return Form|null Returns null if no element exists for the given ID
     */
    public function getElementForm($elementID)
    {
        $scaffolder = Injector::inst()->get(DefaultFormFactory::class);
        $element = BaseElement::get()->byID($elementID);

        if (!$element) {

            return null;
        }

        return $scaffolder->getForm(
            $this,
            'ElementForm_'.$elementID,
            ['Record' => $element]
        );
    }
}


dnadesign / silverstripe-elemental

Pull Request — master (#355)

ElementalAreaController::elementForm() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like