DNADesign\Elemental\Controllers\ElementalAreaController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getElementForm()	0	13	2
A	elementForm()	0	13	4

<?php
namespace DNADesign\Elemental\Controllers;

use DNADesign\Elemental\Models\BaseElement;
use SilverStripe\Admin\LeftAndMain;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Forms\DefaultFormFactory;
use SilverStripe\Forms\Form;

/**
 * Controller for "ElementalArea" - handles loading and saving of in-line edit forms in an elemental area in admin
 */
class ElementalAreaController extends LeftAndMain
{
    private static $url_segment = 'element-area';

The private property $url_segment is not used, and could be removed.

    private static $ignore_menuitem = true;

The private property $ignore_menuitem is not used, and could be removed.

    private static $allowed_actions = array(

The private property $allowed_actions is not used, and could be removed.

        'elementForm',
        'schema',
    );

    /**
     * @param HTTPRequest|null $request
     * @return Form
     * @throws \SilverStripe\Control\HTTPResponse_Exception
     */
    public function elementForm(HTTPRequest $request = null)
    {
        // Get ID either from posted back value, or url parameter
        if (!$request) {
            $this->jsonError(400);
            return null;
        }
        $id = $request->param('ID');
        if (!$id) {
            $this->jsonError(400);
            return null;
        }
        return $this->getElementForm($id) ?: $this->jsonError(404);

$id of type string is incompatible with the type integer expected by parameter $elementID of DNADesign\Elemental\Controllers\ElementalAreaController::getElementForm().

    }

    /**
     * @param int $elementID
     * @return Form|null Returns null if no element exists for the given ID
     */
    public function getElementForm($elementID)
    {
        $scaffolder = Injector::inst()->get(DefaultFormFactory::class);
        $element = BaseElement::get()->byID($elementID);

        if (!$element) {

$element is of type SilverStripe\ORM\DataObject, thus it always evaluated to true.

            return null;
        }

        return $scaffolder->getForm(
            $this,
            'ElementForm_'.$elementID,
            ['Record' => $element]
        );
    }
}