Completed
Push — master ( f19f8c...ffee04 )
by Dan
02:51
created
Src/Router/Dispatcher/Dispatcher.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     /**
183 183
      * Reflect Controller construct and get parameters.
184 184
      *
185
-     * @param $controllerName
185
+     * @param string $controllerName
186 186
      * @internal
187 187
      *
188 188
      * @return \ReflectionParameter[]
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
     /**
309 309
      * Checks controller instance against whitelist.
310 310
      *
311
-     * @param $controller
311
+     * @param string $controller
312 312
      * @param $options
313 313
      * @throws DispatchException
314 314
      */
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
     /**
343 343
      * Checks controller instance against blacklist.
344 344
      *
345
-     * @param $controller
345
+     * @param string $controller
346 346
      * @param $options
347 347
      * @throws DispatchException
348 348
      */
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
374 374
     /**
375 375
      * With Class Namespace.
376 376
      *
377
-     * @param $namespace
377
+     * @param string $namespace
378 378
      * @return Dispatcher
379 379
      */
380 380
     public function withNamespace($namespace)
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
     /**
388 388
      * With class Namespaces.
389 389
      *
390
-     * @param array $namespaces
390
+     * @param string[] $namespaces
391 391
      * @return Dispatcher
392 392
      */
393 393
     public function withNamespaces(array $namespaces)
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 
117 117
         try {
118 118
             $resolvedHandler['controller'] = $this->_findClass($controllerMethod[0]);
119
-        } catch (\Exception $e) {
119
+        }catch (\Exception $e) {
120 120
             throw new DispatchException($e->getMessage());
121 121
         }
122 122
 
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 
168 168
         try {
169 169
             $this->_getParamsFromVariableName($args);
170
-        } catch (\Exception $e) {
170
+        }catch (\Exception $e) {
171 171
             $this->_getParamsFromTypeHint($args);
172 172
         }
173 173
 
@@ -293,12 +293,12 @@  discard block
 block discarded – undo
293 293
         try {
294 294
             $this->_checkWhiteList($controller, $this->options);
295 295
             $this->_checkBlackList($controller, $this->options);
296
-        } catch (\Exception $e) {
296
+        }catch (\Exception $e) {
297 297
             unset($controllerObj);
298 298
             throw new DispatchException($e->getMessage());
299 299
         }
300 300
 
301
-        if (!method_exists($controllerObj,$method)){
301
+        if (!method_exists($controllerObj, $method)) {
302 302
             throw new DispatchException('Controller method does not exist');
303 303
         }
304 304
 
Please login to merge, or discard this patch.
Example/Routes/routes.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -28,10 +28,10 @@  discard block
 block discarded – undo
28 28
 $collection->addRoute('GET', '/path', 'myClass::myMethod', ['name']);
29 29
 $collection->addRoute('GET', '/another', 'another-handler', ['name']);
30 30
 
31
-$collection->group('/newPath', function () use ($collection, $something) {
31
+$collection->group('/newPath', function() use ($collection, $something) {
32 32
 
33 33
     //Add both POST and GET routes with Closure.
34
-    $collection->addRoute(['GET', 'POST'], '/new', function ($request) use ($something) {
34
+    $collection->addRoute(['GET', 'POST'], '/new', function($request) use ($something) {
35 35
         return $something;
36 36
     }, ['name']);
37 37
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 
40 40
 $collection->addRoute('GET', '/mypath', 'handler::string', ['name']);
41 41
 
42
-$collection->addRoute('GET', '/someproduct', function ($request) {
42
+$collection->addRoute('GET', '/someproduct', function($request) {
43 43
     return 'this is my response for ';
44 44
 }, ['name']);
45 45
 
Please login to merge, or discard this patch.
Tests/Router/Serializer/SuperClosureTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
      */
37 37
     public function testSerializeCalled()
38 38
     {
39
-        $data = function () {
39
+        $data = function() {
40 40
             return true;
41 41
         };
42 42
 
Please login to merge, or discard this patch.
Tests/Router/RouterTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
      */
70 70
     public function testGetRouterResponse()
71 71
     {
72
-        $request =  $this->getMockBuilder(ServerRequestInterface::class)->getMock();
72
+        $request = $this->getMockBuilder(ServerRequestInterface::class)->getMock();
73 73
 
74 74
         $method = 'GET';
75 75
         $path = '/path';
Please login to merge, or discard this patch.
Tests/Router/RouterResponseTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
     {
44 44
         $this->handler = 'handler';
45 45
         $this->code = 200;
46
-        $this->names = ['name','name2'];
46
+        $this->names = ['name', 'name2'];
47 47
         $this->vars = ['a' => 1, 'b' =>2];
48 48
         $this->routerResponse = new RouterResponse($this->code, $this->handler, $this->names, $this->vars);
49 49
     }
Please login to merge, or discard this patch.
Tests/Router/Loaders/Files/FileLoaderRoutesAlt.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 
7 7
 $collection = new \Ds\Router\RouteCollection();
8 8
 
9
-$collection->addRoute('GET', '/pathalt', function () use ($variable) {
9
+$collection->addRoute('GET', '/pathalt', function() use ($variable) {
10 10
     return $variable;
11 11
 }, ['name']);
12 12
 
Please login to merge, or discard this patch.
Tests/Router/Loaders/Files/FileLoaderRoutes.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 
7 7
 $collection = new \Ds\Router\RouteCollection();
8 8
 
9
-$collection->addRoute('GET', '/path', function () use ($variable) {
9
+$collection->addRoute('GET', '/path', function() use ($variable) {
10 10
     return $variable;
11 11
 }, ['name']);
12 12
 
Please login to merge, or discard this patch.
Tests/Router/Dispatcher/DispatcherTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
     public function testWithNamespaces()
34 34
     {
35 35
         $namespaces = [
36
-            '\my\namespace','another','one\more'
36
+            '\my\namespace', 'another', 'one\more'
37 37
         ];
38 38
 
39 39
         $expected = [
Please login to merge, or discard this patch.
Tests/Router/RouteTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
     /**
36 36
      * @var array
37 37
      */
38
-    protected $expectedNames = ['name-1','name-2'];
38
+    protected $expectedNames = ['name-1', 'name-2'];
39 39
 
40 40
     /**
41 41
      * Route setUp.
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
      */
82 82
     public function testWithNames()
83 83
     {
84
-        $expected = ['foo','bar','baz'];
84
+        $expected = ['foo', 'bar', 'baz'];
85 85
         $route = $this->route->withNames($expected);
86 86
         $this->assertSame(
87 87
             $expected,
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
      */
109 109
     public function testWithHandlerClosure()
110 110
     {
111
-        $expected = function () {
111
+        $expected = function() {
112 112
             return 'closure';
113 113
         };
114 114
         $route = $this->route->withHandler($expected);
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
      */
153 153
     public function testGetHandlerTypeClosure()
154 154
     {
155
-        $closure = function () {
155
+        $closure = function() {
156 156
         };
157 157
         $expected = 'object';
158 158
         $route = $this->route->withHandler($closure);
Please login to merge, or discard this patch.