djsmithme / Cache

Tests/Cache/CacheTest.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Ds\Cache\Cache;
 use Ds\Cache\CacheStorageInterface;
-use Ds\Cache\NullStorage;
 use Psr\SimpleCache\InvalidArgumentException;
 
 /**

Spacing +37 added lines, -37 removed lines

@@ -39,7 +39,7 @@ 
     {
         $key = 21021000;
         $this->expectException(InvalidArgumentException::class);
-        $this->cache->set($key,'value');
+        $this->cache->set($key, 'value');
     }
 
     /**
@@ -205,7 +205,7 @@ 
     /**
      *
      */
-    public function testGetMultiple(){
+    public function testGetMultiple() {
 
         $expected = [
             'foo' => 'fooValue',
@@ -215,7 +215,7 @@ 
 
         $i = 0;
 
-        foreach ($expected as $key => $value){
+        foreach ($expected as $key => $value) {
 
             $this->storageMock->expects($this->at($i))
                 ->method('get')
@@ -235,7 +235,7 @@ 
     /**
      *
      */
-    public function testSetMultiple(){
+    public function testSetMultiple() {
 
         $keys = [
             'foo' => 'fooValue',
@@ -249,7 +249,7 @@ 
         $i = 0;
         $expires = 60 * 60;
 
-        foreach ($keys as $key => $value){
+        foreach ($keys as $key => $value) {
             $this->storageMock->expects($this->at($i))
                 ->method('set')
                 ->with(
@@ -261,20 +261,20 @@ 
             $i++;
         }
 
-        $actual = $this->cache->setMultiple($keys,$expires);
+        $actual = $this->cache->setMultiple($keys, $expires);
         $this->assertEquals($expected, $actual);
     }
 
     /**
      *
      */
-    public function testDeleteMultiple(){
+    public function testDeleteMultiple() {
 
-        $keys = ['foo','bar','baz'];
+        $keys = ['foo', 'bar', 'baz'];
         $deleteStatus = true;
         $expected = true;
 
-        foreach ($keys as $i => $key){
+        foreach ($keys as $i => $key) {
             $this->storageMock->expects($this->at($i))
                 ->method('delete')
                 ->with(
@@ -290,15 +290,15 @@ 
     /**
      *
      */
-    public function testDeleteMultipleFailure(){
+    public function testDeleteMultipleFailure() {
 
-        $keys = ['foo','bar','baz'];
+        $keys = ['foo', 'bar', 'baz'];
         $expected = false;
         $deleteStatus = true;
 
-        foreach ($keys as $i => $key){
+        foreach ($keys as $i => $key) {
 
-            if ($i === 1){
+            if ($i === 1) {
                 $deleteStatus = false;
             }
 
@@ -317,7 +317,7 @@ 
     /**
      * Test that storage clear is called.
      */
-    public function testclear(){
+    public function testclear() {
         $this->storageMock->expects($this->once())
             ->method('clear');
         $this->cache->clear();
@@ -326,7 +326,7 @@ 
     /**
      * Test that array has keys.
      */
-    public function testArrayHasKeys(){
+    public function testArrayHasKeys() {
         $data = ['a' => 'foo', 'b' => 'bar'];
 
         $reflector = new \ReflectionClass(Cache::class);
@@ -340,9 +340,9 @@ 
     /**
      * Test exception thrown when array is missing keys.
      */
-    public function testArrayHasNoKeys(){
+    public function testArrayHasNoKeys() {
         $this->expectException(InvalidArgumentException::class);
-        $data = ['foo','bar'];
+        $data = ['foo', 'bar'];
         $reflector = new \ReflectionClass(Cache::class);
         $method = $reflector->getMethod('_hasKeys');
         $method->setAccessible(true);
@@ -352,8 +352,8 @@ 
     /**
      * Test array contains a failure.
      */
-    public function testHasFailure(){
-        $results = [true,true,true,false,true];
+    public function testHasFailure() {
+        $results = [true, true, true, false, true];
         $reflector = new \ReflectionClass(Cache::class);
         $method = $reflector->getMethod('_hasFailure');
         $method->setAccessible(true);
@@ -365,8 +365,8 @@ 
     /**
      * Test array doesn't contain a failure.
      */
-    public function testHasNoFailure(){
-        $results = [true,true,true,true,true];
+    public function testHasNoFailure() {
+        $results = [true, true, true, true, true];
         $reflector = new \ReflectionClass(Cache::class);
         $method = $reflector->getMethod('_hasFailure');
         $method->setAccessible(true);
@@ -378,8 +378,8 @@ 
     /**
      * Test that array is Traversable
      */
-    public function testIsTraversable(){
-        $data = ['a','b','c','d'];
+    public function testIsTraversable() {
+        $data = ['a', 'b', 'c', 'd'];
         $reflector = new \ReflectionClass(Cache::class);
         $method = $reflector->getMethod('_isTraversable');
         $method->setAccessible(true);
@@ -391,7 +391,7 @@ 
     /**
      * Test that string is not Traversable
      */
-    public function testIsNotTraversable(){
+    public function testIsNotTraversable() {
         $this->expectException(InvalidArgumentException::class);
         $data = 'some-random-string';
         $reflector = new \ReflectionClass(Cache::class);
@@ -403,13 +403,13 @@ 
     /**
      * Test that instance of Iterator is traversable
      */
-    public function testIsTraversableIterator(){
+    public function testIsTraversableIterator() {
         $iterator = new class implements \Iterator {
-            public function current(){}
-            public function next(){}
-            public function key(){}
-            public function valid(){}
-            public function rewind(){}
+            public function current() {}
+            public function next() {}
+            public function key() {}
+            public function valid() {}
+            public function rewind() {}
         };
         $reflector = new \ReflectionClass(Cache::class);
         $method = $reflector->getMethod('_isTraversable');
@@ -423,11 +423,11 @@ 
     /**
      * Private functions
      */
-    public function test_isValidKeyValid(){}
-    public function test_isValidKeyInvalid(){}
-    public function test_checkTraversableArray(){}
-    public function test_checkTraversableTraversable(){}
-    public function test_checkTraversableException(){}
-    public function test_hasFailureNoFailure(){}
-    public function test_hasFailureException(){}
+    public function test_isValidKeyValid() {}
+    public function test_isValidKeyInvalid() {}
+    public function test_checkTraversableArray() {}
+    public function test_checkTraversableTraversable() {}
+    public function test_checkTraversableException() {}
+    public function test_hasFailureNoFailure() {}
+    public function test_hasFailureException() {}
 }

Tests/Cache/Mock/AbstractCacheMock.php

Spacing +1 added lines, -1 removed lines

@@ -11,5 +11,5 @@
  *
  * @package Tests\Cache\Mock
  */
-class AbstractCacheMock extends AbstractCache{
+class AbstractCacheMock extends AbstractCache {
 }
\ No newline at end of file

Tests/Cache/Mock/AbstractStorageMock.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
  *
  * @package Tests\Cache\Mock
  */
-class AbstractStorageMock extends AbstractStorage{
+class AbstractStorageMock extends AbstractStorage {
 
     public function set($key, $value, $ttl = null)
     {

Tests/Cache/Storage/MemcacheStorageTest.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     {
         $this->ttl = new \DateInterval('P1M');
         $this->memcacheMock = $this->getMockBuilder('\Memcached')->getMock();
-        $this->memcacheStorage = new MemcacheStorage($this->memcacheMock,'localhost',11211, $this->ttl);
+        $this->memcacheStorage = new MemcacheStorage($this->memcacheMock, 'localhost', 11211, $this->ttl);
     }
 
     public function testAddServer()

Tests/Cache/Storage/NullStorageTest.php

Spacing +5 added lines, -5 removed lines

@@ -28,35 +28,35 @@
     /**
      *
      */
-    public function testHas(){
+    public function testHas() {
         $this->assertEquals($this->cacheStorage->has('key', 'value'), false);
     }
 
     /**
      *
      */
-    public function testSet(){
+    public function testSet() {
         $this->assertEquals($this->cacheStorage->set('key', 'value', 10), true);
     }
 
     /**
      *
      */
-    public function testGet(){
+    public function testGet() {
         $this->assertEquals($this->cacheStorage->get('key'), null);
     }
 
     /**
      *
      */
-    public function testDelete(){
+    public function testDelete() {
         $this->assertEquals($this->cacheStorage->delete('key'), true);
     }
 
     /**
      *
      */
-    public function testClear(){
+    public function testClear() {
         $this->assertEquals($this->cacheStorage->clear(), true);
     }
     

Tests/Cache/Storage/AbstractStorageTest.php

Spacing +6 added lines, -6 removed lines

@@ -33,7 +33,7 @@ 
     /**
      * Test immutable setter AbstractStorage::withTtl
      */
-    public function testWithTtl(){
+    public function testWithTtl() {
         $newDateInterval = new \DateInterval('P2M');
         $newTtl = $this->abstractStorage->withTtl($newDateInterval);
         $this->assertNotSame($this->abstractStorage->getTtl(), $newTtl->getTtl());
@@ -42,7 +42,7 @@ 
     /**
      * Test getter AbstractStorage::getTtl
      */
-    public function testGetTtl(){
+    public function testGetTtl() {
         $ttl = $this->abstractStorage->getTtl();
         $this->assertSame($this->ttl, $ttl);
     }
@@ -50,9 +50,9 @@ 
     /**
      * Get get ttl when provided with null
      */
-    public function testGetTtlTimestampWhenNull(){
+    public function testGetTtlTimestampWhenNull() {
         $dateTime = new \DateTime();
-        $dateTime->add( $this->ttl );
+        $dateTime->add($this->ttl);
         $expected = $dateTime->getTimestamp();
         $actual = $this->abstractStorage->getTtlTimestamp(null);
         $this->assertEquals($expected, $actual);
@@ -61,8 +61,8 @@ 
     /**
      * Test get ttl when provided with an integer.
      */
-    public function testGetTtlTimestampWhenInt(){
-        $expected = 60*60*7;
+    public function testGetTtlTimestampWhenInt() {
+        $expected = 60 * 60 * 7;
         $actual = $this->abstractStorage->getTtlTimestamp($expected);
         $this->assertEquals($expected, $actual);
     }

Tests/Cache/AbstractCacheTest.php

Spacing +4 added lines, -4 removed lines

@@ -31,19 +31,19 @@
     /**
      * Test that NullStorage Adaptor is called by default.
      */
-    public function testConstructNullStorage(){
+    public function testConstructNullStorage() {
         $cache = new Cache();
         $storage = $cache->getCacheStorage();
-        $this->assertInstanceOf(NullStorage::class,$storage);
+        $this->assertInstanceOf(NullStorage::class, $storage);
     }
 
     /**
      * Test CacheStorage is updated from construct.
      */
-    public function testConstructWithStorage(){
+    public function testConstructWithStorage() {
         $cache = new Cache($this->storageMock);
         $storage = $cache->getCacheStorage();
-        $this->assertSame($this->storageMock,$storage);
+        $this->assertSame($this->storageMock, $storage);
     }
 
     /**

Src/Cache/Storage/MemcacheStorage.php

Spacing +3 added lines, -3 removed lines

@@ -67,8 +67,8 @@ 
      *
      * @return bool
      */
-    public function has($key){
-        if (!empty($this->mmc->get($key))){
+    public function has($key) {
+        if (!empty($this->mmc->get($key))) {
             return true;
         }
         return false;
@@ -113,7 +113,7 @@ 
      *
      * @return bool True on success and false on failure.
      */
-    public function clear(){
+    public function clear() {
         return $this->flush();
     }
 

Src/Cache/Storage/NullStorage.php

Spacing +4 added lines, -4 removed lines

@@ -22,7 +22,7 @@ 
     /**
      * NullStorage constructor.
      */
-    public function __construct(){}
+    public function __construct() {}
 
     /**
      * Persists data in the cache, uniquely referenced by a key with an optional expiration TTL time.
@@ -48,7 +48,7 @@ 
      * @return mixed The value of the item from the cache, or $default in case of cache miss.
      *
      */
-    public function get($key){
+    public function get($key) {
         return null;
     }
 
@@ -64,7 +64,7 @@ 
      *
      * @return bool
      */
-    public function has($key){
+    public function has($key) {
         return false;
     }
 
@@ -85,7 +85,7 @@ 
      *
      * @return bool True on success and false on failure.
      */
-    public function clear(){
+    public function clear() {
         return true;
     }
 }