dimaxz / SimpleORM

src/Adapter/CodeigniterQueryBuilder.php

Doc Comments +6 added lines, -4 removed lines

@@ -66,6 +66,9 @@ 
 		return $this->adapter->delete($table,$where);
 	}
 
+	/**
+	 * @param string $str
+	 */
 	protected function escape_str($str, $like = FALSE)
 	{
 
@@ -120,7 +123,6 @@ 
 	
 	/**
 	 * 
-	 * @param type $param
 	 */
 	public function getResultQuery($table,\SimpleORM\ISpecificationCriteria $Criteria ) {
 		
@@ -155,7 +157,7 @@ 
 	/**
 	 * Создает селект не только для основной таблицы но и для приджойненых таблиц
 	 * @param type $joins
-	 * @return type
+	 * @return string
 	 */
 	protected function createSelect($joins)
 	{
@@ -171,8 +173,8 @@ 
 	/**
 	 * Получение записей по условию
 	 * @param type $where
-	 * @param type $limit
-	 * @param type $offset
+	 * @param integer $limit
+	 * @param integer $offset
 	 * @param type $joins
 	 * @param type $order
 	 * @param type $manualJoins

Spacing +53 added lines, -53 removed lines

@@ -38,9 +38,9 @@ 
 	protected function escape($str)
 	{
 		if (is_string($str)) {
-			$str = "'" . $this->escape_str($str) . "'";
+			$str = "'".$this->escape_str($str)."'";
 		} elseif (is_bool($str)) {
-			$str = ($str === FALSE) ? 0 : 1;
+			$str = ($str===FALSE) ? 0 : 1;
 		} elseif (is_null($str)) {
 			$str = 'NULL';
 		}
@@ -48,13 +48,13 @@ 
 		return $str;
 	}
 	
-	public function update($table,array $data,$where = []){
-		return $this->adapter->update($table,$data,$where);
+	public function update($table, array $data, $where = []) {
+		return $this->adapter->update($table, $data, $where);
 	}
 	
-	public function insert($table,array $data)
+	public function insert($table, array $data)
 	{
-		return $this->adapter->insert($table,$data);
+		return $this->adapter->insert($table, $data);
 	}
 	
 	public function insert_id()
@@ -62,17 +62,17 @@ 
 		return $this->adapter->insert_id();
 	}
 
-	public function delete($table,$where = []){
-		return $this->adapter->delete($table,$where);
+	public function delete($table, $where = []) {
+		return $this->adapter->delete($table, $where);
 	}
 
 	protected function escape_str($str, $like = FALSE)
 	{
 
-		if(!$like){
+		if (!$like) {
 			return $this->adapter->escape_str($str);
 		}
-		else{
+		else {
 			return $this->adapter->escape_like_str($str);
 		}	
 		
@@ -111,8 +111,8 @@ 
 			throw new HttpException('You cannot have an empty field name.');
 		}
 
-		if (strpos($field, '.') === false) {
-			return $this->TableName . '.' . $field;
+		if (strpos($field, '.')===false) {
+			return $this->TableName.'.'.$field;
 		}
 
 		return $field;
@@ -122,7 +122,7 @@ 
 	 * 
 	 * @param type $param
 	 */
-	public function getResultQuery($table,\SimpleORM\ISpecificationCriteria $Criteria ) {
+	public function getResultQuery($table, \SimpleORM\ISpecificationCriteria $Criteria) {
 		
 		$this->setTable($table);
 		
@@ -141,12 +141,12 @@ 
 		return $res;		
 	}
 
-	protected function setTable($table){
-		if(preg_match('~(.*?)\.(.*?)$~is',$table,$m)){
+	protected function setTable($table) {
+		if (preg_match('~(.*?)\.(.*?)$~is', $table, $m)) {
 			$this->database = $m[1];
 			$this->TableName = $m[2];
 		}
-		else{
+		else {
 			$this->TableName = $table;
 		}		
 	}	
@@ -159,9 +159,9 @@ 
 	 */
 	protected function createSelect($joins)
 	{
-		$s = "`" . $this->TableName . '`.*';
+		$s = "`".$this->TableName.'`.*';
 		foreach ($joins as $table => $join) {
-			$table = isset($join['alias']) ? "`{$join['alias']}`": $table;
+			$table = isset($join['alias']) ? "`{$join['alias']}`" : $table;
 			$s .= ", $table.*";
 		}
 		return $s;
@@ -184,8 +184,8 @@ 
 	 */
 	protected function buildQuery($where = array(), $limit = 25, $offset = 0, $joins = array(), $order = array(), $manualJoins = array(), $group = null, $manualWheres = array(), $whereType = 'AND')
 	{
-		$table = !empty($this->database)? "`{$this->database}`.".$this->TableName : $this->TableName;
-		$query = 'SELECT ' . $this->createSelect($joins) . " FROM `".$table."`";
+		$table = !empty($this->database) ? "`{$this->database}`.".$this->TableName : $this->TableName;
+		$query = 'SELECT '.$this->createSelect($joins)." FROM `".$table."`";
 		//$countQuery = "SELECT COUNT(*) AS cnt FROM `{$this->database}`.".$this->getTableName();
 
 		$wheres = array();
@@ -195,15 +195,15 @@ 
 
 			if (!is_array($value)) {
 				$params[] = $value;
-				$wheres[] = $key . ' = ?';
+				$wheres[] = $key.' = ?';
 			} else {
 				if (isset($value['operator'])) {
 					if (is_array($value['value'])) {
-						if ($value['operator'] == 'between') {
+						if ($value['operator']=='between') {
 							$params[] = $value['value'][0];
 							$params[] = $value['value'][1];
-							$wheres[] = $key . ' BETWEEN ? AND ?';
-						} elseif ($value['operator'] == 'IN') {
+							$wheres[] = $key.' BETWEEN ? AND ?';
+						} elseif ($value['operator']=='IN') {
 							$in = array();
 
 							foreach ($value['value'] as $item) {
@@ -211,67 +211,67 @@ 
 								$in[] = '?';
 							}
 
-							$wheres[] = $key . ' IN (' . implode(', ', $in) . ') ';
+							$wheres[] = $key.' IN ('.implode(', ', $in).') ';
 						} else {
 							$ors = array();
 							foreach ($value['value'] as $item) {
-								if ($item == 'null') {
+								if ($item=='null') {
 									switch ($value['operator']) {
 										case '!=':
-											$ors[] = $key . ' IS NOT NULL';
+											$ors[] = $key.' IS NOT NULL';
 											break;
 
 										case '==':
 										default:
-											$ors[] = $key . ' IS NULL';
+											$ors[] = $key.' IS NULL';
 											break;
 									}
 								} else {
 									$params[] = $item;
-									$ors[] = $this->fieldCheck($key) . ' ' . $value['operator'] . ' ?';
+									$ors[] = $this->fieldCheck($key).' '.$value['operator'].' ?';
 								}
 							}
-							$wheres[] = '(' . implode(' OR ', $ors) . ')';
+							$wheres[] = '('.implode(' OR ', $ors).')';
 						}
 					} else {
-						if ($value['operator'] == 'like') {
-							$params[] = '%' . $value['value'] . '%';
-							$wheres[] = $key . ' ' . $value['operator'] . ' ?';
+						if ($value['operator']=='like') {
+							$params[] = '%'.$value['value'].'%';
+							$wheres[] = $key.' '.$value['operator'].' ?';
 						} else {
-							if ($value['value'] === 'null') {
+							if ($value['value']==='null') {
 								switch ($value['operator']) {
 									case '!=':
-										$wheres[] = $key . ' IS NOT NULL';
+										$wheres[] = $key.' IS NOT NULL';
 										break;
 
 									case '==':
 									default:
-										$wheres[] = $key . ' IS NULL';
+										$wheres[] = $key.' IS NULL';
 										break;
 								}
 							} else {
 								$params[] = $value['value'];
-								$wheres[] = $key . ' ' . $value['operator'] . ' ?';
+								$wheres[] = $key.' '.$value['operator'].' ?';
 							}
 						}
 					}
 				} else {
-					$wheres[] = $key . ' IN (' . implode(', ', array_map(array($this, 'escape'), $value)) . ')';
+					$wheres[] = $key.' IN ('.implode(', ', array_map(array($this, 'escape'), $value)).')';
 				}
 			}
 		}
 
 		if (count($joins)) {
 			foreach ($joins as $table => $join) {
-				$type = isset($join['type'])?$join['type']:'INNER';
-				$query .= ' '. $type.' JOIN `' . $table . '` as `' . $join['alias'] . '` ON ' . $join['on'] . ' ';
+				$type = isset($join['type']) ? $join['type'] : 'INNER';
+				$query .= ' '.$type.' JOIN `'.$table.'` as `'.$join['alias'].'` ON '.$join['on'].' ';
 				//$countQuery .= ' '.$type.' JOIN ' . $table . ' ' . $join['alias'] . ' ON ' . $join['on'] . ' ';
 			}
 		}
 
 		if (count($manualJoins)) {
 			foreach ($manualJoins as $join) {
-				$query .= ' ' . $join . ' ';
+				$query .= ' '.$join.' ';
 				//$countQuery .= ' ' . $join . ' ';
 			}
 		}
@@ -279,7 +279,7 @@ 
 		$hasWhere = false;
 		if (count($wheres)) {
 			$hasWhere = true;
-			$query .= ' WHERE (' . implode(' ' . $whereType . ' ', $wheres) . ')';
+			$query .= ' WHERE ('.implode(' '.$whereType.' ', $wheres).')';
 			//$countQuery .= ' WHERE (' . implode(' ' . $whereType . ' ', $wheres) . ')';
 		}
 
@@ -290,11 +290,11 @@ 
 					$query .= ' WHERE ';
 					//$countQuery .= ' WHERE ';
 				} else {
-					$query .= ' ' . $where['type'] . ' ';
+					$query .= ' '.$where['type'].' ';
 					//$countQuery .= ' ' . $where['type'] . ' ';
 				}
 
-				$query .= ' ' . $where['query'];
+				$query .= ' '.$where['query'];
 				//$countQuery .= ' ' . $where['query'];
 
 				if (isset($where['params'])) {
@@ -306,28 +306,28 @@ 
 		}
 
 		if (!is_null($group)) {
-			$query .= ' GROUP BY ' . $group . ' ';
+			$query .= ' GROUP BY '.$group.' ';
 		}
 
 		if (count($order)) {
 			$orders = array();
-			if (is_string($order) && $order == 'rand') {
+			if (is_string($order) && $order=='rand') {
 				$query .= ' ORDER BY RAND() ';
 			} else {
 				foreach ($order as $key => $value) {
-					$orders[] = $this->fieldCheck($key) . ' ' . $value;
+					$orders[] = $this->fieldCheck($key).' '.$value;
 				}
 
-				$query .= ' ORDER BY ' . implode(', ', $orders);
+				$query .= ' ORDER BY '.implode(', ', $orders);
 			}
 		}
 
 		if ($limit) {
-			$query .= ' LIMIT ' . $limit;
+			$query .= ' LIMIT '.$limit;
 		}
 
 		if ($offset) {
-			$query .= ' OFFSET ' . $offset;
+			$query .= ' OFFSET '.$offset;
 		}
 
 
@@ -345,7 +345,7 @@ 
 		try {
 			//$query = $this->compile_binds($query, $params);
 			
-			return $this->adapter->query($query,$params);
+			return $this->adapter->query($query, $params);
 			//ed( $this->adapter->query($query) ,1);
 //			if ($res = $this->adapter->getRows($query)) {
 //				$rtn = array();
@@ -359,7 +359,7 @@ 
 //			} else {
 //				return false;
 //			}
-		} catch(\PDOException $ex) {
+		} catch (\PDOException $ex) {
 			throw $ex;
 		}
 	}	
@@ -374,7 +374,7 @@ 
 	 */
 	protected function compile_binds($sql, $binds)
 	{
-		if (strpos($sql, $this->bind_marker) === FALSE) {
+		if (strpos($sql, $this->bind_marker)===FALSE) {
 			return $sql;
 		}
 

Braces +2 added lines, -4 removed lines

@@ -71,8 +71,7 @@ 
 
 		if(!$like){
 			return $this->adapter->escape_str($str);
-		}
-		else{
+		} else{
 			return $this->adapter->escape_like_str($str);
 		}	
 		
@@ -145,8 +144,7 @@ 
 		if(preg_match('~(.*?)\.(.*?)$~is',$table,$m)){
 			$this->database = $m[1];
 			$this->TableName = $m[2];
-		}
-		else{
+		} else{
 			$this->TableName = $table;
 		}		
 	}	

tests/bootstrap.php

Doc Comments +7 added lines, -3 removed lines

@@ -5,8 +5,8 @@ 
     
     /**
      * получение защищенного свойства
-     * @param type $o
-     * @param type $name
+     * @param string $name
+     * @param SimpleORM\AbstractDataMapper $obj
      * @return type
      */
     static public function getProtectedAttribute($obj, $name)
@@ -20,7 +20,7 @@ 
     /**
      * Добавление значения в защищенное свойтсво
      * @param type $name
-     * @param type $valued 
+     * @param type $value 
      */
     private function setValueprotectedProperty($name, $value)
     {
@@ -30,6 +30,10 @@ 
         $r->setValue($this->object, $value); //изменяем значение
     }    
 	
+	/**
+	 * @param SimpleORM\AbstractDataMapper $obj
+	 * @param string $name
+	 */
 	static public function callMethod($obj, $name, array $args) {
         $class = new \ReflectionClass($obj);
         $method = $class->getMethod($name);

Indentation +30 added lines, -30 removed lines

@@ -3,38 +3,38 @@
 
 class TestHelper{
     
-    /**
-     * получение защищенного свойства
-     * @param type $o
-     * @param type $name
-     * @return type
-     */
-    static public function getProtectedAttribute($obj, $name)
-    {
-        $reflectionClass = new \ReflectionClass($obj); //создаем reflectionClass
-        $r = $reflectionClass->getProperty($name); //получаем свойство
-        $r->setAccessible(true); //делаем открытым
-        return $r->getValue($obj);
-    }
+	/**
+	 * получение защищенного свойства
+	 * @param type $o
+	 * @param type $name
+	 * @return type
+	 */
+	static public function getProtectedAttribute($obj, $name)
+	{
+		$reflectionClass = new \ReflectionClass($obj); //создаем reflectionClass
+		$r = $reflectionClass->getProperty($name); //получаем свойство
+		$r->setAccessible(true); //делаем открытым
+		return $r->getValue($obj);
+	}
 
-    /**
-     * Добавление значения в защищенное свойтсво
-     * @param type $name
-     * @param type $valued 
-     */
-    private function setValueprotectedProperty($name, $value)
-    {
-        $reflectionClass = new \ReflectionClass($this->object); //создаем reflectionClass
-        $r = $reflectionClass->getProperty($name); //получаем свойство
-        $r->setAccessible(true); //делаем открытым
-        $r->setValue($this->object, $value); //изменяем значение
-    }    
+	/**
+	 * Добавление значения в защищенное свойтсво
+	 * @param type $name
+	 * @param type $valued 
+	 */
+	private function setValueprotectedProperty($name, $value)
+	{
+		$reflectionClass = new \ReflectionClass($this->object); //создаем reflectionClass
+		$r = $reflectionClass->getProperty($name); //получаем свойство
+		$r->setAccessible(true); //делаем открытым
+		$r->setValue($this->object, $value); //изменяем значение
+	}    
 	
 	static public function callMethod($obj, $name, array $args) {
-        $class = new \ReflectionClass($obj);
-        $method = $class->getMethod($name);
-        $method->setAccessible(true);
-        return $method->invokeArgs($obj, $args);
-    }	
+		$class = new \ReflectionClass($obj);
+		$method = $class->getMethod($name);
+		$method->setAccessible(true);
+		return $method->invokeArgs($obj, $args);
+	}	
     
 }

Spacing +1 added lines, -1 removed lines

@@ -1,7 +1,7 @@
 <?php
 $loader = require_once __DIR__.'/../vendor/autoload.php';
 
-class TestHelper{
+class TestHelper {
     
     /**
      * получение защищенного свойства

src/AbstractDataMapper.php

Indentation +22 added lines, -22 removed lines

@@ -19,7 +19,7 @@ 
 	 * таблица для сущности
 	 * @var type 
 	 */
-    protected $entityTable;	
+	protected $entityTable;	
 
 	/**
 	 * первичный ключ
@@ -88,9 +88,9 @@ 
 
 	abstract protected function setMappingFields();	
 	
-    public function getAdapter() {
-        return $this->adapter;
-    }
+	public function getAdapter() {
+		return $this->adapter;
+	}
 
 	public function setAdapter(QueryBuilderInterface $adapter){
 		 $this->adapter = $adapter;
@@ -109,12 +109,12 @@ 
 	}	
 
 
-    public function findById($id)
-    {
+	public function findById($id)
+	{
 		$Criteria = (new Specification())->setWhere($this->key , $id);
 		
-        return $this->findBySpecification($Criteria);
-    }	
+		return $this->findBySpecification($Criteria);
+	}	
 	
 	/**
 	 * Cохранение сущности
@@ -199,7 +199,7 @@ 
 	 */
 	protected function buildEntity(EntityInterface $Entity, array $row){
 		
-        foreach ($this->mapping_fields as $alias => $cfg ) {
+		foreach ($this->mapping_fields as $alias => $cfg ) {
 			
 			$value = false;
 			
@@ -236,9 +236,9 @@ 
 			if($value!==false)
 				$Entity->{$method_set}($value);
 			
-        }
+		}
 		
-        return $Entity;		
+		return $Entity;		
 	}	
 
 	
@@ -252,7 +252,7 @@ 
 		
 		$row = [];
 
-        foreach ($this->mapping_fields as $alias => $cfg ) {
+		foreach ($this->mapping_fields as $alias => $cfg ) {
 			
 			$field = $cfg['field'];
 			
@@ -282,9 +282,9 @@ 
 						
 			$row[$field] = $value;
 
-        }
+		}
 
-        return $row;		
+		return $row;		
 	}	
 	
 	/**
@@ -356,10 +356,10 @@ 
 		//получение записей
 		$res = $this->getAdapter()->getResultQuery($this->getEntityTable(),$specification);
 
-        if (!$row = $res->row_array()) {
-            return null;
-        }
-        return $this->createEntity($row);				
+		if (!$row = $res->row_array()) {
+			return null;
+		}
+		return $this->createEntity($row);				
 	}
 	
 	/**
@@ -401,8 +401,8 @@ 
 		$res = $this->getAdapter()->getResultQuery($this->getEntityTable(),$specification);
 		
 		if (!$rows = $res->result_array()) {
-            return null;
-        }	
+			return null;
+		}	
 		
 		foreach($rows as $k =>  $row){
 			$rows[$k] = $this->createEntity($row);
@@ -430,8 +430,8 @@ 
 	}
 	
 		/**
-	 * Построение join-ов
-	 */
+		 * Построение join-ов
+		 */
 	protected function setRelations(ISpecificationCriteria $Specification){
 
 		$joins = [];

Spacing +57 added lines, -57 removed lines

@@ -80,7 +80,7 @@ 
 		
 		$this->setEntityTable($db_name);
 		
-		if($this->getEntityTable()=='' || $this->getPrimaryKey()==''){
+		if ($this->getEntityTable()=='' || $this->getPrimaryKey()=='') {
 			throw new InvalidEntityPropertyException('Свойства entityTable или key не заданы');
 		}		
 		
@@ -92,7 +92,7 @@ 
         return $this->adapter;
     }
 
-	public function setAdapter(QueryBuilderInterface $adapter){
+	public function setAdapter(QueryBuilderInterface $adapter) {
 		 $this->adapter = $adapter;
 	}
 			
@@ -105,13 +105,13 @@ 
 	 * Уставнока таблицы
 	 */
 	protected function setEntityTable($db_name) {
-		$this->entityTable = !empty($db_name)? "$db_name.".$this->table : $this->table;
+		$this->entityTable = !empty($db_name) ? "$db_name.".$this->table : $this->table;
 	}	
 
 
     public function findById($id)
     {
-		$Criteria = (new Specification())->setWhere($this->key , $id);
+		$Criteria = (new Specification())->setWhere($this->key, $id);
 		
         return $this->findBySpecification($Criteria);
     }	
@@ -133,7 +133,7 @@ 
 			
 			unset($data[$this->setSoftDeleteKey()]);
 			
-			$this->db->insert($this->getEntityTable(),$data);
+			$this->db->insert($this->getEntityTable(), $data);
 			
 			if (!$id = $this->db->insert_id()) {
 				return false;
@@ -144,13 +144,13 @@ 
 		//update
 		else {
 			
-			if(!$this->getAdapter()->update($this->getEntityTable(), $data, "{$this->getPrimaryKey()} = '{$id}'")){
+			if (!$this->getAdapter()->update($this->getEntityTable(), $data, "{$this->getPrimaryKey()} = '{$id}'")) {
 				return false;
 			}
 
 		}		
 		
-		if(method_exists($this, 'onSaveSuccess' )){ return $this->onSaveSuccess( $Entity );}
+		if (method_exists($this, 'onSaveSuccess')) { return $this->onSaveSuccess($Entity); }
 		
 		return true;
 	}
@@ -159,12 +159,12 @@ 
 	 * На успешное сохранение
 	 * @param \SimpleORM\EntityInterface $Entity
 	 */
-	protected function onSaveSuccess(EntityInterface $Entity){
+	protected function onSaveSuccess(EntityInterface $Entity) {
 		
 		
 		foreach ($this->relations as $alias => $mapper) {
 			$Entity = $Entity->{'get'.$alias}();
-			if(!$mapper->save($Entity)){
+			if (!$mapper->save($Entity)) {
 				throw new \Autoprice\Exceptions\EntityNotSaveException('Unable to save Entity!');
 			}
 		}
@@ -179,7 +179,7 @@ 
 	protected function onDeleteSuccess(EntityInterface $Entity) {
 		foreach ($this->relations as $alias => $mapper) {
 			$Entity = $Entity->{'get'.$alias}();
-			if(!$mapper->delete($Entity)){
+			if (!$mapper->delete($Entity)) {
 				throw new \Autoprice\Exceptions\EntityNotDeleteException('Unable to delete Entity!');
 			}
 		}
@@ -197,43 +197,43 @@ 
 	 * @return \Core\Infrastructure\EntityInterface
 	 * @throws BadMethodCallException
 	 */
-	protected function buildEntity(EntityInterface $Entity, array $row){
+	protected function buildEntity(EntityInterface $Entity, array $row) {
 		
-        foreach ($this->mapping_fields as $alias => $cfg ) {
+        foreach ($this->mapping_fields as $alias => $cfg) {
 			
 			$value = false;
 			
 			$field = $cfg['field'];
 			
-			$method_set = 'set' . ucfirst($alias);
+			$method_set = 'set'.ucfirst($alias);
 			
-			if(!method_exists($Entity, $method_set )){
+			if (!method_exists($Entity, $method_set)) {
 				throw new BadMethodCallException("Метод {$method_set}  не определен");
 			}			
 			
 			//событие на формирование поля
-			if( isset($cfg['build']) && is_object($cfg['build']) ){
+			if (isset($cfg['build']) && is_object($cfg['build'])) {
 				$value = call_user_func($cfg['build'], $row);
 			}
 			//на связь
-			elseif(isset($cfg['relation'])){
+			elseif (isset($cfg['relation'])) {
 				
 				$mapper = $this->DI->get($cfg['relation']);
 				
-				if($this->use_joins===true){
+				if ($this->use_joins===true) {
 					$value = $mapper->createEntity($row);
 				}
-				else{
-					$fkey = isset($cfg['on']) ? $cfg['on'] :$mapper->key;
+				else {
+					$fkey = isset($cfg['on']) ? $cfg['on'] : $mapper->key;
 					$value = $mapper->findBySpecification((new Specification)->setWhere($fkey, $row[$field]));
 				}				
 				
 			}
-			elseif(is_string($field) && isset($row[strtolower($field)])){
+			elseif (is_string($field) && isset($row[strtolower($field)])) {
 				$value = $row[strtolower($field)];
 			}
 			
-			if($value!==false)
+			if ($value!==false)
 				$Entity->{$method_set}($value);
 			
         }
@@ -248,27 +248,27 @@ 
 	 * @return \Core\Infrastructure\EntityInterface
 	 * @throws BadMethodCallException
 	 */
-	protected function unbuildEntity(EntityInterface $Entity){
+	protected function unbuildEntity(EntityInterface $Entity) {
 		
 		$row = [];
 
-        foreach ($this->mapping_fields as $alias => $cfg ) {
+        foreach ($this->mapping_fields as $alias => $cfg) {
 			
 			$field = $cfg['field'];
 			
-			$method_get = 'get' . ucfirst($alias);
+			$method_get = 'get'.ucfirst($alias);
 			
-			if(!method_exists($Entity, $method_get )){
+			if (!method_exists($Entity, $method_get)) {
 				throw new BadMethodCallException("Метод {$method_get}  не определен");
 			}		
 			
 			//--------------------------------------------------------------------
-			if( isset($cfg['unbuild']) && is_object($cfg['unbuild']) ){
-				$value = call_user_func($cfg['unbuild'], $Entity->{$method_get}() );
+			if (isset($cfg['unbuild']) && is_object($cfg['unbuild'])) {
+				$value = call_user_func($cfg['unbuild'], $Entity->{$method_get}());
 			}
-			elseif(isset($cfg['relation'])){
+			elseif (isset($cfg['relation'])) {
 				
-				if(isset($cfg['on']))
+				if (isset($cfg['on']))
 					$fkey = $this->DI->get($cfg['relation'])->getFieldAlias($cfg['on']);
 				else
 					$fkey = 'id';
@@ -276,7 +276,7 @@ 
 				$value = $Entity->{$method_get}()->{'get'.$fkey}();
 				
 			}			
-			else{
+			else {
 				$value = $Entity->{$method_get}();
 			}			
 						
@@ -290,22 +290,22 @@ 
 	/**
 	 * Установка поля для маппинга
 	 */
-	protected function addMappingField($alias,$field = null){
+	protected function addMappingField($alias, $field = null) {
 		
-		if(is_string($field)){
+		if (is_string($field)) {
 			$field = ['field'	=>	$field];
 		}
-		elseif( (is_array($field) && !isset($field['field'])) || empty($field)){
-			$field['field']	= $alias;
+		elseif ((is_array($field) && !isset($field['field'])) || empty($field)) {
+			$field['field'] = $alias;
 		}
 	
 		$this->mapping_fields[$alias] = $field;
 
-		if(isset($field['primary']) && $field['primary']===true){
+		if (isset($field['primary']) && $field['primary']===true) {
 			$this->key = $field['field'];
 		}
 		
-		if(isset($field['softdelete']) && $field['softdelete']===true){
+		if (isset($field['softdelete']) && $field['softdelete']===true) {
 			$this->soft_delete_key = $field['field'];
 		}
 		
@@ -332,7 +332,7 @@ 
 
 
 	
-	public function getFieldAlias($field){
+	public function getFieldAlias($field) {
 		
 		return $this->mapping_fields_aliases[$field];
 		
@@ -344,7 +344,7 @@ 
 	 * @param ISpecificationCriteria $specification
 	 * @return type
 	 */
-	public function findBySpecification(ISpecificationCriteria $specification){
+	public function findBySpecification(ISpecificationCriteria $specification) {
 
 		//псеводо удаление
 		$this->setSoftDelete($specification);
@@ -354,7 +354,7 @@ 
 		$specification->setLimit(1);
 		
 		//получение записей
-		$res = $this->getAdapter()->getResultQuery($this->getEntityTable(),$specification);
+		$res = $this->getAdapter()->getResultQuery($this->getEntityTable(), $specification);
 
         if (!$row = $res->row_array()) {
             return null;
@@ -375,13 +375,13 @@ 
 		
 		if (
 				$delete_key > '' && 
-				$Entity->getId() > 0){
-				$result = $this->db->update($this->getEntityTable(), [ $delete_key => 1 ], "{$this->getPrimaryKey()} = '{$Entity->getId()}'");
+				$Entity->getId() > 0) {
+				$result = $this->db->update($this->getEntityTable(), [$delete_key => 1], "{$this->getPrimaryKey()} = '{$Entity->getId()}'");
 		}
-		elseif($Entity->getId() > 0){
+		elseif ($Entity->getId() > 0) {
 			
-			if($result = $this->db->delete($this->getEntityTable(), $this->getPrimaryKey()."  = ".$Entity->getId())){
-				if(method_exists($this, 'onDeleteSuccess' )){ $result = $this->onDeleteSuccess( $Entity );}
+			if ($result = $this->db->delete($this->getEntityTable(), $this->getPrimaryKey()."  = ".$Entity->getId())) {
+				if (method_exists($this, 'onDeleteSuccess')) { $result = $this->onDeleteSuccess($Entity); }
 			}
 		}
 		
@@ -398,13 +398,13 @@ 
 		
 		$this->setRelations($specification);
 		
-		$res = $this->getAdapter()->getResultQuery($this->getEntityTable(),$specification);
+		$res = $this->getAdapter()->getResultQuery($this->getEntityTable(), $specification);
 		
 		if (!$rows = $res->result_array()) {
             return null;
         }	
 		
-		foreach($rows as $k =>  $row){
+		foreach ($rows as $k =>  $row) {
 			$rows[$k] = $this->createEntity($row);
 		}
 		
@@ -420,30 +420,30 @@ 
 	 * Выборка удаленных моделей
 	 * @param ISpecificationCriteria $specification
 	 */
-	private function setSoftDelete(ISpecificationCriteria $specification){
-		if(
-				$this->use_delete === false &&
-				$this->setSoftDeleteKey()>'' 
+	private function setSoftDelete(ISpecificationCriteria $specification) {
+		if (
+				$this->use_delete===false &&
+				$this->setSoftDeleteKey() > '' 
 				&& !isset($specification->getWhere()[$this->setSoftDeleteKey()])
 				)
-		$specification->setWhere($this->setSoftDeleteKey(),0);
+		$specification->setWhere($this->setSoftDeleteKey(), 0);
 	}
 	
 		/**
 	 * Построение join-ов
 	 */
-	protected function setRelations(ISpecificationCriteria $Specification){
+	protected function setRelations(ISpecificationCriteria $Specification) {
 
 		$joins = [];
 
-		foreach ($this->mapping_fields as $field => $cfg){
-			if(isset($cfg['relation'])){
+		foreach ($this->mapping_fields as $field => $cfg) {
+			if (isset($cfg['relation'])) {
 				
 				$this->relations[$field] = $mapper = $this->DI->get($cfg['relation']);
 
 				$table = $mapper->getEntityTable();
 
-				$relation_key = isset($cfg['on'])? $cfg['on'] : $mapper->key;
+				$relation_key = isset($cfg['on']) ? $cfg['on'] : $mapper->key;
 				
 				$joins[$table] = [
 						'alias'	=> $field,
@@ -454,7 +454,7 @@ 
 			}
 		}	
 
-		if($this->use_joins===true){
+		if ($this->use_joins===true) {
 			$Specification->setJoins($joins);
 		}			
 	}	
@@ -469,7 +469,7 @@ 
 		return $o;
 	}
 	
-	public function withDelete(){
+	public function withDelete() {
 		$o = clone $this;
 		$o->use_delete = true;
 		return $o;

Braces +17 added lines, -20 removed lines

@@ -222,19 +222,18 @@ 
 				
 				if($this->use_joins===true){
 					$value = $mapper->createEntity($row);
-				}
-				else{
+				} else{
 					$fkey = isset($cfg['on']) ? $cfg['on'] :$mapper->key;
 					$value = $mapper->findBySpecification((new Specification)->setWhere($fkey, $row[$field]));
 				}				
 				
-			}
-			elseif(is_string($field) && isset($row[strtolower($field)])){
+			} elseif(is_string($field) && isset($row[strtolower($field)])){
 				$value = $row[strtolower($field)];
 			}
 			
-			if($value!==false)
-				$Entity->{$method_set}($value);
+			if($value!==false) {
+							$Entity->{$method_set}($value);
+			}
 			
         }
 		
@@ -265,18 +264,17 @@ 
 			//--------------------------------------------------------------------
 			if( isset($cfg['unbuild']) && is_object($cfg['unbuild']) ){
 				$value = call_user_func($cfg['unbuild'], $Entity->{$method_get}() );
-			}
-			elseif(isset($cfg['relation'])){
+			} elseif(isset($cfg['relation'])){
 				
-				if(isset($cfg['on']))
-					$fkey = $this->DI->get($cfg['relation'])->getFieldAlias($cfg['on']);
-				else
-					$fkey = 'id';
+				if(isset($cfg['on'])) {
+									$fkey = $this->DI->get($cfg['relation'])->getFieldAlias($cfg['on']);
+				} else {
+									$fkey = 'id';
+				}
 				
 				$value = $Entity->{$method_get}()->{'get'.$fkey}();
 				
-			}			
-			else{
+			} else{
 				$value = $Entity->{$method_get}();
 			}			
 						
@@ -294,8 +292,7 @@ 
 		
 		if(is_string($field)){
 			$field = ['field'	=>	$field];
-		}
-		elseif( (is_array($field) && !isset($field['field'])) || empty($field)){
+		} elseif( (is_array($field) && !isset($field['field'])) || empty($field)){
 			$field['field']	= $alias;
 		}
 	
@@ -377,8 +374,7 @@ 
 				$delete_key > '' && 
 				$Entity->getId() > 0){
 				$result = $this->db->update($this->getEntityTable(), [ $delete_key => 1 ], "{$this->getPrimaryKey()} = '{$Entity->getId()}'");
-		}
-		elseif($Entity->getId() > 0){
+		} elseif($Entity->getId() > 0){
 			
 			if($result = $this->db->delete($this->getEntityTable(), $this->getPrimaryKey()."  = ".$Entity->getId())){
 				if(method_exists($this, 'onDeleteSuccess' )){ $result = $this->onDeleteSuccess( $Entity );}
@@ -425,8 +421,9 @@ 
 				$this->use_delete === false &&
 				$this->setSoftDeleteKey()>'' 
 				&& !isset($specification->getWhere()[$this->setSoftDeleteKey()])
-				)
-		$specification->setWhere($this->setSoftDeleteKey(),0);
+				) {
+				$specification->setWhere($this->setSoftDeleteKey(),0);
+		}
 	}
 	
 		/**

tests/src/AbstractDataMapperTest.php

Indentation +5 added lines, -5 removed lines

@@ -58,7 +58,7 @@ 
 		//-----------------
 		$mapping_fields = \TestHelper::getProtectedAttribute($this->object,'mapping_fields');
 
-        $this->assertEquals($mapping_fields, $correct);		
+		$this->assertEquals($mapping_fields, $correct);		
 	}		
 	
 	/**
@@ -77,7 +77,7 @@ 
 		//-----------------
 		$mapping_fields = \TestHelper::getProtectedAttribute($this->object,'mapping_fields');
 
-        $this->assertEquals($mapping_fields, $correct);		
+		$this->assertEquals($mapping_fields, $correct);		
 	}		
 
 	/**
@@ -98,7 +98,7 @@ 
 		//-----------------
 		$mapping_fields = \TestHelper::getProtectedAttribute($this->object,'mapping_fields');
 
-        $this->assertEquals($mapping_fields, $correct);		
+		$this->assertEquals($mapping_fields, $correct);		
 	}	
 	
 	/**
@@ -121,7 +121,7 @@ 
 		//-----------------
 		$mapping_fields = \TestHelper::getProtectedAttribute($this->object,'mapping_fields');
 
-        $this->assertEquals($mapping_fields, $correct);		
+		$this->assertEquals($mapping_fields, $correct);		
 		
 		$key_field = \TestHelper::getProtectedAttribute($this->object,'key');
 		$this->assertEquals($key_field, 'tb_mayfield');	
@@ -147,7 +147,7 @@ 
 		//-----------------
 		$mapping_fields = \TestHelper::getProtectedAttribute($this->object,'mapping_fields');
 
-        $this->assertEquals($mapping_fields, $correct);		
+		$this->assertEquals($mapping_fields, $correct);		
 		
 		$soft_delete_key = \TestHelper::getProtectedAttribute($this->object,'soft_delete_key');
 		$this->assertEquals($soft_delete_key, 'tb_mayfield');	

Spacing +18 added lines, -18 removed lines

@@ -28,7 +28,7 @@ 
 //								])//в конструктор
 						->disableOriginalConstructor()
 						//->setMethods(null)
-						->setMethods(['setMappingFields','createEntity'])
+						->setMethods(['setMappingFields', 'createEntity'])
 						//->setMethods(null) //не использовать заглушки методов иначе буде возвращать NULL
 						->getMock();
 	}
@@ -45,9 +45,9 @@ 
 	/**
 	 * @covers SimpleORM\AbstractDataMapper::AddMappingField
 	 */
-	public function testAddMappingField_SimpleField(){
+	public function testAddMappingField_SimpleField() {
 		
-		\TestHelper::callMethod($this->object,'addMappingField',['myfield']);
+		\TestHelper::callMethod($this->object, 'addMappingField', ['myfield']);
 		
 		$correct = [
 			  'myfield'	=>	[
@@ -56,7 +56,7 @@ 
 		  ];
 		
 		//-----------------
-		$mapping_fields = \TestHelper::getProtectedAttribute($this->object,'mapping_fields');
+		$mapping_fields = \TestHelper::getProtectedAttribute($this->object, 'mapping_fields');
 
         $this->assertEquals($mapping_fields, $correct);		
 	}		
@@ -64,9 +64,9 @@ 
 	/**
 	 * @covers SimpleORM\AbstractDataMapper::AddMappingField
 	 */
-	public function testAddMappingField_FieldAndAlias(){
+	public function testAddMappingField_FieldAndAlias() {
 		
-		\TestHelper::callMethod($this->object,'addMappingField',['myfield','tb_mayfield']);
+		\TestHelper::callMethod($this->object, 'addMappingField', ['myfield', 'tb_mayfield']);
 		
 		$correct = [
 			  'myfield'	=>	[
@@ -75,7 +75,7 @@ 
 		  ];
 		
 		//-----------------
-		$mapping_fields = \TestHelper::getProtectedAttribute($this->object,'mapping_fields');
+		$mapping_fields = \TestHelper::getProtectedAttribute($this->object, 'mapping_fields');
 
         $this->assertEquals($mapping_fields, $correct);		
 	}		
@@ -83,9 +83,9 @@ 
 	/**
 	 * @covers SimpleORM\AbstractDataMapper::AddMappingField
 	 */
-	public function testAddMappingField_ArrayField(){
+	public function testAddMappingField_ArrayField() {
 		
-		\TestHelper::callMethod($this->object,'addMappingField',['myfield',[
+		\TestHelper::callMethod($this->object, 'addMappingField', ['myfield', [
 			'field'	=>	'tb_mayfield'
 		]]);
 		
@@ -96,7 +96,7 @@ 
 		  ];
 		
 		//-----------------
-		$mapping_fields = \TestHelper::getProtectedAttribute($this->object,'mapping_fields');
+		$mapping_fields = \TestHelper::getProtectedAttribute($this->object, 'mapping_fields');
 
         $this->assertEquals($mapping_fields, $correct);		
 	}	
@@ -104,9 +104,9 @@ 
 	/**
 	 * @covers SimpleORM\AbstractDataMapper::AddMappingField
 	 */
-	public function testAddMappingField_PrimaryKey(){
+	public function testAddMappingField_PrimaryKey() {
 		
-		\TestHelper::callMethod($this->object,'addMappingField',['myfield',[
+		\TestHelper::callMethod($this->object, 'addMappingField', ['myfield', [
 			'field'		=>	'tb_mayfield',
 			'primary'	=>	true
 		]]);
@@ -119,20 +119,20 @@ 
 		  ];
 		
 		//-----------------
-		$mapping_fields = \TestHelper::getProtectedAttribute($this->object,'mapping_fields');
+		$mapping_fields = \TestHelper::getProtectedAttribute($this->object, 'mapping_fields');
 
         $this->assertEquals($mapping_fields, $correct);		
 		
-		$key_field = \TestHelper::getProtectedAttribute($this->object,'key');
+		$key_field = \TestHelper::getProtectedAttribute($this->object, 'key');
 		$this->assertEquals($key_field, 'tb_mayfield');	
 	}	
 	
 	/**
 	 * @covers SimpleORM\AbstractDataMapper::AddMappingField
 	 */
-	public function testAddMappingField_SoftDelete(){
+	public function testAddMappingField_SoftDelete() {
 		
-		\TestHelper::callMethod($this->object,'addMappingField',['myfield',[
+		\TestHelper::callMethod($this->object, 'addMappingField', ['myfield', [
 			'field'			=>	'tb_mayfield',
 			'softdelete'	=>	true
 		]]);
@@ -145,11 +145,11 @@ 
 		  ];
 		
 		//-----------------
-		$mapping_fields = \TestHelper::getProtectedAttribute($this->object,'mapping_fields');
+		$mapping_fields = \TestHelper::getProtectedAttribute($this->object, 'mapping_fields');
 
         $this->assertEquals($mapping_fields, $correct);		
 		
-		$soft_delete_key = \TestHelper::getProtectedAttribute($this->object,'soft_delete_key');
+		$soft_delete_key = \TestHelper::getProtectedAttribute($this->object, 'soft_delete_key');
 		$this->assertEquals($soft_delete_key, 'tb_mayfield');	
 	}