DiegoSouza\Zimbra\ZimbraServiceProvider::register()

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	0

<?php
    public function register()
    {
        $host           = config('zimbra.host');
        $emailDomain    = config('zimbra.domain');
        $user           = config('zimbra.api.user');
        $password       = config('zimbra.api.password');
        $logger         = $this->app->log;

Accessing log on the interface Illuminate\Contracts\Foundation\Application suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->app->singleton(
            ZimbraApiClient::class,
            function () use ($host, $emailDomain, $user, $password, $logger) {
                return new ZimbraApiClient($host, $emailDomain, $user, $password, $logger);
            }
        );

        $this->app->alias(ZimbraApiClient::class, 'zimbra');
    }