DiegoSouza\Zimbra\ZimbraServiceProvider

Complexity

Total Complexity

2

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes	3
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	boot()	0	4	1
A	register()	0	16	1

<?php

namespace DiegoSouza\Zimbra;

use DiegoSouza\Zimbra\ZimbraApiClient;
use Illuminate\Support\ServiceProvider;

class ZimbraServiceProvider extends ServiceProvider
{
    public function register()
    {
        $host           = config('zimbra.host');
        $emailDomain    = config('zimbra.domain');
        $user           = config('zimbra.api.user');
        $password       = config('zimbra.api.password');
        $logger         = $this->app->log;

Accessing log on the interface Illuminate\Contracts\Foundation\Application suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->app->singleton(
            ZimbraApiClient::class,
            function () use ($host, $emailDomain, $user, $password, $logger) {
                return new ZimbraApiClient($host, $emailDomain, $user, $password, $logger);
            }
        );

        $this->app->alias(ZimbraApiClient::class, 'zimbra');
    }

    public function boot()
    {
        $this->publishes([
            __DIR__.'/../../../config/zimbra.php' => config_path('zimbra.php'),
        ]);
    }
}