NotificationController::read() - Code Metrics - Inspection of "notifications finalized & fixed" - deviouspk/larapi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 848980...7bc374 )

by Arthur

created 2018-10-15 20:39 UTC

NotificationController::read() A

↳ Parent: NotificationController

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2.0116

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	2
nop	1
dl	0
loc	10
ccs	6
cts	7
cp	0.8571
crap	2.0116
rs	10
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 14.10.18
 * Time: 18:58
 */

namespace Foundation\Controllers;

use Foundation\Resources\NotificationResource;
use Illuminate\Routing\Controller;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class NotificationController extends Controller
{
    public function all()
    {
        return NotificationResource::collection(get_authenticated_user()->notifications);

    }

    public function allUnread()
    {
        return NotificationResource::collection(get_authenticated_user()->unreadNotifications);

    }

    public function read($id)
    {
        $notification = get_authenticated_user()->unreadNotifications()->find($id);

        if ($notification === null)
            throw new NotFoundHttpException("Could not find notification");

        $notification->markAsRead();
        return response()->json([
            "success"
        ]);
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: arthur
5		* Date: 14.10.18
6		* Time: 18:58
7		*/
8
9		namespace Foundation\Controllers;
10
11		use Foundation\Resources\NotificationResource;
12		use Illuminate\Routing\Controller;
13		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
14
15		class NotificationController extends Controller
16		{
17	1	public function all()
18		{
19	1	return NotificationResource::collection(get_authenticated_user()->notifications);
		0 ignored issues – show Bug introduced 2018-10-14 23:15 UTC by Report Bug Copy Issue Report Accessing `notifications` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
20		}
21
22	1	public function allUnread()
23		{
24	1	return NotificationResource::collection(get_authenticated_user()->unreadNotifications);
		0 ignored issues – show Bug introduced 2018-10-14 23:15 UTC by Report Bug Copy Issue Report Accessing `unreadNotifications` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
25		}
26
27	2	public function read($id)
28		{
29	2	$notification = get_authenticated_user()->unreadNotifications()->find($id);
30
31	2	if ($notification === null)
32		throw new NotFoundHttpException("Could not find notification");
33
34	2	$notification->markAsRead();
35	2	return response()->json([
36	2	"success"
37		]);
38		}
39		}
40

deviouspk / larapi

Push — master ( 848980...7bc374 )

NotificationController::read() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like