Foundation\Controllers\NotificationController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Test Coverage

Coverage

90.91%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	all()	0	3	1
A	allUnread()	0	3	1
A	read()	0	10	2

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 14.10.18
 * Time: 18:58
 */

namespace Foundation\Controllers;

use Foundation\Resources\NotificationResource;
use Illuminate\Routing\Controller;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class NotificationController extends Controller
{
    public function all()
    {
        return NotificationResource::collection(get_authenticated_user()->notifications);

Accessing notifications on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function allUnread()
    {
        return NotificationResource::collection(get_authenticated_user()->unreadNotifications);

Accessing unreadNotifications on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function read($id)
    {
        $notification = get_authenticated_user()->unreadNotifications()->find($id);

        if ($notification === null)
            throw new NotFoundHttpException("Could not find notification");

        $notification->markAsRead();
        return response()->json([
            "success"
        ]);
    }
}