ProxyService::find() - Code Metrics - Inspection of "fixing scrutinizer build 5" - deviouspk/larapi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 139939...b4b8e8 )

by Arthur

created 2019-03-10 16:46 UTC

ProxyService::find() A

↳ Parent: ProxyService

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	1
dl	0
loc	7
rs	10
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\Proxy\Services;

use Carbon\Carbon;
use Modules\Proxy\Contracts\ProxyServiceContract;
use Modules\Proxy\Entities\Proxy;
use Modules\Proxy\Events\ProxyCreatedEvent;
use Modules\Proxy\Events\ProxyUpdatedEvent;

class ProxyService implements ProxyServiceContract
{
    public function getByUserId($userId)
    {
        return Proxy::where('user_id', $userId)->get();
    }

    public function find($id): ?Proxy
    {
        if ($id instanceof Proxy) {
            return $id;
        }

        return Proxy::find($id);

    }

    public function update($id, $data): Proxy
    {
        $proxy = $this->find($id);
        $proxy->update($data);
        event(new ProxyUpdatedEvent($proxy));

        return $proxy;
    }

    public function create($data): Proxy
    {
        $proxy = Proxy::create($data);
        event(new ProxyCreatedEvent($proxy));

        return $proxy;

    }

    public function delete($id): bool
    {
        return $this->find($id)->delete();

    }

    public function healthCheck($id, $data): void
    {
        //TODO DO THE ACTUAL HEALTCHECK
        $this->update($id, [
            'last_alive_at' => Carbon::now(),
            'last_checked_at'         => Carbon::now(),
        ]);
    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: arthur
5			* Date: 04.10.18
6			* Time: 16:17.
7			*/
8
9			namespace Modules\Proxy\Services;
10
11			use Carbon\Carbon;
12			use Modules\Proxy\Contracts\ProxyServiceContract;
13			use Modules\Proxy\Entities\Proxy;
14			use Modules\Proxy\Events\ProxyCreatedEvent;
15			use Modules\Proxy\Events\ProxyUpdatedEvent;
16
17			class ProxyService implements ProxyServiceContract
18			{
19			public function getByUserId($userId)
20			{
21			return Proxy::where('user_id', $userId)->get();
22			}
23
24			public function find($id): ?Proxy
25			{
26			if ($id instanceof Proxy) {
27			return $id;
28			}
29
30			return Proxy::find($id);
			0 ignored issues – show Bug Best Practice introduced 2019-03-10 17:08 UTC by Report Bug Copy Issue Report The expression `return Modules\Proxy\Entities\Proxy::find($id)` could return the type `Illuminate\Database\Eloq...go\Abstracts\MongoModel` which includes types incompatible with the type-hinted return `Modules\Proxy\Entities\Proxy\|null`. Consider adding an additional type-check to rule them out. Loading history...
31			}
32
33			public function update($id, $data): Proxy
34			{
35			$proxy = $this->find($id);
36			$proxy->update($data);
37			event(new ProxyUpdatedEvent($proxy));
38
39			return $proxy;
40			}
41
42			public function create($data): Proxy
43			{
44			$proxy = Proxy::create($data);
45			event(new ProxyCreatedEvent($proxy));
46
47			return $proxy;
			0 ignored issues – show Bug Best Practice introduced 2019-03-10 17:08 UTC by Report Bug Copy Issue Report The expression `return $proxy` returns the type `Illuminate\Database\Eloq...go\Abstracts\MongoModel` which includes types incompatible with the type-hinted return `Modules\Proxy\Entities\Proxy`. Loading history...
48			}
49
50			public function delete($id): bool
51			{
52			return $this->find($id)->delete();
			0 ignored issues – show Bug Best Practice introduced 2019-03-10 17:08 UTC by Report Bug Copy Issue Report The expression `return $this->find($id)->delete()` could return the type `null` which is incompatible with the type-hinted return `boolean`. Consider adding an additional type-check to rule them out. Loading history...
53			}
54
55			public function healthCheck($id, $data): void
56			{
57			//TODO DO THE ACTUAL HEALTCHECK
58			$this->update($id, [
59			'last_alive_at' => Carbon::now(),
60			'last_checked_at' => Carbon::now(),
61			]);
62			}
63			}
64

deviouspk / larapi

Push — master ( 139939...b4b8e8 )

ProxyService::find() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like