Modules\Proxy\Services\ProxyService

Complexity

Total Complexity

7

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	7	1
A	create()	0	6	1
A	healthCheck()	0	6	1
A	delete()	0	3	1
A	find()	0	7	2
A	getByUserId()	0	3	1

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\Proxy\Services;

use Carbon\Carbon;
use Modules\Proxy\Contracts\ProxyServiceContract;
use Modules\Proxy\Entities\Proxy;
use Modules\Proxy\Events\ProxyCreatedEvent;
use Modules\Proxy\Events\ProxyUpdatedEvent;

class ProxyService implements ProxyServiceContract
{
    public function getByUserId($userId)
    {
        return Proxy::where('user_id', $userId)->get();
    }

    public function find($id): ?Proxy
    {
        if ($id instanceof Proxy) {
            return $id;
        }

        return Proxy::find($id);

The expression return Modules\Proxy\Entities\Proxy::find($id) could return the type Illuminate\Database\Eloquent\Model|Jenssegers\Mongodb\Eloquent\Model|Modules\Mongo\Abstracts\MongoModel which includes types incompatible with the type-hinted return Modules\Proxy\Entities\Proxy|null. Consider adding an additional type-check to rule them out.

    }

    public function update($id, $data): Proxy
    {
        $proxy = $this->find($id);
        $proxy->update($data);
        event(new ProxyUpdatedEvent($proxy));

        return $proxy;
    }

    public function create($data): Proxy
    {
        $proxy = Proxy::create($data);
        event(new ProxyCreatedEvent($proxy));

        return $proxy;

The expression return $proxy returns the type Illuminate\Database\Eloquent\Model|Jenssegers\Mongodb\Eloquent\Model|Modules\Mongo\Abstracts\MongoModel which includes types incompatible with the type-hinted return Modules\Proxy\Entities\Proxy.

    }

    public function delete($id): bool
    {
        return $this->find($id)->delete();

The expression return $this->find($id)->delete() could return the type null which is incompatible with the type-hinted return boolean. Consider adding an additional type-check to rule them out.

    }

    public function healthCheck($id, $data): void
    {
        //TODO DO THE ACTUAL HEALTCHECK
        $this->update($id, [
            'last_alive_at' => Carbon::now(),
            'last_checked_at'         => Carbon::now(),
        ]);
    }
}