ScheduleService::find() - Code Metrics - deviouspk/larapi - Measure and Improve Code Quality continuously with Scrutinizer

ScheduleService::find() A
last analyzed 2019-04-15 14:07 UTC

↳ Parent: ScheduleService

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	1
dl	0
loc	7
ccs	0
cts	6
cp	0
crap	6
rs	10
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\Schedule\Services;

use Modules\Schedule\Contracts\ScheduleServiceContract;
use Modules\Schedule\Entities\Schedule;
use Modules\Schedule\Events\ScheduleCreatedEvent;
use Modules\Schedule\Events\ScheduleUpdatedEvent;

class ScheduleService implements ScheduleServiceContract
{
    public function getByUserId($userId)
    {
        return Schedule::where('user_id', $userId)->get();
    }

    public function find($id): ?Schedule
    {
        if ($id instanceof Schedule) {
            return $id;
        }

        return Schedule::find($id);

    }

    public function update($id, $data): Schedule
    {
        $Schedule = $this->find($id);
        $Schedule->update($data);
        event(new ScheduleUpdatedEvent($Schedule));

        return $Schedule;
    }

    public function create($data): Schedule
    {
        $Schedule = Schedule::create($data);
        event(new ScheduleCreatedEvent($Schedule));

        return $Schedule;

    }

    public function delete($id): bool
    {
        return $this->find($id)->delete();

    }
}


1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: arthur
5			* Date: 04.10.18
6			* Time: 16:17.
7			*/
8
9			namespace Modules\Schedule\Services;
10
11			use Modules\Schedule\Contracts\ScheduleServiceContract;
12			use Modules\Schedule\Entities\Schedule;
13			use Modules\Schedule\Events\ScheduleCreatedEvent;
14			use Modules\Schedule\Events\ScheduleUpdatedEvent;
15
16			class ScheduleService implements ScheduleServiceContract
17			{
18			public function getByUserId($userId)
19			{
20			return Schedule::where('user_id', $userId)->get();
21			}
22
23			public function find($id): ?Schedule
24			{
25			if ($id instanceof Schedule) {
26			return $id;
27			}
28
29			return Schedule::find($id);
			0 ignored issues – show Bug Best Practice introduced 2019-03-10 17:08 UTC by Report Bug Copy Issue Report The expression `return Modules\Schedule\...ies\Schedule::find($id)` could return the type `Illuminate\Database\Eloq...go\Abstracts\MongoModel` which includes types incompatible with the type-hinted return `Modules\Schedule\Entities\Schedule\|null`. Consider adding an additional type-check to rule them out. Loading history...
30			}
31
32			public function update($id, $data): Schedule
33			{
34			$Schedule = $this->find($id);
35			$Schedule->update($data);
36			event(new ScheduleUpdatedEvent($Schedule));
37
38			return $Schedule;
39			}
40
41			public function create($data): Schedule
42			{
43			$Schedule = Schedule::create($data);
44			event(new ScheduleCreatedEvent($Schedule));
45
46			return $Schedule;
			0 ignored issues – show Bug Best Practice introduced 2019-03-10 17:08 UTC by Report Bug Copy Issue Report The expression `return $Schedule` returns the type `Illuminate\Database\Eloq...go\Abstracts\MongoModel` which includes types incompatible with the type-hinted return `Modules\Schedule\Entities\Schedule`. Loading history...
47			}
48
49			public function delete($id): bool
50			{
51			return $this->find($id)->delete();
			0 ignored issues – show Bug Best Practice introduced 2019-03-10 17:08 UTC by Report Bug Copy Issue Report The expression `return $this->find($id)->delete()` could return the type `null` which is incompatible with the type-hinted return `boolean`. Consider adding an additional type-check to rule them out. Loading history...
52			}
53			}
54

deviouspk / larapi

ScheduleService::find() A last analyzed 2019-04-15 14:07 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ScheduleService::find() A
last analyzed 2019-04-15 14:07 UTC