Modules\Schedule\Services\ScheduleService

Complexity

Total Complexity

6

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	find()	0	7	2
A	update()	0	7	1
A	create()	0	6	1
A	getByUserId()	0	3	1
A	delete()	0	3	1

<?php
/**
 * Created by PhpStorm.
 * User: arthur
 * Date: 04.10.18
 * Time: 16:17.
 */

namespace Modules\Schedule\Services;

use Modules\Schedule\Contracts\ScheduleServiceContract;
use Modules\Schedule\Entities\Schedule;
use Modules\Schedule\Events\ScheduleCreatedEvent;
use Modules\Schedule\Events\ScheduleUpdatedEvent;

class ScheduleService implements ScheduleServiceContract
{
    public function getByUserId($userId)
    {
        return Schedule::where('user_id', $userId)->get();
    }

    public function find($id): ?Schedule
    {
        if ($id instanceof Schedule) {
            return $id;
        }

        return Schedule::find($id);

The expression return Modules\Schedule\Entities\Schedule::find($id) could return the type Illuminate\Database\Eloquent\Model|Jenssegers\Mongodb\Eloquent\Model|Modules\Mongo\Abstracts\MongoModel which includes types incompatible with the type-hinted return Modules\Schedule\Entities\Schedule|null. Consider adding an additional type-check to rule them out.

    }

    public function update($id, $data): Schedule
    {
        $Schedule = $this->find($id);
        $Schedule->update($data);
        event(new ScheduleUpdatedEvent($Schedule));

        return $Schedule;
    }

    public function create($data): Schedule
    {
        $Schedule = Schedule::create($data);
        event(new ScheduleCreatedEvent($Schedule));

        return $Schedule;

The expression return $Schedule returns the type Illuminate\Database\Eloquent\Model|Jenssegers\Mongodb\Eloquent\Model|Modules\Mongo\Abstracts\MongoModel which includes types incompatible with the type-hinted return Modules\Schedule\Entities\Schedule.

    }

    public function delete($id): bool
    {
        return $this->find($id)->delete();

The expression return $this->find($id)->delete() could return the type null which is incompatible with the type-hinted return boolean. Consider adding an additional type-check to rule them out.

    }
}