Devanych\Mime\MimeTypesTrait::addMapInternal()

Complexity

Conditions	6
Paths	6

Size

Total Lines	28
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

<?php
    private function addMapInternal(array $map): void
    {
        foreach ($map as $mimeType => $extensions) {
            if (!is_string($mimeType)) {
                throw new InvalidArgumentException(sprintf(
                    'MIME type MUST be string, received `%s`',
                    gettype($mimeType)
                ));
            }

            if (!is_array($extensions)) {
                throw new InvalidArgumentException(sprintf(
                    'Extensions MUST be array, received `%s`',
                    gettype($extensions)
                ));
            }

            $this->extensions[$mimeType] = $extensions;

The property extensions does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            foreach ($extensions as $extension) {
                if (!is_string($extension)) {
                    throw new InvalidArgumentException(sprintf(
                        'Extension MUST be string, received `%s`',
                        gettype($extension)
                    ));
                }

                $this->mimeTypes[$extension][] = $mimeType;

The property mimeTypes does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }