Devanych\Mime\MimeTypesTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	addMapInternal()	0	28	6

<?php

declare(strict_types=1);

namespace Devanych\Mime;

use InvalidArgumentException;

use function is_string;
use function is_array;
use function sprintf;
use function gettype;

trait MimeTypesTrait
{
    /**
     * @param array<string, string[]> $map
     * @see MimeTypesInterface::addMap()
     * @psalm-suppress DocblockTypeContradiction
     */
    private function addMapInternal(array $map): void
    {
        foreach ($map as $mimeType => $extensions) {
            if (!is_string($mimeType)) {
                throw new InvalidArgumentException(sprintf(
                    'MIME type MUST be string, received `%s`',
                    gettype($mimeType)
                ));
            }

            if (!is_array($extensions)) {
                throw new InvalidArgumentException(sprintf(
                    'Extensions MUST be array, received `%s`',
                    gettype($extensions)
                ));
            }

            $this->extensions[$mimeType] = $extensions;

The property extensions does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            foreach ($extensions as $extension) {
                if (!is_string($extension)) {
                    throw new InvalidArgumentException(sprintf(
                        'Extension MUST be string, received `%s`',
                        gettype($extension)
                    ));
                }

                $this->mimeTypes[$extension][] = $mimeType;

The property mimeTypes does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }
        }
    }
}