Manifest::findRecent() - Code Metrics - Inspection of "next" - deployphp/deployer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 4e243a...9b019b )

by Anton

created 2020-04-25 20:00 UTC

Manifest::findRecent() B

↳ Parent: Manifest

Complexity

Conditions	9
Paths	14

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	90

Importance

Changes

Metric	Value
cc	9
nc	14
nop	3
dl	0
loc	27
ccs	0
cts	20
cp	0
crap	90
rs	8.0555
c	0
b	0
f	0

<?php

namespace Deployer\Component\PharUpdate;

use Deployer\Component\Version\Comparator;
use Deployer\Component\Version\Parser;
use Deployer\Component\Version\Version;

/**
 * Manages the contents of an updates manifest file.
 *
 * @author Kevin Herrera <[email protected]>
 */
class Manifest
{
    /**
     * The list of updates in the manifest.
     *
     * @var Update[]
     */
    private $updates;

    /**
     * Sets the list of updates from the manifest.
     *
     * @param Update[] $updates The updates.
     */
    public function __construct(array $updates = array())
    {
        $this->updates = $updates;
    }

    /**
     * Finds the most recent update and returns it.
     *
     * @param Version $version The current version.
     * @param boolean $major   Lock to major version?
     * @param boolean $pre     Allow pre-releases?
     *
     * @return Update The update.
     */
    public function findRecent(Version $version, $major = false, $pre = false)
    {
        /** @var $current Update */
        $current = null;
        $major = $major ? $version->getMajor() : null;

        foreach ($this->updates as $update) {
            if ($major && ($major !== $update->getVersion()->getMajor())) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
                continue;
            }

            if ((false === $pre)
                && !$update->getVersion()->isStable()) {
                continue;
            }

            $test = $current ? $current->getVersion() : $version;

            if (false === $update->isNewer($test)) {
                continue;
            }

            $current = $update;
        }

        return $current;
    }

    /**
     * Returns the list of updates in the manifest.
     *
     * @return Update[] The updates.
     */
    public function getUpdates()
    {
        return $this->updates;
    }

    /**
     * Loads the manifest from a JSON encoded string.
     *
     * @param string $json The JSON encoded string.
     *
     * @return Manifest The manifest.
     */
    public static function load($json)
    {
        return self::create(json_decode($json));
    }

    /**
     * Loads the manifest from a JSON encoded file.
     *
     * @param string $file The JSON encoded file.
     *
     * @return Manifest The manifest.
     */
    public static function loadFile($file)
    {
        return self::create(json_decode(file_get_contents($file)));
    }

    /**
     * Validates the data, processes it, and returns a new instance of Manifest.
     *
     * @param array $decoded The decoded JSON data.
     *
     * @return Manifest The new instance.
     */
    private static function create($decoded)
    {
        $updates = array();

        foreach ($decoded as $update) {
            $updates[] = new Update(
                $update->name,
                $update->sha1,
                $update->url,
                Parser::toVersion($update->version),
                isset($update->publicKey) ? $update->publicKey : null
            );
        }

        usort(
            $updates,
            function (Update $a, Update $b) {
                return Comparator::isGreaterThan(
                    $a->getVersion(),
                    $b->getVersion()
                );
            }
        );

        return new static($updates);
    }
}


1			<?php
2
3			namespace Deployer\Component\PharUpdate;
4
5			use Deployer\Component\Version\Comparator;
6			use Deployer\Component\Version\Parser;
7			use Deployer\Component\Version\Version;
8
9			/**
10			* Manages the contents of an updates manifest file.
11			*
12			* @author Kevin Herrera <[email protected]>
13			*/
14			class Manifest
15			{
16			/**
17			* The list of updates in the manifest.
18			*
19			* @var Update[]
20			*/
21			private $updates;
22
23			/**
24			* Sets the list of updates from the manifest.
25			*
26			* @param Update[] $updates The updates.
27			*/
28			public function __construct(array $updates = array())
29			{
30			$this->updates = $updates;
31			}
32
33			/**
34			* Finds the most recent update and returns it.
35			*
36			* @param Version $version The current version.
37			* @param boolean $major Lock to major version?
38			* @param boolean $pre Allow pre-releases?
39			*
40			* @return Update The update.
41			*/
42			public function findRecent(Version $version, $major = false, $pre = false)
43			{
44			/** @var $current Update */
45			$current = null;
46			$major = $major ? $version->getMajor() : null;
47
48			foreach ($this->updates as $update) {
49			if ($major && ($major !== $update->getVersion()->getMajor())) {
			0 ignored issues – show Bug Best Practice introduced 2020-04-25 19:51 UTC by Report Bug Copy Issue Report The expression `$major` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
50			continue;
51			}
52
53			if ((false === $pre)
54			&& !$update->getVersion()->isStable()) {
55			continue;
56			}
57
58			$test = $current ? $current->getVersion() : $version;
59
60			if (false === $update->isNewer($test)) {
61			continue;
62			}
63
64			$current = $update;
65			}
66
67			return $current;
68			}
69
70			/**
71			* Returns the list of updates in the manifest.
72			*
73			* @return Update[] The updates.
74			*/
75			public function getUpdates()
76			{
77			return $this->updates;
78			}
79
80			/**
81			* Loads the manifest from a JSON encoded string.
82			*
83			* @param string $json The JSON encoded string.
84			*
85			* @return Manifest The manifest.
86			*/
87			public static function load($json)
88			{
89			return self::create(json_decode($json));
90			}
91
92			/**
93			* Loads the manifest from a JSON encoded file.
94			*
95			* @param string $file The JSON encoded file.
96			*
97			* @return Manifest The manifest.
98			*/
99			public static function loadFile($file)
100			{
101			return self::create(json_decode(file_get_contents($file)));
102			}
103
104			/**
105			* Validates the data, processes it, and returns a new instance of Manifest.
106			*
107			* @param array $decoded The decoded JSON data.
108			*
109			* @return Manifest The new instance.
110			*/
111			private static function create($decoded)
112			{
113			$updates = array();
114
115			foreach ($decoded as $update) {
116			$updates[] = new Update(
117			$update->name,
118			$update->sha1,
119			$update->url,
120			Parser::toVersion($update->version),
121			isset($update->publicKey) ? $update->publicKey : null
122			);
123			}
124
125			usort(
126			$updates,
127			function (Update $a, Update $b) {
128			return Comparator::isGreaterThan(
129			$a->getVersion(),
130			$b->getVersion()
131			);
132			}
133			);
134
135			return new static($updates);
136			}
137			}
138

deployphp / deployer

GitHub Access Token became invalid

Push — master ( 4e243a...9b019b )

Manifest::findRecent() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like