delboy1978uk / form

src/Collection/FieldCollection.php

<?php

declare(strict_types=1);

namespace Del\Form\Collection;

use Del\Form\Field\FieldInterface;

class FieldCollection extends AbstractCollection implements CollectionInterface
{
    /**
     * @param $name
     * @return FieldInterface|null
     */
    public function findByName($name)
    {
        $this->rewind();
        while ($this->valid()) {
            /** @var FieldInterface $field */
            $field = $this->current();
            if ($field->getName() == $name) {
                return $field;
            }
            $this->next();
        }
        $this->rewind();
        return null;
    }

    /**
     * @param $name
     * @return bool
     */
    public function removeByName($name): bool
    {
        $this->rewind();

        while ($this->valid()) {
            $field = $this->current();

            if ($field->getName() == $name) {
                $key = $this->key();
                $this->offsetUnset($key);

It seems like $key can also be of type true; however, parameter $key of ArrayIterator::offsetUnset() does only seem to accept string, maybe add an additional type check?

                $this->rewind();

                return true;
            }
            $this->next();
        }

        $this->rewind();

        return false;
    }

    /**
     * @return FieldInterface
     */
    public function current(): FieldInterface
    {
        return parent::current();
    }
}