Del\Form\Collection\FieldCollection::removeByName()

Complexity

Conditions	3
Paths	3

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function removeByName($name): bool
    {
        $this->rewind();

        while ($this->valid()) {
            $field = $this->current();

            if ($field->getName() == $name) {
                $key = $this->key();
                $this->offsetUnset($key);

It seems like $key can also be of type true; however, parameter $key of ArrayIterator::offsetUnset() does only seem to accept string, maybe add an additional type check?

                $this->rewind();

                return true;
            }
            $this->next();
        }

        $this->rewind();

        return false;
    }