DateTimeTransformer::__construct() - Code Metrics - Inspection of "Merge branch 'dev-master'" - delboy1978uk/form - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4d8439...98d3f4 )

by Derek Stephen

created 2019-11-03 14:16 UTC

DateTimeTransformer::__construct() A

↳ Parent: DateTimeTransformer

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace Del\Form\Field\Transformer;

use DateTime;
use Del\Form\Field\TransformerInterface;

class DateTimeTransformer implements TransformerInterface
{
    /** @var string $dateFormat */
    private $dateFormat;

    /**
     * DateTimeTransformer constructor.
     * @param string $dateFormat
     */
    public function __construct(string $dateFormat)
    {
        $this->dateFormat = $dateFormat;
    }

    /**
     * @param mixed $value
     * @return string
     */
    public function input($value): string
    {
        if ($value instanceof DateTime) {
            return $value->format($this->dateFormat);
        }

        return $value;
    }

    /**
     * @return DateTime
     */
    public function output(string $value)
    {
        return DateTime::createFromFormat($this->dateFormat, $value);

    }
}

1			<?php
2
3			namespace Del\Form\Field\Transformer;
4
5			use DateTime;
6			use Del\Form\Field\TransformerInterface;
7
8			class DateTimeTransformer implements TransformerInterface
9			{
10			/** @var string $dateFormat */
11			private $dateFormat;
12
13			/**
14			* DateTimeTransformer constructor.
15			* @param string $dateFormat
16			*/
17			public function __construct(string $dateFormat)
18			{
19			$this->dateFormat = $dateFormat;
20			}
21
22			/**
23			* @param mixed $value
24			* @return string
25			*/
26			public function input($value): string
27			{
28			if ($value instanceof DateTime) {
29			return $value->format($this->dateFormat);
30			}
31
32			return $value;
33			}
34
35			/**
36			* @return DateTime
37			*/
38			public function output(string $value)
39			{
40			return DateTime::createFromFormat($this->dateFormat, $value);
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-11-03 14:21 UTC by Report Bug Copy Issue Report The expression `\DateTime::createFromFor...s->dateFormat, $value);` of type `DateTime\|false` adds `false` to the return on line 40 which is incompatible with the return type documented by `Del\Form\Field\Transform...TimeTransformer::output` of type `DateTime`. It seems like you forgot to handle an error condition. Loading history...
41			}
42			}

delboy1978uk / form

Push — master ( 4d8439...98d3f4 )

DateTimeTransformer::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like