Del\Form\Field\Transformer\DateTimeTransformer

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	input()	0	8	2
A	output()	0	4	1

<?php

namespace Del\Form\Field\Transformer;

use DateTime;
use Del\Form\Field\TransformerInterface;

class DateTimeTransformer implements TransformerInterface
{
    /** @var string $dateFormat */
    private $dateFormat;

    /**
     * DateTimeTransformer constructor.
     * @param string $dateFormat
     */
    public function __construct(string $dateFormat)
    {
        $this->dateFormat = $dateFormat;
    }

    /**
     * @param mixed $value
     * @return string
     */
    public function input($value): string
    {
        if ($value instanceof DateTime) {
            return $value->format($this->dateFormat);
        }

        return $value;
    }

    /**
     * @return DateTime
     */
    public function output(string $value)
    {
        return DateTime::createFromFormat($this->dateFormat, $value);

The expression \DateTime::createFromFormat($this->dateFormat, $value); of type DateTime|false adds false to the return on line 40 which is incompatible with the return type documented by Del\Form\Field\Transformer\DateTimeTransformer::output of type DateTime. It seems like you forgot to handle an error condition.

    }
}