Issues in Isolate.php (master) - Issues in master - dazzle-php/util - Measure and Improve Code Quality continuously with Scrutinizer

Issues (22)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Util/Isolate/Isolate.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Dazzle\Util\Isolate;

use Error;
use Exception;
use Dazzle\Throwable\Exception\Logic\InstantiationException;
use Dazzle\Throwable\Exception\Runtime\ExecutionException;

class Isolate implements IsolateInterface
{
    /**
     * @var string
     */
    private $pid;

    /**
     * @var resource
     */
    private $socket;

    /**
     * @throws InstantiationException
     */
    public function __construct()
    {
        if (($sockets = @stream_socket_pair(STREAM_PF_UNIX, STREAM_SOCK_STREAM, STREAM_IPPROTO_IP)) === false)
        {
            throw new InstantiationException('stream_socket_pair() could not establish connection.');
        }

        $pid = pcntl_fork();

        if ($pid == -1)
        {
            throw new InstantiationException('pcntl_fork() could not create subprocess.');

        }
        else if ($pid)
        {
            $this->createParent($pid, $sockets);
        }
        else
        {
            $this->createChild($pid, $sockets);
        }
    }

    /**
     *
     */
    public function __destruct()
    {
        if (is_resource($this->socket))
        {
            fclose($this->socket);
        }

        unset($this->pid);
        unset($this->socket);
    }

    /**
     * @override
     * @inheritDoc
     */
    public function call($func, $params = [])
    {
        $caller = [
            'func'   => $func,
            'params' => $params
        ];

        if (@fwrite($this->socket, json_encode($caller) . "\n") === false)
        {
            throw new ExecutionException('Could not created isolated call.');
        }

        if (($rep = @fgets($this->socket)) === false)
        {
            throw new ExecutionException('Could not receive returned value from isolated call.');
        }

        return rtrim($rep, "\n");
    }

    /**
     * @param int $pid
     * @param resource[] $sockets
     */
    private function createParent($pid, $sockets)
    {
        fclose($sockets[0]);

        $this->pid = (string) $pid;
        $this->socket = $sockets[1];
    }

    /**
     * @param int $pid
     * @param resource[] $sockets
     */
    private function createChild($pid, $sockets)
    {
        fclose($sockets[1]);

        $this->pid = (string) $pid;
        $this->socket = $sockets[0];

        while(($message = @fgets($this->socket)) !== false)
        {
            $ex = null;

            try
            {
                $data = json_decode($message, true);
                $return = (string) call_user_func_array($data['func'], $data['params']);
            }
            catch (Error $ex)

            {}
            catch (Exception $ex)

            {}

            if ($ex !== null || @fwrite($this->socket, $return . "\n") === false)
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            {
                break;
            }
        }

        fclose($sockets[0]);
        exit(0);

    }
}


1			<?php
2
3			namespace Dazzle\Util\Isolate;
4
5			use Error;
6			use Exception;
7			use Dazzle\Throwable\Exception\Logic\InstantiationException;
8			use Dazzle\Throwable\Exception\Runtime\ExecutionException;
9
10			class Isolate implements IsolateInterface
11			{
12			/**
13			* @var string
14			*/
15			private $pid;
16
17			/**
18			* @var resource
19			*/
20			private $socket;
21
22			/**
23			* @throws InstantiationException
24			*/
25			public function __construct()
26			{
27			if (($sockets = @stream_socket_pair(STREAM_PF_UNIX, STREAM_SOCK_STREAM, STREAM_IPPROTO_IP)) === false)
28			{
29			throw new InstantiationException('stream_socket_pair() could not establish connection.');
30			}
31
32			$pid = pcntl_fork();
33
34			if ($pid == -1)
35			{
36			throw new InstantiationException('pcntl_fork() could not create subprocess.');
37
38			}
39			else if ($pid)
40			{
41			$this->createParent($pid, $sockets);
42			}
43			else
44			{
45			$this->createChild($pid, $sockets);
46			}
47			}
48
49			/**
50			*
51			*/
52			public function __destruct()
53			{
54			if (is_resource($this->socket))
55			{
56			fclose($this->socket);
57			}
58
59			unset($this->pid);
60			unset($this->socket);
61			}
62
63			/**
64			* @override
65			* @inheritDoc
66			*/
67			public function call($func, $params = [])
68			{
69			$caller = [
70			'func' => $func,
71			'params' => $params
72			];
73
74			if (@fwrite($this->socket, json_encode($caller) . "\n") === false)
75			{
76			throw new ExecutionException('Could not created isolated call.');
77			}
78
79			if (($rep = @fgets($this->socket)) === false)
80			{
81			throw new ExecutionException('Could not receive returned value from isolated call.');
82			}
83
84			return rtrim($rep, "\n");
85			}
86
87			/**
88			* @param int $pid
89			* @param resource[] $sockets
90			*/
91			private function createParent($pid, $sockets)
92			{
93			fclose($sockets[0]);
94
95			$this->pid = (string) $pid;
96			$this->socket = $sockets[1];
97			}
98
99			/**
100			* @param int $pid
101			* @param resource[] $sockets
102			*/
103			private function createChild($pid, $sockets)
104			{
105			fclose($sockets[1]);
106
107			$this->pid = (string) $pid;
108			$this->socket = $sockets[0];
109
110			while(($message = @fgets($this->socket)) !== false)
111			{
112			$ex = null;
113
114			try
115			{
116			$data = json_decode($message, true);
117			$return = (string) call_user_func_array($data['func'], $data['params']);
118			}
119			catch (Error $ex)
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-06-19 21:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider adding a comment why this CATCH block is empty. Loading history...
120			{}
121			catch (Exception $ex)
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-06-19 21:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider adding a comment why this CATCH block is empty. Loading history...
122			{}
123
124			if ($ex !== null \|\| @fwrite($this->socket, $return . "\n") === false)
			0 ignored issues – show Bug introduced 2017-06-19 21:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$return` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
125			{
126			break;
127			}
128			}
129
130			fclose($sockets[0]);
131			exit(0);
			0 ignored issues – show Coding Style Compatibility introduced 2017-06-19 21:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `createChild()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
132			}
133			}
134

dazzle-php / util

Issues (22)

Security Analysis no request data

src/Util/Isolate/Isolate.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like