Isolate::__construct()   B
last analyzed

Complexity

Conditions 4
Paths 4

Size

Total Lines 23
Code Lines 10

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 20

Importance

Changes 0
Metric Value
dl 0
loc 23
ccs 0
cts 20
cp 0
rs 8.7972
c 0
b 0
f 0
cc 4
eloc 10
nc 4
nop 0
crap 20
1
<?php
2
3
namespace Dazzle\Util\Isolate;
4
5
use Error;
6
use Exception;
7
use Dazzle\Throwable\Exception\Logic\InstantiationException;
8
use Dazzle\Throwable\Exception\Runtime\ExecutionException;
9
10
class Isolate implements IsolateInterface
11
{
12
    /**
13
     * @var string
14
     */
15
    private $pid;
16
17
    /**
18
     * @var resource
19
     */
20
    private $socket;
21
22
    /**
23
     * @throws InstantiationException
24
     */
25
    public function __construct()
26
    {
27
        if (($sockets = @stream_socket_pair(STREAM_PF_UNIX, STREAM_SOCK_STREAM, STREAM_IPPROTO_IP)) === false)
28
        {
29
            throw new InstantiationException('stream_socket_pair() could not establish connection.');
30
        }
31
32
        $pid = pcntl_fork();
33
34
        if ($pid == -1)
35
        {
36
            throw new InstantiationException('pcntl_fork() could not create subprocess.');
37
38
        }
39
        else if ($pid)
40
        {
41
            $this->createParent($pid, $sockets);
42
        }
43
        else
44
        {
45
            $this->createChild($pid, $sockets);
46
        }
47
    }
48
49
    /**
50
     *
51
     */
52
    public function __destruct()
53
    {
54
        if (is_resource($this->socket))
55
        {
56
            fclose($this->socket);
57
        }
58
59
        unset($this->pid);
60
        unset($this->socket);
61
    }
62
63
    /**
64
     * @override
65
     * @inheritDoc
66
     */
67
    public function call($func, $params = [])
68
    {
69
        $caller = [
70
            'func'   => $func,
71
            'params' => $params
72
        ];
73
74
        if (@fwrite($this->socket, json_encode($caller) . "\n") === false)
75
        {
76
            throw new ExecutionException('Could not created isolated call.');
77
        }
78
79
        if (($rep = @fgets($this->socket)) === false)
80
        {
81
            throw new ExecutionException('Could not receive returned value from isolated call.');
82
        }
83
84
        return rtrim($rep, "\n");
85
    }
86
87
    /**
88
     * @param int $pid
89
     * @param resource[] $sockets
90
     */
91
    private function createParent($pid, $sockets)
92
    {
93
        fclose($sockets[0]);
94
95
        $this->pid = (string) $pid;
96
        $this->socket = $sockets[1];
97
    }
98
99
    /**
100
     * @param int $pid
101
     * @param resource[] $sockets
102
     */
103
    private function createChild($pid, $sockets)
104
    {
105
        fclose($sockets[1]);
106
107
        $this->pid = (string) $pid;
108
        $this->socket = $sockets[0];
109
110
        while(($message = @fgets($this->socket)) !== false)
111
        {
112
            $ex = null;
113
114
            try
115
            {
116
                $data = json_decode($message, true);
117
                $return = (string) call_user_func_array($data['func'], $data['params']);
118
            }
119
            catch (Error $ex)
0 ignored issues
show
Coding Style Comprehensibility introduced by
Consider adding a comment why this CATCH block is empty.
Loading history...
120
            {}
121
            catch (Exception $ex)
0 ignored issues
show
Coding Style Comprehensibility introduced by
Consider adding a comment why this CATCH block is empty.
Loading history...
122
            {}
123
124
            if ($ex !== null || @fwrite($this->socket, $return . "\n") === false)
0 ignored issues
show
Bug introduced by
The variable $return does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
125
            {
126
                break;
127
            }
128
        }
129
130
        fclose($sockets[0]);
131
        exit(0);
0 ignored issues
show
Coding Style Compatibility introduced by
The method createChild() contains an exit expression.

An exit expression should only be used in rare cases. For example, if you write a short command line script.

In most cases however, using an exit expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage.

Loading history...
132
    }
133
}
134