ApiConnTrait::select() - Code Metrics - Inspection of "Refactored commands API" - dazzle-php/redis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9e125a...9a1e57 )

by Kamil

created 2017-07-02 15:02 UTC

ApiConnTrait::select() A

↳ Parent: ApiConnTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	7
c	0
b	0
f	0
ccs	0
cts	3
cp	0
rs	9.4285
nc	1
cc	1
eloc	3
nop	1
crap	2

<?php

namespace Dazzle\Redis\Command\Compose;

use Dazzle\Redis\Command\Builder;
use Dazzle\Redis\Command\Enum;
use Dazzle\Redis\Driver\Request;

trait ApiConnTrait
{
    /**
     * @param Request $request
     * @return mixed
     */
    abstract function dispatch(Request $request);


    /**
     * @override
     * @inheritDoc
     */
    public function auth($password)
    {
        $command = Enum::AUTH;
        $args = [$password];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function ping($message = 'PING')

    {
        $command = Enum::PING;
        $args = [$message];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function quit()
    {
        $command = Enum::QUIT;

        return $this->dispatch(Builder::build($command));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function select($index)

    {
        // TODO: Implement select() method.
        $command = Enum::SELECT;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        return $this;
    }
}


1		<?php
2
3		namespace Dazzle\Redis\Command\Compose;
4
5		use Dazzle\Redis\Command\Builder;
6		use Dazzle\Redis\Command\Enum;
7		use Dazzle\Redis\Driver\Request;
8
9		trait ApiConnTrait
10		{
11		/**
12		* @param Request $request
13		* @return mixed
14		*/
15		abstract function dispatch(Request $request);
		0 ignored issues – show Best Practice introduced 2017-07-02 15:04 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
16
17		/**
18		* @override
19		* @inheritDoc
20		*/
21		public function auth($password)
22		{
23		$command = Enum::AUTH;
24		$args = [$password];
25
26		return $this->dispatch(Builder::build($command, $args));
27		}
28
29		/**
30		* @override
31		* @inheritDoc
32		*/
33	View Code Duplication	public function ping($message = 'PING')
		0 ignored issues – show Duplication introduced 2017-07-01 22:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		$command = Enum::PING;
36		$args = [$message];
37
38		return $this->dispatch(Builder::build($command, $args));
39		}
40
41		/**
42		* @override
43		* @inheritDoc
44		*/
45		public function quit()
46		{
47		$command = Enum::QUIT;
48
49		return $this->dispatch(Builder::build($command));
50		}
51
52		/**
53		* @override
54		* @inheritDoc
55		*/
56		public function select($index)
		0 ignored issues – show Unused Code introduced 2017-07-02 15:04 UTC by Report Bug Copy Issue Report The parameter `$index` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
57		{
58		// TODO: Implement select() method.
59		$command = Enum::SELECT;
		0 ignored issues – show Unused Code introduced 2017-07-01 22:13 UTC by Report Bug Copy Issue Report `$command` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
60
61		return $this;
62		}
63		}
64

dazzle-php / redis

Push — master ( 9e125a...9a1e57 )

ApiConnTrait::select() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like