Dazzle\Redis\Command\Compose\ApiConnTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	55
Duplicated Lines	12.73 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
	dispatch()	0	1	?
A	auth()	0	7	1
A	ping()	7	7	1
A	quit()	0	6	1
A	select()	0	7	1

<?php

namespace Dazzle\Redis\Command\Compose;

use Dazzle\Redis\Command\Builder;
use Dazzle\Redis\Command\Enum;
use Dazzle\Redis\Driver\Request;

trait ApiConnTrait
{
    /**
     * @param Request $request
     * @return mixed
     */
    abstract function dispatch(Request $request);

It is generally recommended to explicitly declare the visibility for methods.

    /**
     * @override
     * @inheritDoc
     */
    public function auth($password)
    {
        $command = Enum::AUTH;
        $args = [$password];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function ping($message = 'PING')

This method seems to be duplicated in your project.

    {
        $command = Enum::PING;
        $args = [$message];

        return $this->dispatch(Builder::build($command, $args));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function quit()
    {
        $command = Enum::QUIT;

        return $this->dispatch(Builder::build($command));
    }

    /**
     * @override
     * @inheritDoc
     */
    public function select($index)

The parameter $index is not used and could be removed.

    {
        // TODO: Implement select() method.
        $command = Enum::SELECT;

$command is not used, you could remove the assignment.

        return $this;
    }
}